| Message ID | 20201105133923.23821-9-kraxel@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | microvm: add second ioapic | expand |
On Thu, 5 Nov 2020 14:39:19 +0100 Gerd Hoffmann <kraxel@redhat.com> wrote: > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h > index dfb8523c8bf4..191ac230b013 100644 > --- a/tests/qtest/bios-tables-test-allowed-diff.h > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > @@ -1 +1,3 @@ > /* List of comma-separated changed AML files to ignore */ > +"tests/data/acpi/microvm/APIC.ioapic2", > +"tests/data/acpi/microvm/DSDT.ioapic2", does adding 2nd ioapic affects DSDT? if not I'd suggest to drop it, test code should fall back to use suffix-less DSDT then.
On Wed, Nov 11, 2020 at 01:50:15PM +0100, Igor Mammedov wrote: > On Thu, 5 Nov 2020 14:39:19 +0100 > Gerd Hoffmann <kraxel@redhat.com> wrote: > > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > > --- > > tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h > > index dfb8523c8bf4..191ac230b013 100644 > > --- a/tests/qtest/bios-tables-test-allowed-diff.h > > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > > @@ -1 +1,3 @@ > > /* List of comma-separated changed AML files to ignore */ > > +"tests/data/acpi/microvm/APIC.ioapic2", > > +"tests/data/acpi/microvm/DSDT.ioapic2", > > does adding 2nd ioapic affects DSDT? > if not I'd suggest to drop it, test code should fall back to > use suffix-less DSDT then. BTW maybe we should add checkpatch code verifying that identical tables are suffix-less - want to try doing that?
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8bf4..191ac230b013 100644 --- a/tests/qtest/bios-tables-test-allowed-diff.h +++ b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1 +1,3 @@ /* List of comma-separated changed AML files to ignore */ +"tests/data/acpi/microvm/APIC.ioapic2", +"tests/data/acpi/microvm/DSDT.ioapic2",
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ 1 file changed, 2 insertions(+)