| Message ID | 20201113100602.15936-1-kwolf@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [for-5.2] iotests: Replace deprecated ConfigParser.readfp() | expand |
On 11/13/20 4:06 AM, Kevin Wolf wrote: > iotest 277 fails on Fedora 33 (Python 3.9) because a deprecation warning > changes the output: > > nbd-fault-injector.py:230: DeprecationWarning: This method will be > removed in future versions. Use 'parser.read_file()' instead. > > In fact, readfp() has already been deprecated in Python 3.2 and the > replacement has existed since the same version, so we can now > unconditionally switch to read_file(). > > Signed-off-by: Kevin Wolf <kwolf@redhat.com> > --- > tests/qemu-iotests/nbd-fault-injector.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake <eblake@redhat.com> I'm happy to queue this through my NBD tree for -rc2. > > diff --git a/tests/qemu-iotests/nbd-fault-injector.py b/tests/qemu-iotests/nbd-fault-injector.py > index 78f42c4214..6e11ef89b8 100755 > --- a/tests/qemu-iotests/nbd-fault-injector.py > +++ b/tests/qemu-iotests/nbd-fault-injector.py > @@ -227,7 +227,7 @@ def parse_config(config): > def load_rules(filename): > config = configparser.RawConfigParser() > with open(filename, 'rt') as f: > - config.readfp(f, filename) > + config.read_file(f, filename) > return parse_config(config) > > def open_socket(path): >
Am 13.11.2020 um 14:47 hat Eric Blake geschrieben: > On 11/13/20 4:06 AM, Kevin Wolf wrote: > > iotest 277 fails on Fedora 33 (Python 3.9) because a deprecation warning > > changes the output: > > > > nbd-fault-injector.py:230: DeprecationWarning: This method will be > > removed in future versions. Use 'parser.read_file()' instead. > > > > In fact, readfp() has already been deprecated in Python 3.2 and the > > replacement has existed since the same version, so we can now > > unconditionally switch to read_file(). > > > > Signed-off-by: Kevin Wolf <kwolf@redhat.com> > > --- > > tests/qemu-iotests/nbd-fault-injector.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Eric Blake <eblake@redhat.com> > > I'm happy to queue this through my NBD tree for -rc2. If you don't have other patches to send, I can take it through my own tree, but if you send a pull request anyway, that's fine, too. Kevin
On 11/13/20 8:40 AM, Kevin Wolf wrote: > Am 13.11.2020 um 14:47 hat Eric Blake geschrieben: >> On 11/13/20 4:06 AM, Kevin Wolf wrote: >>> iotest 277 fails on Fedora 33 (Python 3.9) because a deprecation warning >>> changes the output: >>> >>> nbd-fault-injector.py:230: DeprecationWarning: This method will be >>> removed in future versions. Use 'parser.read_file()' instead. >>> >>> In fact, readfp() has already been deprecated in Python 3.2 and the >>> replacement has existed since the same version, so we can now >>> unconditionally switch to read_file(). >>> >>> Signed-off-by: Kevin Wolf <kwolf@redhat.com> >>> --- >>> tests/qemu-iotests/nbd-fault-injector.py | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Reviewed-by: Eric Blake <eblake@redhat.com> >> >> I'm happy to queue this through my NBD tree for -rc2. > > If you don't have other patches to send, I can take it through my own > tree, but if you send a pull request anyway, that's fine, too. I've got at least one other NBD patch, and am double-checking my trees and flagged inbox messages to see if there are any other last-minute -rc2 candidates, so I will be sending a Pull Request on Monday.
On 11/13/20 11:06 AM, Kevin Wolf wrote: > iotest 277 fails on Fedora 33 (Python 3.9) because a deprecation warning > changes the output: > > nbd-fault-injector.py:230: DeprecationWarning: This method will be > removed in future versions. Use 'parser.read_file()' instead. > > In fact, readfp() has already been deprecated in Python 3.2 and the > replacement has existed since the same version, so we can now > unconditionally switch to read_file(). > > Signed-off-by: Kevin Wolf <kwolf@redhat.com> > --- > tests/qemu-iotests/nbd-fault-injector.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff --git a/tests/qemu-iotests/nbd-fault-injector.py b/tests/qemu-iotests/nbd-fault-injector.py index 78f42c4214..6e11ef89b8 100755 --- a/tests/qemu-iotests/nbd-fault-injector.py +++ b/tests/qemu-iotests/nbd-fault-injector.py @@ -227,7 +227,7 @@ def parse_config(config): def load_rules(filename): config = configparser.RawConfigParser() with open(filename, 'rt') as f: - config.readfp(f, filename) + config.read_file(f, filename) return parse_config(config) def open_socket(path):
iotest 277 fails on Fedora 33 (Python 3.9) because a deprecation warning changes the output: nbd-fault-injector.py:230: DeprecationWarning: This method will be removed in future versions. Use 'parser.read_file()' instead. In fact, readfp() has already been deprecated in Python 3.2 and the replacement has existed since the same version, so we can now unconditionally switch to read_file(). Signed-off-by: Kevin Wolf <kwolf@redhat.com> --- tests/qemu-iotests/nbd-fault-injector.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)