| Message ID | 20201112075208.28183-2-wenbin.mei@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Set cqe off during suspend flow | expand |
On Thu, Nov 12, 2020 at 03:52:06PM +0800, Wenbin Mei wrote: > Add optional properties for cqe hosts which are used to set cqe off > during suspend flow. > > Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com> > --- > Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > index b96da0c7f819..457c9a84b988 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > @@ -164,6 +164,13 @@ properties: > description: > enable SDIO IRQ signalling on this interface > > + cqe-off-in-suspend: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + After suspend, the mmc host is powered off by HW, and bring CQE register > + to default state, so we add the flag to re-init CQE register after resume > + back. The driver change is before suspend, but this says on resume... In any case, this should be implied by the SoC specific compatible. > + > full-pwr-cycle: > $ref: /schemas/types.yaml#/definitions/flag > description: > -- > 2.18.0 >
On Mon, 2020-11-16 at 13:28 -0600, Rob Herring wrote: > On Thu, Nov 12, 2020 at 03:52:06PM +0800, Wenbin Mei wrote: > > Add optional properties for cqe hosts which are used to set cqe off > > during suspend flow. > > > > Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com> > > --- > > Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > > index b96da0c7f819..457c9a84b988 100644 > > --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > > +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > > @@ -164,6 +164,13 @@ properties: > > description: > > enable SDIO IRQ signalling on this interface > > > > + cqe-off-in-suspend: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + After suspend, the mmc host is powered off by HW, and bring CQE register > > + to default state, so we add the flag to re-init CQE register after resume > > + back. > > The driver change is before suspend, but this says on resume... > > In any case, this should be implied by the SoC specific compatible. > Thanks for your reply, I will drop this patchset, and resend another patchset for this issue. > > + > > full-pwr-cycle: > > $ref: /schemas/types.yaml#/definitions/flag > > description: > > -- > > 2.18.0 > >
diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml index b96da0c7f819..457c9a84b988 100644 --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml @@ -164,6 +164,13 @@ properties: description: enable SDIO IRQ signalling on this interface + cqe-off-in-suspend: + $ref: /schemas/types.yaml#/definitions/flag + description: + After suspend, the mmc host is powered off by HW, and bring CQE register + to default state, so we add the flag to re-init CQE register after resume + back. + full-pwr-cycle: $ref: /schemas/types.yaml#/definitions/flag description:
Add optional properties for cqe hosts which are used to set cqe off during suspend flow. Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com> --- Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 7 +++++++ 1 file changed, 7 insertions(+)