diff mbox series

[09/15] input: misc: wm831x-on: Source file headers are not good candidates for kernel-doc

Message ID 20201112110204.2083435-10-lee.jones@linaro.org (mailing list archive)
State Superseded
Commit ced8c61fa8c79b02d29a351a7e87ce3b413f04e4
Headers show
Series Rid W=1 issues from Input | expand

Commit Message

Lee Jones Nov. 12, 2020, 11:01 a.m. UTC
Fixes the following W=1 kernel build warning(s):

 drivers/input/misc/wm831x-on.c:30: warning: cannot understand function prototype: 'struct wm831x_on '

Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: patches@opensource.cirrus.com
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/input/misc/wm831x-on.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Fitzgerald Nov. 12, 2020, 11:20 a.m. UTC | #1
On 12/11/2020 11:01, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>   drivers/input/misc/wm831x-on.c:30: warning: cannot understand function prototype: 'struct wm831x_on '
> 
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: patches@opensource.cirrus.com
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>   drivers/input/misc/wm831x-on.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/misc/wm831x-on.c b/drivers/input/misc/wm831x-on.c
> index 1b44de265a0ad..a42fe041b73c6 100644
> --- a/drivers/input/misc/wm831x-on.c
> +++ b/drivers/input/misc/wm831x-on.c
> @@ -1,4 +1,4 @@
> -/**
> +/*
>    * wm831x-on.c - WM831X ON pin driver
>    *
>    * Copyright (C) 2009 Wolfson Microelectronics plc
> 

Acked-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Dmitry Torokhov Nov. 20, 2020, 3:17 a.m. UTC | #2
On Thu, Nov 12, 2020 at 11:01:58AM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/input/misc/wm831x-on.c:30: warning: cannot understand function prototype: 'struct wm831x_on '
> 
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: patches@opensource.cirrus.com
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied, thank you.
diff mbox series

Patch

diff --git a/drivers/input/misc/wm831x-on.c b/drivers/input/misc/wm831x-on.c
index 1b44de265a0ad..a42fe041b73c6 100644
--- a/drivers/input/misc/wm831x-on.c
+++ b/drivers/input/misc/wm831x-on.c
@@ -1,4 +1,4 @@ 
-/**
+/*
  * wm831x-on.c - WM831X ON pin driver
  *
  * Copyright (C) 2009 Wolfson Microelectronics plc