| Message ID | 1605936082-3099-3-git-send-email-andrey.grodzovsky@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | RFC Support hot device unplug in amdgpu | expand |
Am 21.11.20 um 06:21 schrieb Andrey Grodzovsky: > Invalidate all BOs CPU mappings once device is removed. > > v3: Move the code from TTM into drm_dev_unplug > > Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com> Reviewed-by: Christian König <christian.koenig@amd.com> > --- > drivers/gpu/drm/drm_drv.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c > index 13068fd..d550fd5 100644 > --- a/drivers/gpu/drm/drm_drv.c > +++ b/drivers/gpu/drm/drm_drv.c > @@ -479,6 +479,9 @@ void drm_dev_unplug(struct drm_device *dev) > synchronize_srcu(&drm_unplug_srcu); > > drm_dev_unregister(dev); > + > + /* Clear all CPU mappings pointing to this device */ > + unmap_mapping_range(dev->anon_inode->i_mapping, 0, 0, 1); > } > EXPORT_SYMBOL(drm_dev_unplug); >
On Sat, Nov 21, 2020 at 03:16:15PM +0100, Christian König wrote: > Am 21.11.20 um 06:21 schrieb Andrey Grodzovsky: > > Invalidate all BOs CPU mappings once device is removed. > > > > v3: Move the code from TTM into drm_dev_unplug > > > > Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com> > > Reviewed-by: Christian König <christian.koenig@amd.com> Was wondering for a moment whether this should be in drm_dev_unregister instead, but then it's only one part of the coin really. So Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > > --- > > drivers/gpu/drm/drm_drv.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c > > index 13068fd..d550fd5 100644 > > --- a/drivers/gpu/drm/drm_drv.c > > +++ b/drivers/gpu/drm/drm_drv.c > > @@ -479,6 +479,9 @@ void drm_dev_unplug(struct drm_device *dev) > > synchronize_srcu(&drm_unplug_srcu); > > drm_dev_unregister(dev); > > + > > + /* Clear all CPU mappings pointing to this device */ > > + unmap_mapping_range(dev->anon_inode->i_mapping, 0, 0, 1); > > } > > EXPORT_SYMBOL(drm_dev_unplug); >
diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 13068fd..d550fd5 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -479,6 +479,9 @@ void drm_dev_unplug(struct drm_device *dev) synchronize_srcu(&drm_unplug_srcu); drm_dev_unregister(dev); + + /* Clear all CPU mappings pointing to this device */ + unmap_mapping_range(dev->anon_inode->i_mapping, 0, 0, 1); } EXPORT_SYMBOL(drm_dev_unplug);
Invalidate all BOs CPU mappings once device is removed. v3: Move the code from TTM into drm_dev_unplug Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com> --- drivers/gpu/drm/drm_drv.c | 3 +++ 1 file changed, 3 insertions(+)