| Message ID | cover.1605028524.git.vijayakannan.ayyathurai@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add drivers for Intel Keem Bay SoC watchdog | expand |
On Wed, Nov 11, 2020 at 01:53:06AM +0800, vijayakannan.ayyathurai@intel.com wrote: > From: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com> > > Hi, > > This patch set adds the watchdog timer driver support for Intel Keem Bay Soc. > > Patch 1 holds the driver and Patch 2 holds the Device Tree > binding documentation. > > This driver was tested on the Keem Bay evaluation module board. > > Thank you, > Vijay > > Changes since v1: > - Fix indentation error in the dt-bindings file. > - Use true/false in the second arg of keembay_wdt_set_timeout_reg(). > - Fix the watchdog start sequence. > - Avoid reduntant timeout register setting. > - Remove min usage to find actual time at keembay_wdt_set_timeout(). > - Remove timeout configuration boundary check at > keembay_wdt_set_pretimeout(). > - Use devm_watchdog_register_device() for wdt registration, which > eventually supports driver unload functionality as well. > > Vijayakannan Ayyathurai (2): > watchdog: Add watchdog driver for Intel Keembay Soc > dt-bindings: watchdog: Add bindings for Intel Keem Bay SoC > > .../bindings/watchdog/intel,keembay-wdt.yaml | 57 ++++ > drivers/watchdog/Kconfig | 13 + > drivers/watchdog/Makefile | 1 + > drivers/watchdog/keembay_wdt.c | 288 ++++++++++++++++++ > 4 files changed, 359 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml > create mode 100644 drivers/watchdog/keembay_wdt.c > > > base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec > prerequisite-patch-id: 822987dcf4c969ef6ac70359b088af06ba39042b > prerequisite-patch-id: 0a348762b660d0d817b8e70cc71647e83173c78c > prerequisite-patch-id: 54c661a006c7362053cb7602448d6c77419d5cf9 > prerequisite-patch-id: d140d8534fb828778e0652fe5fcf6282e027f985 these patch-id's are not helpful to me if I want to to a test build of this patch. Those SHA1's are not available to others unless there is a public non-rebasing tree I can pull from. if there is one then you should provide the git remot URL for that otherwise I cannot fetch those prerequisites. Maybe it would be better to list the mailing list archive URL for each change instead. --mark > -- > 2.17.1 >
Hi, > From: Ayyathurai, Vijayakannan <vijayakannan.ayyathurai@intel.com> > Sent: Wednesday, 11 November, 2020 1:53 AM > Subject: [PATCH v2 0/2] Add drivers for Intel Keem Bay SoC watchdog > > From: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com> > > Hi, > > This patch set adds the watchdog timer driver support for Intel Keem Bay Soc. > > Patch 1 holds the driver and Patch 2 holds the Device Tree > binding documentation. > > This driver was tested on the Keem Bay evaluation module board. > > Thank you, > Vijay > > Changes since v1: > - Fix indentation error in the dt-bindings file. > - Use true/false in the second arg of keembay_wdt_set_timeout_reg(). > - Fix the watchdog start sequence. > - Avoid reduntant timeout register setting. > - Remove min usage to find actual time at keembay_wdt_set_timeout(). > - Remove timeout configuration boundary check at > keembay_wdt_set_pretimeout(). > - Use devm_watchdog_register_device() for wdt registration, which > eventually supports driver unload functionality as well. > Please consider review this patch and let me know if there is further feedback. > Vijayakannan Ayyathurai (2): > watchdog: Add watchdog driver for Intel Keembay Soc > dt-bindings: watchdog: Add bindings for Intel Keem Bay SoC > > .../bindings/watchdog/intel,keembay-wdt.yaml | 57 ++++ > drivers/watchdog/Kconfig | 13 + > drivers/watchdog/Makefile | 1 + > drivers/watchdog/keembay_wdt.c | 288 ++++++++++++++++++ > 4 files changed, 359 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml > create mode 100644 drivers/watchdog/keembay_wdt.c > > > base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec > -- > 2.17.1 Thanks, Vijay
From: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com> Hi, This patch set adds the watchdog timer driver support for Intel Keem Bay Soc. Patch 1 holds the driver and Patch 2 holds the Device Tree binding documentation. This driver was tested on the Keem Bay evaluation module board. Thank you, Vijay Changes since v1: - Fix indentation error in the dt-bindings file. - Use true/false in the second arg of keembay_wdt_set_timeout_reg(). - Fix the watchdog start sequence. - Avoid reduntant timeout register setting. - Remove min usage to find actual time at keembay_wdt_set_timeout(). - Remove timeout configuration boundary check at keembay_wdt_set_pretimeout(). - Use devm_watchdog_register_device() for wdt registration, which eventually supports driver unload functionality as well. Vijayakannan Ayyathurai (2): watchdog: Add watchdog driver for Intel Keembay Soc dt-bindings: watchdog: Add bindings for Intel Keem Bay SoC .../bindings/watchdog/intel,keembay-wdt.yaml | 57 ++++ drivers/watchdog/Kconfig | 13 + drivers/watchdog/Makefile | 1 + drivers/watchdog/keembay_wdt.c | 288 ++++++++++++++++++ 4 files changed, 359 insertions(+) create mode 100644 Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml create mode 100644 drivers/watchdog/keembay_wdt.c base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec prerequisite-patch-id: 822987dcf4c969ef6ac70359b088af06ba39042b prerequisite-patch-id: 0a348762b660d0d817b8e70cc71647e83173c78c prerequisite-patch-id: 54c661a006c7362053cb7602448d6c77419d5cf9 prerequisite-patch-id: d140d8534fb828778e0652fe5fcf6282e027f985