| Message ID | 1804f48dac434541dc60ada5eefcb86f74905671.1605896060.git.gustavoars@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix fall-through warnings for Clang | expand |
On Fri, Nov 20, 2020 at 12:40:14PM -0600, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > drivers/char/tpm/eventlog/tpm1.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog/tpm1.c > index 2c96977ad080..8aa9057601d6 100644 > --- a/drivers/char/tpm/eventlog/tpm1.c > +++ b/drivers/char/tpm/eventlog/tpm1.c > @@ -210,6 +210,7 @@ static int get_event_name(char *dest, struct tcpa_event *event, > default: > break; > } > + break; > default: > break; > } > -- > 2.27.0 > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@iki.fi> Who is picking these patches? /Jarkko
On Tue, Nov 24, 2020 at 12:52:31AM +0200, Jarkko Sakkinen wrote: > On Fri, Nov 20, 2020 at 12:40:14PM -0600, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > by explicitly adding a break statement instead of letting the code fall > > through to the next case. > > > > Link: https://github.com/KSPP/linux/issues/115 > > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > > --- > > drivers/char/tpm/eventlog/tpm1.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog/tpm1.c > > index 2c96977ad080..8aa9057601d6 100644 > > --- a/drivers/char/tpm/eventlog/tpm1.c > > +++ b/drivers/char/tpm/eventlog/tpm1.c > > @@ -210,6 +210,7 @@ static int get_event_name(char *dest, struct tcpa_event *event, > > default: > > break; > > } > > + break; > > default: > > break; > > } > > -- > > 2.27.0 > > > > > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@iki.fi> > > Who is picking these patches? > > /Jarkko I mean Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> /Jarkko
On Tue, Nov 24, 2020 at 12:53:22AM +0200, Jarkko Sakkinen wrote: > On Tue, Nov 24, 2020 at 12:52:31AM +0200, Jarkko Sakkinen wrote: > > On Fri, Nov 20, 2020 at 12:40:14PM -0600, Gustavo A. R. Silva wrote: > > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > > by explicitly adding a break statement instead of letting the code fall > > > through to the next case. > > > > > > Link: https://github.com/KSPP/linux/issues/115 > > > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > > > --- > > > drivers/char/tpm/eventlog/tpm1.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog/tpm1.c > > > index 2c96977ad080..8aa9057601d6 100644 > > > --- a/drivers/char/tpm/eventlog/tpm1.c > > > +++ b/drivers/char/tpm/eventlog/tpm1.c > > > @@ -210,6 +210,7 @@ static int get_event_name(char *dest, struct tcpa_event *event, > > > default: > > > break; > > > } > > > + break; > > > default: > > > break; > > > } > > > -- > > > 2.27.0 > > > > > > > > > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@iki.fi> > > > > Who is picking these patches? I can take it in my tree for 5.11 if people are OK with that. :) > > > > /Jarkko > > I mean > > Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> Thanks, Jarkko. -- Gustavo
On Tue, 2020-11-24 at 08:40 -0600, Gustavo A. R. Silva wrote: > On Tue, Nov 24, 2020 at 12:53:22AM +0200, Jarkko Sakkinen wrote: > > On Tue, Nov 24, 2020 at 12:52:31AM +0200, Jarkko Sakkinen wrote: > > > On Fri, Nov 20, 2020 at 12:40:14PM -0600, Gustavo A. R. Silva wrote: > > > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > > > by explicitly adding a break statement instead of letting the code fall > > > > through to the next case. > > > > > > > > Link: https://github.com/KSPP/linux/issues/115 > > > > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > > > > --- > > > > drivers/char/tpm/eventlog/tpm1.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog/tpm1.c > > > > index 2c96977ad080..8aa9057601d6 100644 > > > > --- a/drivers/char/tpm/eventlog/tpm1.c > > > > +++ b/drivers/char/tpm/eventlog/tpm1.c > > > > @@ -210,6 +210,7 @@ static int get_event_name(char *dest, struct tcpa_event *event, > > > > default: > > > > break; > > > > } > > > > + break; > > > > default: > > > > break; > > > > } > > > > -- > > > > 2.27.0 > > > > > > > > > > > > > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@iki.fi> > > > > > > Who is picking these patches? > > I can take it in my tree for 5.11 if people are OK with that. :) > > > > > > > /Jarkko > > > > I mean > > > > Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> > > Thanks, Jarkko. > -- > Gustavo keyring: https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?id=a49bdffa9db63a54a6ac56cdcdef8cc8f404f4b6 TPM: https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?id=1ce46c91fdfe5ebf27a6d328b108c630406d1c8c Looks good? /Jarkko
diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog/tpm1.c index 2c96977ad080..8aa9057601d6 100644 --- a/drivers/char/tpm/eventlog/tpm1.c +++ b/drivers/char/tpm/eventlog/tpm1.c @@ -210,6 +210,7 @@ static int get_event_name(char *dest, struct tcpa_event *event, default: break; } + break; default: break; }
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/char/tpm/eventlog/tpm1.c | 1 + 1 file changed, 1 insertion(+)