| Message ID | b3c1c3f9c76f2f0e832f956587f227e44af57d3d.1605896060.git.gustavoars@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix fall-through warnings for Clang | expand |
On Fri, 20 Nov 2020 12:36:26 -0600 "Gustavo A. R. Silva" <gustavoars@kernel.org> wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Hi Gustavo, I'm assuming there is no 'huge' rush for these an intent is that they will filter through the various subsystems. Hence I've queued it up for the next merge window. Applied to the togreg branch of iio.git Thanks, Jonathan > --- > drivers/iio/adc/cpcap-adc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/adc/cpcap-adc.c b/drivers/iio/adc/cpcap-adc.c > index 64c3cc382311..f19c9aa93f17 100644 > --- a/drivers/iio/adc/cpcap-adc.c > +++ b/drivers/iio/adc/cpcap-adc.c > @@ -557,6 +557,7 @@ static void cpcap_adc_setup_bank(struct cpcap_adc *ddata, > break; > case CPCAP_ADC_BATTP_PI16 ... CPCAP_ADC_BATTI_PI17: > value1 |= CPCAP_BIT_RAND1; > + break; > default: > break; > }
On Sat, Nov 21, 2020 at 03:05:04PM +0000, Jonathan Cameron wrote: > On Fri, 20 Nov 2020 12:36:26 -0600 > "Gustavo A. R. Silva" <gustavoars@kernel.org> wrote: > > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > by explicitly adding a break statement instead of letting the code fall > > through to the next case. > > > > Link: https://github.com/KSPP/linux/issues/115 > > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > Hi Gustavo, Hi Jonathan, > I'm assuming there is no 'huge' rush for these an intent is that they will > filter through the various subsystems. Hence I've queued it up for the > next merge window. Yep; no rush for this. > Applied to the togreg branch of iio.git Thank you! -- Gustavo
diff --git a/drivers/iio/adc/cpcap-adc.c b/drivers/iio/adc/cpcap-adc.c index 64c3cc382311..f19c9aa93f17 100644 --- a/drivers/iio/adc/cpcap-adc.c +++ b/drivers/iio/adc/cpcap-adc.c @@ -557,6 +557,7 @@ static void cpcap_adc_setup_bank(struct cpcap_adc *ddata, break; case CPCAP_ADC_BATTP_PI16 ... CPCAP_ADC_BATTI_PI17: value1 |= CPCAP_BIT_RAND1; + break; default: break; }
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/iio/adc/cpcap-adc.c | 1 + 1 file changed, 1 insertion(+)