| Message ID | 20201120200913.618274-1-swboyd@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d5276bfa0ca6af7f65896c222b1b60493d189f27 |
| Headers | show |
| Series | arm64: dts: qcom: sc7180: Remove double pull-up on p-sensor-int-l | expand |
Hi, On Fri, Nov 20, 2020 at 12:09 PM Stephen Boyd <swboyd@chromium.org> wrote: > > This interrupt has an external pull-up so we don't need to pull it up > again. Drop the internal pull here. Note I don't think this really > changes anything, just noticed while looking at this irq pin. > > Cc: Douglas Anderson <dianders@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Douglas Anderson <dianders@chromium.org>
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Fri, 20 Nov 2020 12:09:13 -0800 you wrote: > This interrupt has an external pull-up so we don't need to pull it up > again. Drop the internal pull here. Note I don't think this really > changes anything, just noticed while looking at this irq pin. > > Cc: Douglas Anderson <dianders@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > > [...] Here is the summary with links: - arm64: dts: qcom: sc7180: Remove double pull-up on p-sensor-int-l https://git.kernel.org/qcom/c/d5276bfa0ca6 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index d48a75afdafb..3eb1ff2483be 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -1331,7 +1331,8 @@ pinmux { pinconf { pins = "gpio24"; - bias-pull-up; + /* Has external pullup */ + bias-disable; }; };
This interrupt has an external pull-up so we don't need to pull it up again. Drop the internal pull here. Note I don't think this really changes anything, just noticed while looking at this irq pin. Cc: Douglas Anderson <dianders@chromium.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) base-commit: ead9f7d7ea9e20843e29e688b53859cea20044ee prerequisite-patch-id: 239dd75c9c3d2ef544f95466280f296fc217c096