mbox series

[0/5] memory: renesas-rpc-if: Trivial fixes

Message ID 20201124112552.26377-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive)
Headers show
Series memory: renesas-rpc-if: Trivial fixes | expand

Message

Prabhakar Nov. 24, 2020, 11:25 a.m. UTC
Hi All,

This patch series fixes trivial issues in RPC-IF driver.

Cheers,
Prabhakar

Lad Prabhakar (5):
  memory: renesas-rpc-if: Return correct value to the caller of
    rpcif_manual_xfer()
  memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static
    inline
  memory: renesas-rpc-if: Export symbols as GPL
  memory: renesas-rpc-if: Avoid use of C++ style comments
  memory: renesas-rpc-if: Fix a reference leak in rpcif_probe()

 drivers/memory/renesas-rpc-if.c | 28 +++++++++-------------------
 include/memory/renesas-rpc-if.h | 19 ++++++++++++++-----
 2 files changed, 23 insertions(+), 24 deletions(-)

Comments

Lad, Prabhakar Nov. 24, 2020, 11:34 a.m. UTC | #1
Hi Sergei,

On Tue, Nov 24, 2020 at 11:26 AM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
>
> Hi All,
>
> This patch series fixes trivial issues in RPC-IF driver.
>
> Cheers,
> Prabhakar
>
> Lad Prabhakar (5):
>   memory: renesas-rpc-if: Return correct value to the caller of
>     rpcif_manual_xfer()
>   memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static
>     inline
>   memory: renesas-rpc-if: Export symbols as GPL
>   memory: renesas-rpc-if: Avoid use of C++ style comments
>   memory: renesas-rpc-if: Fix a reference leak in rpcif_probe()
>
Patches sent to sergei.shtylyov@cogentembedded.com have bounced back
so including gmail address (patchwork [1]).

[1] https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=390163

Cheers,
Prabhakar


>  drivers/memory/renesas-rpc-if.c | 28 +++++++++-------------------
>  include/memory/renesas-rpc-if.h | 19 ++++++++++++++-----
>  2 files changed, 23 insertions(+), 24 deletions(-)
>
> --
> 2.17.1
>
Sergey Shtylyov Nov. 24, 2020, 6:25 p.m. UTC | #2
On 11/24/20 2:34 PM, Lad, Prabhakar wrote:

[...]
>> This patch series fixes trivial issues in RPC-IF driver.
>>
>> Cheers,
>> Prabhakar
>>
>> Lad Prabhakar (5):
>>   memory: renesas-rpc-if: Return correct value to the caller of
>>     rpcif_manual_xfer()
>>   memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static
>>     inline
>>   memory: renesas-rpc-if: Export symbols as GPL
>>   memory: renesas-rpc-if: Avoid use of C++ style comments
>>   memory: renesas-rpc-if: Fix a reference leak in rpcif_probe()
>>
> Patches sent to sergei.shtylyov@cogentembedded.com have bounced back
> so including gmail address (patchwork [1]).

   Sorry, I got laid off by Cogent last May. Thanks for CCing my gmail address...

> [1] https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=390163
> 
> Cheers,
> Prabhakar

[...]

MBR, Sergei
Lad, Prabhakar Nov. 25, 2020, 1:31 p.m. UTC | #3
On Tue, Nov 24, 2020 at 6:25 PM Sergei Shtylyov
<sergei.shtylyov@gmail.com> wrote:
>
> On 11/24/20 2:34 PM, Lad, Prabhakar wrote:
>
> [...]
> >> This patch series fixes trivial issues in RPC-IF driver.
> >>
> >> Cheers,
> >> Prabhakar
> >>
> >> Lad Prabhakar (5):
> >>   memory: renesas-rpc-if: Return correct value to the caller of
> >>     rpcif_manual_xfer()
> >>   memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static
> >>     inline
> >>   memory: renesas-rpc-if: Export symbols as GPL
> >>   memory: renesas-rpc-if: Avoid use of C++ style comments
> >>   memory: renesas-rpc-if: Fix a reference leak in rpcif_probe()
> >>
> > Patches sent to sergei.shtylyov@cogentembedded.com have bounced back
> > so including gmail address (patchwork [1]).
>
>    Sorry, I got laid off by Cogent last May. Thanks for CCing my gmail address...
>
Sorry to hear that.

Thank you for the review. I'll fix the review comments for patch 2/2
and post a v2.

Cheers,
Prabhakar