| Message ID | 20201123075526epcms2p59410a8ba942f8942f53a593d9df764d0@epcms2p5 (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,1/2] dt-bindings: net: nfc: s3fwrn5: Support a UART interface | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 45 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Mon, Nov 23, 2020 at 04:55:26PM +0900, Bongsu Jeon wrote: > Since S3FWRN82 NFC Chip, The UART interface can be used. > S3FWRN82 supports I2C and UART interface. > > Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> > --- > .../bindings/net/nfc/samsung,s3fwrn5.yaml | 28 +++++++++++++++++-- > 1 file changed, 26 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml > index cb0b8a560282..37b3e5ae5681 100644 > --- a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml > +++ b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml > @@ -13,6 +13,7 @@ maintainers: > properties: > compatible: > const: samsung,s3fwrn5-i2c > + const: samsung,s3fwrn82-uart This does not work, you need to use enum. Did you run at least dt_bindings_check? The compatible should be just "samsung,s3fwrn82". I think it was a mistake in the first s3fwrn5 submission to add a interface to compatible. > > en-gpios: > maxItems: 1 > @@ -47,10 +48,19 @@ additionalProperties: false > required: > - compatible > - en-gpios > - - interrupts > - - reg > - wake-gpios > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: samsung,s3fwrn5-i2c > + then: > + required: > + - interrupts > + - reg > + > examples: > - | > #include <dt-bindings/gpio/gpio.h> > @@ -71,3 +81,17 @@ examples: > wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>; > }; > }; > + # UART example on Raspberry Pi > + - | > + &uart0 { > + status = "okay"; > + > + s3fwrn82_uart { Just "bluetooth" to follow Devicetree specification. Best regards, Krzysztof
On Mon, Nov 23, 2020 at 5:02 PM krzk@kernel.org <krzk@kernel.org> wrote: > > On Mon, Nov 23, 2020 at 04:55:26PM +0900, Bongsu Jeon wrote: > > Since S3FWRN82 NFC Chip, The UART interface can be used. > > S3FWRN82 supports I2C and UART interface. > > > > Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> > > --- > > .../bindings/net/nfc/samsung,s3fwrn5.yaml | 28 +++++++++++++++++-- > > 1 file changed, 26 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml > > index cb0b8a560282..37b3e5ae5681 100644 > > --- a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml > > +++ b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml > > @@ -13,6 +13,7 @@ maintainers: > > properties: > > compatible: > > const: samsung,s3fwrn5-i2c > > + const: samsung,s3fwrn82-uart > > This does not work, you need to use enum. Did you run at least > dt_bindings_check? > Sorry. I didn't. I fixed it as below and ran dt_bindings_check. compatible: oneOf: - enum: - samsung,s3fwrn5-i2c - samsung,s3fwrn82 > The compatible should be just "samsung,s3fwrn82". I think it was a > mistake in the first s3fwrn5 submission to add a interface to > compatible. > Ok. I will change the name. > > > > en-gpios: > > maxItems: 1 > > @@ -47,10 +48,19 @@ additionalProperties: false > > required: > > - compatible > > - en-gpios > > - - interrupts > > - - reg > > - wake-gpios > > > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: samsung,s3fwrn5-i2c > > + then: > > + required: > > + - interrupts > > + - reg > > + > > examples: > > - | > > #include <dt-bindings/gpio/gpio.h> > > @@ -71,3 +81,17 @@ examples: > > wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>; > > }; > > }; > > + # UART example on Raspberry Pi > > + - | > > + &uart0 { > > + status = "okay"; > > + > > + s3fwrn82_uart { > > Just "bluetooth" to follow Devicetree specification. Sorry. I don't understand this comment. Could you explain it? Does it mean i need to refer to the net/broadcom-bluetooth.txt? > > Best regards, > Krzysztof
On Tue, Nov 24, 2020 at 08:39:40PM +0900, Bongsu Jeon wrote: > On Mon, Nov 23, 2020 at 5:02 PM krzk@kernel.org <krzk@kernel.org> wrote: > > > > On Mon, Nov 23, 2020 at 04:55:26PM +0900, Bongsu Jeon wrote: > > examples: > > > - | > > > #include <dt-bindings/gpio/gpio.h> > > > @@ -71,3 +81,17 @@ examples: > > > wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>; > > > }; > > > }; > > > + # UART example on Raspberry Pi > > > + - | > > > + &uart0 { > > > + status = "okay"; > > > + > > > + s3fwrn82_uart { > > > > Just "bluetooth" to follow Devicetree specification. > Sorry. I don't understand this comment. > Could you explain it? > Does it mean i need to refer to the net/broadcom-bluetooth.txt? The node name should be "bluetooth", not "s3fwrn82_uart", because of Devicetree naming convention - node names should represent generic class of a device. Best regards, Krzysztof
On 11/24/20, krzk@kernel.org <krzk@kernel.org> wrote: > On Tue, Nov 24, 2020 at 08:39:40PM +0900, Bongsu Jeon wrote: >> On Mon, Nov 23, 2020 at 5:02 PM krzk@kernel.org <krzk@kernel.org> wrote: >> > >> > On Mon, Nov 23, 2020 at 04:55:26PM +0900, Bongsu Jeon wrote: > > > examples: >> > > - | >> > > #include <dt-bindings/gpio/gpio.h> >> > > @@ -71,3 +81,17 @@ examples: >> > > wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>; >> > > }; >> > > }; >> > > + # UART example on Raspberry Pi >> > > + - | >> > > + &uart0 { >> > > + status = "okay"; >> > > + >> > > + s3fwrn82_uart { >> > >> > Just "bluetooth" to follow Devicetree specification. >> Sorry. I don't understand this comment. >> Could you explain it? >> Does it mean i need to refer to the net/broadcom-bluetooth.txt? > > The node name should be "bluetooth", not "s3fwrn82_uart", because of > Devicetree naming convention - node names should represent generic class > of a device. > Actually, RN82 is the nfc device. So, is it okay to use the name as nfc instead of Bluetooth? > Best regards, > Krzysztof > >
On Wed, 25 Nov 2020 at 04:08, Bongsu Jeon <bongsu.jeon2@gmail.com> wrote: > > On 11/24/20, krzk@kernel.org <krzk@kernel.org> wrote: > > On Tue, Nov 24, 2020 at 08:39:40PM +0900, Bongsu Jeon wrote: > >> On Mon, Nov 23, 2020 at 5:02 PM krzk@kernel.org <krzk@kernel.org> wrote: > >> > > >> > On Mon, Nov 23, 2020 at 04:55:26PM +0900, Bongsu Jeon wrote: > > > > examples: > >> > > - | > >> > > #include <dt-bindings/gpio/gpio.h> > >> > > @@ -71,3 +81,17 @@ examples: > >> > > wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>; > >> > > }; > >> > > }; > >> > > + # UART example on Raspberry Pi > >> > > + - | > >> > > + &uart0 { > >> > > + status = "okay"; > >> > > + > >> > > + s3fwrn82_uart { > >> > > >> > Just "bluetooth" to follow Devicetree specification. > >> Sorry. I don't understand this comment. > >> Could you explain it? > >> Does it mean i need to refer to the net/broadcom-bluetooth.txt? > > > > The node name should be "bluetooth", not "s3fwrn82_uart", because of > > Devicetree naming convention - node names should represent generic class > > of a device. > > > Actually, RN82 is the nfc device. > So, is it okay to use the name as nfc instead of Bluetooth? Oops, of course, nfc, I don't know why the Bluetooth stuck in my mind. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml index cb0b8a560282..37b3e5ae5681 100644 --- a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml +++ b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml @@ -13,6 +13,7 @@ maintainers: properties: compatible: const: samsung,s3fwrn5-i2c + const: samsung,s3fwrn82-uart en-gpios: maxItems: 1 @@ -47,10 +48,19 @@ additionalProperties: false required: - compatible - en-gpios - - interrupts - - reg - wake-gpios +allOf: + - if: + properties: + compatible: + contains: + const: samsung,s3fwrn5-i2c + then: + required: + - interrupts + - reg + examples: - | #include <dt-bindings/gpio/gpio.h> @@ -71,3 +81,17 @@ examples: wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>; }; }; + # UART example on Raspberry Pi + - | + &uart0 { + status = "okay"; + + s3fwrn82_uart { + compatible = "samsung,s3fwrn82-uart"; + + en-gpios = <&gpio 20 0>; + wake-gpios = <&gpio 16 0>; + + status = "okay"; + }; + };
Since S3FWRN82 NFC Chip, The UART interface can be used. S3FWRN82 supports I2C and UART interface. Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> --- .../bindings/net/nfc/samsung,s3fwrn5.yaml | 28 +++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-)