dt-bindings: PCI: rcar: Add device tree support for r8a7742

Commit Message

Biju Das Nov. 24, 2020, 5:40 p.m. UTC

From: Lad Prabhakar <[e-mail]>

commit d16d538ff49145b153976bd8e124116d369db266 upstream.

Add support for r8a7742. The Renesas RZ/G1H (R8A7742) PCIe controller
is identical to the R-Car Gen2 family.

Link: https://lore.kernel.org/r/[e-mail]
Signed-off-by: Lad Prabhakar <[e-mail]>
Signed-off-by: Lorenzo Pieralisi <[e-mail]>
Reviewed-by: Chris Paterson <[e-mail]>
Reviewed-by: Geert Uytterhoeven <[e-mail]>
Reviewed-by: Yoshihiro Shimoda <[e-mail]>
Acked-by: Rob Herring <[e-mail]>
Signed-off-by: Biju Das <[e-mail]>
---
 Documentation/devicetree/bindings/pci/rcar-pci.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Pavel Machek Nov. 24, 2020, 5:58 p.m. UTC | #1

Hi!

> From: Lad Prabhakar <[e-mail]>
> 
> commit d16d538ff49145b153976bd8e124116d369db266 upstream.
> 
> Add support for r8a7742. The Renesas RZ/G1H (R8A7742) PCIe controller
> is identical to the R-Car Gen2 family.


Sure, we can apply this (I assume it is for 4.4)? But it will not
really add any support, it just documents the binding... so I assume
this should go into series with patches that actually change the dts
(and probably tweak the drivers)?

Best regards,
								Pavel

> diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt b/Documentation/devicetree/bindings/pci/rcar-pci.txt
> index bedfdc122543..8a3d8b5be515 100644
> --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt
> +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt
> @@ -1,7 +1,8 @@
>  * Renesas R-Car PCIe interface
>  
>  Required properties:
> -compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC;
> +compatible: "renesas,pcie-r8a7742" for the R8A7742 SoC;
> +	    "renesas,pcie-r8a7743" for the R8A7743 SoC;
>  	    "renesas,pcie-r8a7779" for the R8A7779 SoC;
>  	    "renesas,pcie-r8a7790" for the R8A7790 SoC;
>  	    "renesas,pcie-r8a7791" for the R8A7791 SoC;
> -- 
> 2.17.1
>

Biju Das Nov. 24, 2020, 6:03 p.m. UTC | #2

Hi Pavel,

Thanks for the feedback.

> -----Original Message-----
> From: Pavel Machek <[e-mail]>
> Sent: 24 November 2020 17:58
> To: Biju Das <[e-mail]>
> Cc: [e-mail]; Nobuhiro Iwamatsu
> <[e-mail]>; Pavel Machek <[e-mail]>; Chris
> Paterson <[e-mail]>; Prabhakar Mahadev Lad
> <[e-mail]>
> Subject: Re: [PATCH] dt-bindings: PCI: rcar: Add device tree support for
> r8a7742
> 
> Hi!
> 
> > From: Lad Prabhakar <[e-mail]>
> >
> > commit d16d538ff49145b153976bd8e124116d369db266 upstream.
> >
> > Add support for r8a7742. The Renesas RZ/G1H (R8A7742) PCIe controller
> > is identical to the R-Car Gen2 family.
> 
> 
> Sure, we can apply this (I assume it is for 4.4)? But it will not really
> add any support, it just documents the binding... so I assume this should
> go into series with patches that actually change the dts (and probably
> tweak the drivers)?

We have already backported PCIEC[1] to Linux-4.4.y-cip. Only dt binding patch was pending.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/commit/arch/arm/boot/dts/r8a7742.dtsi?h=linux-4.4.y-cip&id=f7305b488be9e3048f0ee30bb7a83d6041728d7f

Regards,
Biju


> Best regards,
> 								Pavel
> 
> > diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt
> > b/Documentation/devicetree/bindings/pci/rcar-pci.txt
> > index bedfdc122543..8a3d8b5be515 100644
> > --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt
> > +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt
> > @@ -1,7 +1,8 @@
> >  * Renesas R-Car PCIe interface
> >
> >  Required properties:
> > -compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC;
> > +compatible: "renesas,pcie-r8a7742" for the R8A7742 SoC;
> > +	    "renesas,pcie-r8a7743" for the R8A7743 SoC;
> >  	    "renesas,pcie-r8a7779" for the R8A7779 SoC;
> >  	    "renesas,pcie-r8a7790" for the R8A7790 SoC;
> >  	    "renesas,pcie-r8a7791" for the R8A7791 SoC;
> > --
> > 2.17.1
> >
> 
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5879): https://lists.cip-project.org/g/cip-dev/message/5879
Mute This Topic: https://lists.cip-project.org/mt/78482468/4520388
Group Owner: [e-mail]
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [[e-mail]]
-=-=-=-=-=-=-=-=-=-=-=-

Pavel Machek Nov. 24, 2020, 7:27 p.m. UTC | #3

Hi!

> Thanks for the feedback.

> > > From: Lad Prabhakar <[e-mail]>
> > >
> > > commit d16d538ff49145b153976bd8e124116d369db266 upstream.
> > >
> > > Add support for r8a7742. The Renesas RZ/G1H (R8A7742) PCIe controller
> > > is identical to the R-Car Gen2 family.
> > 
> > 
> > Sure, we can apply this (I assume it is for 4.4)? But it will not really
> > add any support, it just documents the binding... so I assume this should
> > go into series with patches that actually change the dts (and probably
> > tweak the drivers)?
> 
> We have already backported PCIEC[1] to Linux-4.4.y-cip. Only dt binding patch was pending.
>

Aha. Sorry for the noise. I'll apply it if there are no other
comments.

Best regards,
								Pavel

Nobuhiro Iwamatsu Nov. 25, 2020, 6:26 a.m. UTC | #4

Hi,

> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]] On Behalf Of Pavel Machek
> Sent: Wednesday, November 25, 2020 4:28 AM
> To: Biju Das <[e-mail]>
> Cc: Pavel Machek <[e-mail]>; [e-mail]; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ)
> <[e-mail]>; Chris Paterson <[e-mail]>; Prabhakar Mahadev Lad
> <[e-mail]>
> Subject: Re: [cip-dev] [PATCH] dt-bindings: PCI: rcar: Add device tree support for r8a7742
> 
> Hi!
> 
> > Thanks for the feedback.
> 
> > > > From: Lad Prabhakar <[e-mail]>
> > > >
> > > > commit d16d538ff49145b153976bd8e124116d369db266 upstream.
> > > >
> > > > Add support for r8a7742. The Renesas RZ/G1H (R8A7742) PCIe controller
> > > > is identical to the R-Car Gen2 family.
> > >
> > >
> > > Sure, we can apply this (I assume it is for 4.4)? But it will not really
> > > add any support, it just documents the binding... so I assume this should
> > > go into series with patches that actually change the dts (and probably
> > > tweak the drivers)?
> >
> > We have already backported PCIEC[1] to Linux-4.4.y-cip. Only dt binding patch was pending.
> >
> 
> Aha. Sorry for the noise. I'll apply it if there are no other
> comments.
> 

I don't see any problems with this patch. I applied and pushed.

Best regards,
  Nobuhiro
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5867): https://lists.cip-project.org/g/cip-dev/message/5867
Mute This Topic: https://lists.cip-project.org/mt/78482468/4520388
Group Owner: [e-mail]
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [[e-mail]]
-=-=-=-=-=-=-=-=-=-=-=-

Patch

diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt b/Documentation/devicetree/bindings/pci/rcar-pci.txt
index bedfdc122543..8a3d8b5be515 100644
--- a/Documentation/devicetree/bindings/pci/rcar-pci.txt
+++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt
@@ -1,7 +1,8 @@ 
 * Renesas R-Car PCIe interface
 
 Required properties:
-compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC;
+compatible: "renesas,pcie-r8a7742" for the R8A7742 SoC;
+	    "renesas,pcie-r8a7743" for the R8A7743 SoC;
 	    "renesas,pcie-r8a7779" for the R8A7779 SoC;
 	    "renesas,pcie-r8a7790" for the R8A7790 SoC;
 	    "renesas,pcie-r8a7791" for the R8A7791 SoC;