| Message ID | 20201124104100.491-1-thunder.leizhen@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 68878a5c5b852d17f5827ce8a0f6fbd8b4cdfada |
| Delegated to: | BPF |
| Headers | show |
| Series | [1/1] tools/bpftool: fix error return value in build_btf_type_table() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 11/24/20 2:41 AM, Zhen Lei wrote: > An appropriate return value should be set on the failed path. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> LGTM. Acked-by: Yonghong Song <yhs@fb.com> Also this is a bug fix. It should probably be targeted to bpf tree. So, Fixes: 4d374ba0bf30 ("tools: bpftool: implement "bpftool btf show|list"") > --- > tools/bpf/bpftool/btf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/bpf/bpftool/btf.c b/tools/bpf/bpftool/btf.c > index 8ab142ff5eac..2afb7d5b1aca 100644 > --- a/tools/bpf/bpftool/btf.c > +++ b/tools/bpf/bpftool/btf.c > @@ -693,6 +693,7 @@ build_btf_type_table(struct btf_attach_table *tab, enum bpf_obj_type type, > obj_node = calloc(1, sizeof(*obj_node)); > if (!obj_node) { > p_err("failed to allocate memory: %s", strerror(errno)); > + err = -ENOMEM; > goto err_free; > } > >
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Tue, 24 Nov 2020 18:41:00 +0800 you wrote: > An appropriate return value should be set on the failed path. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > --- > tools/bpf/bpftool/btf.c | 1 + > 1 file changed, 1 insertion(+) Here is the summary with links: - [1/1] tools/bpftool: fix error return value in build_btf_type_table() https://git.kernel.org/bpf/bpf/c/68878a5c5b85 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/tools/bpf/bpftool/btf.c b/tools/bpf/bpftool/btf.c index 8ab142ff5eac..2afb7d5b1aca 100644 --- a/tools/bpf/bpftool/btf.c +++ b/tools/bpf/bpftool/btf.c @@ -693,6 +693,7 @@ build_btf_type_table(struct btf_attach_table *tab, enum bpf_obj_type type, obj_node = calloc(1, sizeof(*obj_node)); if (!obj_node) { p_err("failed to allocate memory: %s", strerror(errno)); + err = -ENOMEM; goto err_free; }
An appropriate return value should be set on the failed path. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- tools/bpf/bpftool/btf.c | 1 + 1 file changed, 1 insertion(+)