[v2,0/4] grep: simplify "grep defaults" handling

Message

Martin Ågren Nov. 24, 2020, 9:04 p.m. UTC

This is v2 of my series [1] to simplify the setup and use of the `struct
grep_opt grep_defaults`. The only difference compared to v1 is in the
third patch which now drops more code in favor of copying the whole
struct in one go.

[1] https://lore.kernel.org/git/[e-mail]/

Martin Ågren (4):
  grep: don't set up a "default" repo for grep
  grep: use designated initializers for `grep_defaults`
  grep: copy struct in one fell swoop
  MyFirstObjectWalk: drop `init_walken_defaults()`

 Documentation/MyFirstObjectWalk.txt | 34 +----------
 grep.h                              |  1 -
 builtin/grep.c                      |  1 -
 builtin/log.c                       |  1 -
 grep.c                              | 90 +++++++++--------------------
 revision.c                          |  1 -
 6 files changed, 28 insertions(+), 100 deletions(-)

Comments

Ævar Arnfjörð Bjarmason Nov. 25, 2020, 9:27 a.m. UTC | #1

On Tue, Nov 24 2020, Martin Ågren wrote:

> This is v2 of my series [1] to simplify the setup and use of the `struct
> grep_opt grep_defaults`. The only difference compared to v1 is in the
> third patch which now drops more code in favor of copying the whole
> struct in one go.

It's good to see this change, I remembered having to juggle these values
a while back in:

    git log -p --author=Ævar --grep=memset -- grep.c

Thanks.