diff mbox series

drm/ingenic: Add basic PM support

Message ID 20201128171606.132830-1-paul@crapouillou.net (mailing list archive)
State New, archived
Headers show
Series drm/ingenic: Add basic PM support | expand

Commit Message

Paul Cercueil Nov. 28, 2020, 5:16 p.m. UTC 
Call drm_mode_config_helper_suspend() and
drm_mode_config_helper_resume() on suspend and resume, respectively.

This makes sure that the display stack is properly disabled when the
hardware is put to sleep.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

Comments

Paul Cercueil Nov. 28, 2020, 8:03 p.m. UTC | #1 
Le sam. 28 nov. 2020 à 19:58, Sam Ravnborg <sam@ravnborg.org> a écrit 
:
> Hi Paul.
> 
> On Sat, Nov 28, 2020 at 05:16:06PM +0000, Paul Cercueil wrote:
>>  Call drm_mode_config_helper_suspend() and
>>  drm_mode_config_helper_resume() on suspend and resume, respectively.
>> 
>>  This makes sure that the display stack is properly disabled when the
>>  hardware is put to sleep.
>> 
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> 
> As discussed on irc, with resume fixed to return the result of the
> drm_mode_config_helper_resume() call.
> 
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

Applied with the fix, thanks.

Cheers,
-Paul
diff mbox series

Patch

diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
index 368bfef8b340..818a0e4f5bfe 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
@@ -14,6 +14,7 @@ 
 #include <linux/of_device.h>
 #include <linux/of_reserved_mem.h>
 #include <linux/platform_device.h>
+#include <linux/pm.h>
 #include <linux/regmap.h>
 
 #include <drm/drm_atomic.h>
@@ -1167,6 +1168,24 @@  static int ingenic_drm_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static int __maybe_unused ingenic_drm_suspend(struct device *dev)
+{
+	struct ingenic_drm *priv = dev_get_drvdata(dev);
+
+	return drm_mode_config_helper_suspend(&priv->drm);
+}
+
+static int __maybe_unused ingenic_drm_resume(struct device *dev)
+{
+	struct ingenic_drm *priv = dev_get_drvdata(dev);
+
+	drm_mode_config_helper_resume(&priv->drm);
+
+	return 0;
+}
+
+static SIMPLE_DEV_PM_OPS(ingenic_drm_pm_ops, ingenic_drm_suspend, ingenic_drm_resume);
+
 static const u32 jz4740_formats[] = {
 	DRM_FORMAT_XRGB1555,
 	DRM_FORMAT_RGB565,
@@ -1246,6 +1265,7 @@  MODULE_DEVICE_TABLE(of, ingenic_drm_of_match);
 static struct platform_driver ingenic_drm_driver = {
 	.driver = {
 		.name = "ingenic-drm",
+		.pm = pm_ptr(&ingenic_drm_pm_ops),
 		.of_match_table = of_match_ptr(ingenic_drm_of_match),
 	},
 	.probe = ingenic_drm_probe,