diff mbox series

certs/blacklist: fix kernel doc interface issue

Message ID 1604673513-29088-1-git-send-email-alex.shi@linux.alibaba.com (mailing list archive)
State New
Headers show
Series certs/blacklist: fix kernel doc interface issue | expand

Commit Message

Alex Shi Nov. 6, 2020, 2:38 p.m. UTC
certs/blacklist.c:84: warning: Function parameter or member 'hash' not
described in 'mark_hash_blacklisted'

Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
Cc: David Howells <dhowells@redhat.com> 
Cc: David Woodhouse <dwmw2@infradead.org> 
Cc: keyrings@vger.kernel.org 
Cc: linux-kernel@vger.kernel.org 
---
 certs/blacklist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Howells Nov. 30, 2020, 10:04 a.m. UTC | #1
Alex Shi <alex.shi@linux.alibaba.com> wrote:

>  /**
>   * mark_hash_blacklisted - Add a hash to the system blacklist
> - * @hash - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")
> + * @hash: - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")

You should remove the dash when making this change.  I'll do that for you.

David
Alex Shi Nov. 30, 2020, 11:14 a.m. UTC | #2
在 2020/11/30 下午6:04, David Howells 写道:
> Alex Shi <alex.shi@linux.alibaba.com> wrote:
> 
>>  /**
>>   * mark_hash_blacklisted - Add a hash to the system blacklist
>> - * @hash - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")
>> + * @hash: - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")
> 
> You should remove the dash when making this change.  I'll do that for you.


Hi David,

Very appreciate for the fixing and reminder!

Regards
Alex
diff mbox series

Patch

diff --git a/certs/blacklist.c b/certs/blacklist.c
index 6514f9ebc943..02f1016ce6e8 100644
--- a/certs/blacklist.c
+++ b/certs/blacklist.c
@@ -78,7 +78,7 @@  static void blacklist_describe(const struct key *key, struct seq_file *m)
 
 /**
  * mark_hash_blacklisted - Add a hash to the system blacklist
- * @hash - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")
+ * @hash: - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")
  */
 int mark_hash_blacklisted(const char *hash)
 {