| Message ID | 1606837931-22676-1-git-send-email-tlfalcon@linux.ibm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ibmvnic: Bug fixes for queue descriptor processing | expand |
From: Thomas Falcon <tlfalcon@linux.ibm.com> Date: Tue, 1 Dec 2020 09:52:09 -0600 > This series resolves a few issues in the ibmvnic driver's > RX buffer and TX completion processing. The first patch > includes memory barriers to synchronize queue descriptor > reads. The second patch fixes a memory leak that could > occur if the device returns a TX completion with an error > code in the descriptor, in which case the respective socket > buffer and other relevant data structures may not be freed > or updated properly. > > v3: Correct length of Fixes tags, requested by Jakub Kicinski > > v2: Provide more detailed comments explaining specifically what > reads are being ordered, suggested by Michael Ellerman Series applied, thanks!
This series resolves a few issues in the ibmvnic driver's RX buffer and TX completion processing. The first patch includes memory barriers to synchronize queue descriptor reads. The second patch fixes a memory leak that could occur if the device returns a TX completion with an error code in the descriptor, in which case the respective socket buffer and other relevant data structures may not be freed or updated properly. v3: Correct length of Fixes tags, requested by Jakub Kicinski v2: Provide more detailed comments explaining specifically what reads are being ordered, suggested by Michael Ellerman Thomas Falcon (2): ibmvnic: Ensure that SCRQ entry reads are correctly ordered ibmvnic: Fix TX completion error handling drivers/net/ethernet/ibm/ibmvnic.c | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-)