| Message ID | 4e30fa82-fe24-1783-6f9a-13e1dd6f4ca9@web.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2fbd305e70934f064508ffc454d59351a7b132bc |
| Headers | show |
| Series | gitignore: remove entry for git serve | expand |
Hi René, On Wed, 2 Dec 2020, René Scharfe wrote: > b7ce24d095 (Turn `git serve` into a test helper, 2019-04-18) demoted git > serve from a builtin command to a test helper. As a result the > git-serve binary is no longer built and thus doesn't have to be ignored > anymore. > > Signed-off-by: René Scharfe <l.s.r@web.de> ACK! Dscho > --- > .gitignore | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/.gitignore b/.gitignore > index f85d02c854..28c079f227 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -148,7 +148,6 @@ > /git-rm > /git-send-email > /git-send-pack > -/git-serve > /git-sh-i18n > /git-sh-i18n--envsubst > /git-sh-setup > -- > 2.29.2 >
On Wed, Dec 02, 2020 at 12:46:01PM +0100, René Scharfe wrote: > b7ce24d095 (Turn `git serve` into a test helper, 2019-04-18) demoted git > serve from a builtin command to a test helper. As a result the > git-serve binary is no longer built and thus doesn't have to be ignored > anymore. Good catch. This shows a weakness in my detection script: I had a stale git-serve sitting around from building old versions of Git. :) I repeated the script in a "clean" directory that was a fresh clone + make, and diffed the results. git-serve was the only interesting difference I saw. So this is probably the last of the low-hanging fruit. -Peff
Jeff King <peff@peff.net> writes: > On Wed, Dec 02, 2020 at 12:46:01PM +0100, René Scharfe wrote: > >> b7ce24d095 (Turn `git serve` into a test helper, 2019-04-18) demoted git >> serve from a builtin command to a test helper. As a result the >> git-serve binary is no longer built and thus doesn't have to be ignored >> anymore. > > Good catch. This shows a weakness in my detection script: I had a stale > git-serve sitting around from building old versions of Git. :) > > I repeated the script in a "clean" directory that was a fresh clone + > make, and diffed the results. git-serve was the only interesting > difference I saw. So this is probably the last of the low-hanging fruit. Thanks, all. Just for simplicity, these two are also queued on the same "random cleanup" topic branch started with Felipe's four trivial clean-up patches.
diff --git a/.gitignore b/.gitignore index f85d02c854..28c079f227 100644 --- a/.gitignore +++ b/.gitignore @@ -148,7 +148,6 @@ /git-rm /git-send-email /git-send-pack -/git-serve /git-sh-i18n /git-sh-i18n--envsubst /git-sh-setup
b7ce24d095 (Turn `git serve` into a test helper, 2019-04-18) demoted git serve from a builtin command to a test helper. As a result the git-serve binary is no longer built and thus doesn't have to be ignored anymore. Signed-off-by: René Scharfe <l.s.r@web.de> --- .gitignore | 1 - 1 file changed, 1 deletion(-) -- 2.29.2