| Message ID | 20201201224208.73295-1-saeedm@nvidia.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
On Tue, 1 Dec 2020 14:41:53 -0800 Saeed Mahameed wrote: > Please note that the series starts with a merge of mlx5-next branch, > to resolve and avoid dependency with rdma tree. Why is that not a separate posting prior to this one? The patches as posted on the ML fail to build.
On Wed, 2020-12-02 at 10:48 -0800, Jakub Kicinski wrote: > On Tue, 1 Dec 2020 14:41:53 -0800 Saeed Mahameed wrote: > > Please note that the series starts with a merge of mlx5-next > > branch, > > to resolve and avoid dependency with rdma tree. > > Why is that not a separate posting prior to this one? you mean this ? https://patchwork.kernel.org/project/linux-rdma/cover/20201120230339.651609-1-saeedm@nvidia.com/ it was posted and we discussed it. > > The patches as posted on the ML fail to build. Well, you need to pull the whole thing :/ .. this is how i used to work with Dave on the mlx5-next branch.
On Wed, 02 Dec 2020 11:17:16 -0800 Saeed Mahameed wrote: > On Wed, 2020-12-02 at 10:48 -0800, Jakub Kicinski wrote: > > On Tue, 1 Dec 2020 14:41:53 -0800 Saeed Mahameed wrote: > > > Please note that the series starts with a merge of mlx5-next > > > branch, > > > to resolve and avoid dependency with rdma tree. > > > > Why is that not a separate posting prior to this one? > > you mean this ? > https://patchwork.kernel.org/project/linux-rdma/cover/20201120230339.651609-1-saeedm@nvidia.com/ > > it was posted and we discussed it. Yeah but that's not a pull request, I can't pull that. > > The patches as posted on the ML fail to build. > > Well, you need to pull the whole thing :/ .. > this is how i used to work with Dave on the mlx5-next branch. To be clear - I'm asking you to send a PR for the pre-reqs and then send the ethernet patches. So that the pre-reqs are in the tree already by the time the ethernet patches hit the ML. I thought that's what you did in the past, but either way it'd make my life easier.
On Wed, 2020-12-02 at 11:20 -0800, Jakub Kicinski wrote: > On Wed, 02 Dec 2020 11:17:16 -0800 Saeed Mahameed wrote: > > On Wed, 2020-12-02 at 10:48 -0800, Jakub Kicinski wrote: > > > On Tue, 1 Dec 2020 14:41:53 -0800 Saeed Mahameed wrote: > > > > Please note that the series starts with a merge of mlx5-next > > > > branch, > > > > to resolve and avoid dependency with rdma tree. > > > > > > Why is that not a separate posting prior to this one? > > > > you mean this ? > > https://patchwork.kernel.org/project/linux-rdma/cover/20201120230339.651609-1-saeedm@nvidia.com/ > > > > it was posted and we discussed it. > > Yeah but that's not a pull request, I can't pull that. > > > > The patches as posted on the ML fail to build. > > > > Well, you need to pull the whole thing :/ .. > > this is how i used to work with Dave on the mlx5-next branch. > > To be clear - I'm asking you to send a PR for the pre-reqs and then > send the ethernet patches. So that the pre-reqs are in the tree > already > by the time the ethernet patches hit the ML. I thought that's what > you > did in the past, but either way it'd make my life easier. Ok, Done, will submit two separate pull requests. But to avoid any wait and to create full visibility, is there a way to let the CI bot understand dependency between two separate pull requests ? or the base-commit of a pull request ? I would like to send everything in one shot for full visibility. Thanks, Saeed.
On Wed, 02 Dec 2020 12:15:15 -0800 Saeed Mahameed wrote: > On Wed, 2020-12-02 at 11:20 -0800, Jakub Kicinski wrote: > > To be clear - I'm asking you to send a PR for the pre-reqs and then > > send the ethernet patches. So that the pre-reqs are in the tree > > already > > by the time the ethernet patches hit the ML. I thought that's what > > you > > did in the past, but either way it'd make my life easier. > > Ok, Done, will submit two separate pull requests. > > But to avoid any wait and to create full visibility, is there a way to > let the CI bot understand dependency between two separate pull requests > ? or the base-commit of a pull request ? Possibly it's just a python script (available on GH). Although we don't allow people to queue up multiple series which are co-dependent, I'm not sure if using PRs changes that much. There still needs to be a reasonable rate control on number of patches for example. > I would like to send everything in one shot for full visibility. Hm, not sure what you mean by visibility.
Hi Jakub, This series adds port tx timestamping support and some misc updates. For more information please see tag log below. Please pull and let me know if there is any problem. Please note that the series starts with a merge of mlx5-next branch, to resolve and avoid dependency with rdma tree. Thanks, Saeed. --- The following changes since commit e4518eed11ce8166d038d187a0234aa5dac4bdf4: Merge branch 'mlx5-next' of git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux (2020-12-01 14:25:07 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git tags/mlx5-updates-2020-12-01 for you to fetch changes up to 6bf811819936059562d46f18bf9f908ccb0e4624: net/mlx5e: Fill mlx5e_create_cq_param in a function (2020-12-01 14:25:16 -0800) ---------------------------------------------------------------- mlx5-updates-2020-12-01 mlx5e port TX timestamping support and MISC updates 1) Add support for port TX timestamping, for better PTP accuracy. Currently in mlx5 HW TX timestamping is done on CQE (TX completion) generation, which much earlier than when the packet actually goes out to the wire, in this series Eran implements the option to do timestamping on the port using a special SQ (Send Queue), such Send Queue will generate 2 CQEs (TX completions), the original one and a new one when the packet leaves the port, due to the nature of this special handling, such mechanism is an opt-in only and it is off by default to avoid any performance degradation on normal traffic flows. 2) Misc updates and trivial improvements. ---------------------------------------------------------------- Aya Levin (3): net/mlx5e: Allow CQ outside of channel context net/mlx5e: Allow RQ outside of channel context net/mlx5e: Split between RX/TX tunnel FW support indication Eran Ben Elisha (6): net/mlx5e: Allow SQ outside of channel context net/mlx5e: Change skb fifo push/pop API to be used without SQ net/mlx5e: Split SW group counters update function net/mlx5e: Move MLX5E_RX_ERR_CQE macro net/mlx5e: Add TX PTP port object support net/mlx5e: Add TX port timestamp support Maxim Mikityanskiy (1): net/mlx5e: Fill mlx5e_create_cq_param in a function Shay Drory (1): net/mlx5: Arm only EQs with EQEs Tariq Toukan (1): net/mlx5e: Free drop RQ in a dedicated function YueHaibing (2): net/mlx5e: Remove duplicated include net/mlx5: Fix passing zero to 'PTR_ERR' Zhu Yanjun (1): net/mlx5e: remove unnecessary memset drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en.h | 63 ++- drivers/net/ethernet/mellanox/mlx5/core/en/fs.h | 3 +- .../net/ethernet/mellanox/mlx5/core/en/health.c | 16 +- .../net/ethernet/mellanox/mlx5/core/en/health.h | 7 +- .../net/ethernet/mellanox/mlx5/core/en/params.h | 10 + drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c | 529 +++++++++++++++++++++ drivers/net/ethernet/mellanox/mlx5/core/en/ptp.h | 63 +++ .../ethernet/mellanox/mlx5/core/en/reporter_rx.c | 52 +- .../ethernet/mellanox/mlx5/core/en/reporter_tx.c | 215 +++++++-- drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h | 19 +- .../net/ethernet/mellanox/mlx5/core/en/xsk/setup.c | 9 +- .../mellanox/mlx5/core/en_accel/tls_rxtx.c | 2 +- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 33 ++ drivers/net/ethernet/mellanox/mlx5/core/en_fs.c | 20 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 252 ++++++---- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 29 +- drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 403 +++++++++++----- drivers/net/ethernet/mellanox/mlx5/core/en_stats.h | 11 + drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 77 ++- drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c | 5 +- drivers/net/ethernet/mellanox/mlx5/core/eq.c | 6 +- .../mellanox/mlx5/core/esw/acl/egress_lgcy.c | 2 +- .../mellanox/mlx5/core/esw/acl/egress_ofld.c | 2 +- .../mellanox/mlx5/core/esw/acl/ingress_lgcy.c | 2 +- .../mellanox/mlx5/core/esw/acl/ingress_ofld.c | 2 +- .../ethernet/mellanox/mlx5/core/eswitch_offloads.c | 1 - 27 files changed, 1485 insertions(+), 350 deletions(-) create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en/ptp.h