| Message ID | c1d61ab4-7626-7c97-7363-73dbc5fa3629@163.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | mptcp: print new line in mptcp_seq_show() if mptcp isn't in use | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 1 this patch: 1 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | warning | WARNING: Missing commit description - Add an appropriate one |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 1 this patch: 1 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
Jianguo Wu <wujianguo106@163.com> wrote: > From: Jianguo Wu <wujianguo@chinatelecom.cn> A brief explanation would have helped. This is for net tree. > Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn> Fixes: fc518953bc9c8d7d ("mptcp: add and use MIB counter infrastructure") Acked-by: Florian Westphal <fw@strlen.de>
On Fri, 4 Dec 2020 16:21:19 +0100 Florian Westphal wrote: > Jianguo Wu <wujianguo106@163.com> wrote: > > From: Jianguo Wu <wujianguo@chinatelecom.cn> > > A brief explanation would have helped. Yes, please post a v2 with a sentence describing the problem and output before and after the change. > This is for net tree. By which we mean please tag v2 as [PATCH net v2] in the subject. > > Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn> > > Fixes: fc518953bc9c8d7d ("mptcp: add and use MIB counter infrastructure") > Acked-by: Florian Westphal <fw@strlen.de> And please make sure to add these to your patch before posting so Florian doesn't have to resend them.
OK,I will post v2 soon, thanks! 在 2020/12/5 0:59, Jakub Kicinski 写道: > On Fri, 4 Dec 2020 16:21:19 +0100 Florian Westphal wrote: >> Jianguo Wu <wujianguo106@163.com> wrote: >>> From: Jianguo Wu <wujianguo@chinatelecom.cn> >> >> A brief explanation would have helped. > > Yes, please post a v2 with a sentence describing the problem and output > before and after the change. > >> This is for net tree. > > By which we mean please tag v2 as [PATCH net v2] in the subject. > >>> Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn> >> >> Fixes: fc518953bc9c8d7d ("mptcp: add and use MIB counter infrastructure") >> Acked-by: Florian Westphal <fw@strlen.de> > > And please make sure to add these to your patch before posting so > Florian doesn't have to resend them. >
diff --git a/net/mptcp/mib.c b/net/mptcp/mib.c index 84d1194..b921cbd 100644 --- a/net/mptcp/mib.c +++ b/net/mptcp/mib.c @@ -67,6 +67,7 @@ void mptcp_seq_show(struct seq_file *seq) for (i = 0; mptcp_snmp_list[i].name; i++) seq_puts(seq, " 0"); + seq_putc(seq, '\n'); return; }