| Message ID | X8qEg/KiAQDugPC0@coredump.intra.peff.net (mailing list archive) |
|---|---|
| Headers | show |
| Series | misc commit-graph and oid-array cleanups | expand |
On Fri, Dec 04, 2020 at 01:48:35PM -0500, Jeff King wrote: > This series came out of an off-list discussion about using oid-array in > commit-graph.c to replace a similar data structure. But I found a couple > of things to clean up along the way. Thanks, I appreciate you taking this up. Everything that you wrote looks very reasonable to me; I noted a couple of spots that might be worth changing, but I won't be sad if you ignore them. Reviewed-by: Taylor Blau <me@ttaylorr.com> Thanks, Taylor
On 12/4/2020 2:15 PM, Taylor Blau wrote: > On Fri, Dec 04, 2020 at 01:48:35PM -0500, Jeff King wrote: >> This series came out of an off-list discussion about using oid-array in >> commit-graph.c to replace a similar data structure. But I found a couple >> of things to clean up along the way. > > Thanks, I appreciate you taking this up. Everything that you wrote looks > very reasonable to me; I noted a couple of spots that might be worth > changing, but I won't be sad if you ignore them. > > Reviewed-by: Taylor Blau <me@ttaylorr.com> I have similar thoughts. Only one spot was worthy of a comment, and it has a very low chance of being important. Thanks, -Stolee
This series came out of an off-list discussion about using oid-array in commit-graph.c to replace a similar data structure. But I found a couple of things to clean up along the way. Surprisingly, this doesn't conflict with Stolee's "chunk-format API" series from yesterday. Nor any of the other commit-graph work in "seen". [1/9]: oid-array.h: drop sha1 mention from header guard [2/9]: t0064: drop sha1 mention from filename [3/9]: t0064: make duplicate tests more robust [4/9]: cache.h: move hash/oid functions to hash.h [5/9]: oid-array: make sort function public [6/9]: oid-array: provide a for-loop iterator [7/9]: commit-graph: drop count_distinct_commits() function [8/9]: commit-graph: replace packed_oid_list with oid_array [9/9]: commit-graph: use size_t for array allocation and indexing cache.h | 94 --------------- commit-graph.c | 107 +++--------------- hash.h | 95 ++++++++++++++++ oid-array.c | 17 ++- oid-array.h | 33 +++++- t/{t0064-sha1-array.sh => t0064-oid-array.sh} | 9 +- 6 files changed, 156 insertions(+), 199 deletions(-) rename t/{t0064-sha1-array.sh => t0064-oid-array.sh} (90%) -Peff