| Message ID | 20201202124959.29209-1-info@metux.net (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [1/7] net: 8021q: remove unneeded MODULE_VERSION() usage | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | warning | Series does not have a cover letter |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | fail | Errors and warnings before: 0 this patch: 5 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 26 lines checked |
| netdev/build_allmodconfig_warn | fail | Errors and warnings before: 0 this patch: 5 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Wed, 2 Dec 2020 13:49:53 +0100 Enrico Weigelt, metux IT consult wrote: > Remove MODULE_VERSION(), as it isn't needed at all: the only version > making sense is the kernel version. > > Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> Thanks for the patches. Please drop the "metux IT consult" from the addresses. The from space is supposed to be for your name. > diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c > index f292e0267bb9..683e9e825b9e 100644 > --- a/net/8021q/vlan.c > +++ b/net/8021q/vlan.c > @@ -36,15 +36,10 @@ > #include "vlan.h" > #include "vlanproc.h" > > -#define DRV_VERSION "1.8" > - > /* Global VLAN variables */ > > unsigned int vlan_net_id __read_mostly; > > -const char vlan_fullname[] = "802.1Q VLAN Support"; > -const char vlan_version[] = DRV_VERSION; This patches does not build. Please redo it more carefully. You'll need to fix and resend the entire series. When you do so please provide a cover letter, even if it only contains a couple of sentences and separate the patches for bluetooth and batman-adv out as stand alone patches, so the respective maintainers can pick them up.
On Fri, 2020-12-04 at 16:09 -0800, Jakub Kicinski wrote: > On Wed, 2 Dec 2020 13:49:53 +0100 Enrico Weigelt, metux IT consult > wrote: > > Remove MODULE_VERSION(), as it isn't needed at all: the only version > > making sense is the kernel version. > > > > Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> > > Thanks for the patches. Please drop the "metux IT consult" from the > addresses. The from space is supposed to be for your name. If you _really_ want this superfluous 'metux IT consult' content in your signature, and I don't think you should, use parentheses around it. Enrico Weigelt (metux IT consult) <info@metux.net> Using a comma makes copy/paste into an email client think it's two addresses.
On Wed, Dec 02, 2020 at 01:49:53PM +0100, Enrico Weigelt, metux IT consult wrote: > Remove MODULE_VERSION(), as it isn't needed at all: the only version > making sense is the kernel version. > > Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> > --- > net/8021q/vlan.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c > index f292e0267bb9..683e9e825b9e 100644 > --- a/net/8021q/vlan.c > +++ b/net/8021q/vlan.c > @@ -36,15 +36,10 @@ > #include "vlan.h" > #include "vlanproc.h" > > -#define DRV_VERSION "1.8" > - > /* Global VLAN variables */ > > unsigned int vlan_net_id __read_mostly; > > -const char vlan_fullname[] = "802.1Q VLAN Support"; > -const char vlan_version[] = DRV_VERSION; > - > /* End of global variables definitions. */ > > static int vlan_group_prealloc_vid(struct vlan_group *vg, > @@ -687,7 +682,7 @@ static int __init vlan_proto_init(void) > { > int err; > > - pr_info("%s v%s\n", vlan_fullname, vlan_version); > + pr_info("802.1Q VLAN Support\n"); How do we feel about deleting this not really informative message altogether in a future patch?
On Sat, Dec 05, 2020 at 01:20:18PM +0200, Vladimir Oltean wrote: > On Wed, Dec 02, 2020 at 01:49:53PM +0100, Enrico Weigelt, metux IT consult wrote: > > Remove MODULE_VERSION(), as it isn't needed at all: the only version > > making sense is the kernel version. > > > > Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> > > --- > > net/8021q/vlan.c | 8 +------- > > 1 file changed, 1 insertion(+), 7 deletions(-) > > > > diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c > > index f292e0267bb9..683e9e825b9e 100644 > > --- a/net/8021q/vlan.c > > +++ b/net/8021q/vlan.c > > @@ -36,15 +36,10 @@ > > #include "vlan.h" > > #include "vlanproc.h" > > > > -#define DRV_VERSION "1.8" > > - > > /* Global VLAN variables */ > > > > unsigned int vlan_net_id __read_mostly; > > > > -const char vlan_fullname[] = "802.1Q VLAN Support"; > > -const char vlan_version[] = DRV_VERSION; > > - > > /* End of global variables definitions. */ > > > > static int vlan_group_prealloc_vid(struct vlan_group *vg, > > @@ -687,7 +682,7 @@ static int __init vlan_proto_init(void) > > { > > int err; > > > > - pr_info("%s v%s\n", vlan_fullname, vlan_version); > > + pr_info("802.1Q VLAN Support\n"); > > How do we feel about deleting this not really informative message > altogether in a future patch? It too should be removed. If drivers are working properly, they are quiet.
On 05.12.20 16:53, Greg KH wrote: >> How do we feel about deleting this not really informative message >> altogether in a future patch? > > It too should be removed. If drivers are working properly, they are > quiet. Just sent a separate patch for removing this message. I'll rebase my patch queue when this patch went through. --mtx
diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index f292e0267bb9..683e9e825b9e 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -36,15 +36,10 @@ #include "vlan.h" #include "vlanproc.h" -#define DRV_VERSION "1.8" - /* Global VLAN variables */ unsigned int vlan_net_id __read_mostly; -const char vlan_fullname[] = "802.1Q VLAN Support"; -const char vlan_version[] = DRV_VERSION; - /* End of global variables definitions. */ static int vlan_group_prealloc_vid(struct vlan_group *vg, @@ -687,7 +682,7 @@ static int __init vlan_proto_init(void) { int err; - pr_info("%s v%s\n", vlan_fullname, vlan_version); + pr_info("802.1Q VLAN Support\n"); err = register_pernet_subsys(&vlan_net_ops); if (err < 0) @@ -743,4 +738,3 @@ module_init(vlan_proto_init); module_exit(vlan_cleanup_module); MODULE_LICENSE("GPL"); -MODULE_VERSION(DRV_VERSION);
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> --- net/8021q/vlan.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)