[v3,for-next,0/3] btrfs async discard fixes & improvements

Message

Pavel Begunkov Dec. 6, 2020, 3:56 p.m. UTC

Fix async discard stalls with the first patch, and address other minor
things.

v2: fix async discard stalls, see patch [1/3]
v3: if now == bg->discard_eligible_time it fails to init discard state,
    and index. Always init it if peek return !=NULL bg, it's more
    resilient.

Pavel Begunkov (3):
  btrfs: fix async discard stall
  btrfs: fix racy access to discard_ctl data
  btrfs: don't overabuse discard lock

 fs/btrfs/discard.c | 70 ++++++++++++++++++++++++----------------------
 1 file changed, 36 insertions(+), 34 deletions(-)

Comments

David Sterba Dec. 14, 2020, 5:37 p.m. UTC | #1

On Sun, Dec 06, 2020 at 03:56:19PM +0000, Pavel Begunkov wrote:
> Fix async discard stalls with the first patch, and address other minor
> things.
> 
> v2: fix async discard stalls, see patch [1/3]
> v3: if now == bg->discard_eligible_time it fails to init discard state,
>     and index. Always init it if peek return !=NULL bg, it's more
>     resilient.
> 
> Pavel Begunkov (3):
>   btrfs: fix async discard stall
>   btrfs: fix racy access to discard_ctl data
>   btrfs: don't overabuse discard lock

Thanks.  I'll add the patchset to for-next and will send it with some
post rc1 pull request.