| Message ID | 20201212122818.86195-1-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | clk: s2mps11: Fix a resource leak in error handling paths in the probe function | expand |
On Sat, Dec 12, 2020 at 01:28:18PM +0100, Christophe JAILLET wrote: > Some resource should be released in the error handling path of the probe > function, as already done in the remove function. > > The remove function was fixed in commit bf416bd45738 ("clk: s2mps11: Add > missing of_node_put and of_clk_del_provider") > > Fixes: 7cc560dea415 ("clk: s2mps11: Add support for s2mps11") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/clk/clk-s2mps11.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
Quoting Christophe JAILLET (2020-12-12 04:28:18) > Some resource should be released in the error handling path of the probe > function, as already done in the remove function. > > The remove function was fixed in commit bf416bd45738 ("clk: s2mps11: Add > missing of_node_put and of_clk_del_provider") > > Fixes: 7cc560dea415 ("clk: s2mps11: Add support for s2mps11") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- Applied to clk-next
diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c index aa21371f9104..a3e883a9f406 100644 --- a/drivers/clk/clk-s2mps11.c +++ b/drivers/clk/clk-s2mps11.c @@ -195,6 +195,7 @@ static int s2mps11_clk_probe(struct platform_device *pdev) return ret; err_reg: + of_node_put(s2mps11_clks[0].clk_np); while (--i >= 0) clkdev_drop(s2mps11_clks[i].lookup);
Some resource should be released in the error handling path of the probe function, as already done in the remove function. The remove function was fixed in commit bf416bd45738 ("clk: s2mps11: Add missing of_node_put and of_clk_del_provider") Fixes: 7cc560dea415 ("clk: s2mps11: Add support for s2mps11") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/clk/clk-s2mps11.c | 1 + 1 file changed, 1 insertion(+)