| Message ID | 20201215193755.26160-4-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] drm: arc: Remove unnecessary drm_plane_cleanup() wrapper | expand |
On Tue, Dec 15, 2020 at 09:37:55PM +0200, Laurent Pinchart wrote: > Use the drm_plane_cleanup() function directly as the drm_plane_funcs > .destroy() handler without creating an unnecessary wrapper around it. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> On the series: Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> I'm assuming you'll apply this somewhere. -Daniel > --- > drivers/gpu/drm/zte/zx_plane.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/zte/zx_plane.c b/drivers/gpu/drm/zte/zx_plane.c > index c8f7b21fa09e..78d787afe594 100644 > --- a/drivers/gpu/drm/zte/zx_plane.c > +++ b/drivers/gpu/drm/zte/zx_plane.c > @@ -438,15 +438,10 @@ static const struct drm_plane_helper_funcs zx_gl_plane_helper_funcs = { > .atomic_disable = zx_plane_atomic_disable, > }; > > -static void zx_plane_destroy(struct drm_plane *plane) > -{ > - drm_plane_cleanup(plane); > -} > - > static const struct drm_plane_funcs zx_plane_funcs = { > .update_plane = drm_atomic_helper_update_plane, > .disable_plane = drm_atomic_helper_disable_plane, > - .destroy = zx_plane_destroy, > + .destroy = drm_plane_cleanup, > .reset = drm_atomic_helper_plane_reset, > .atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state, > .atomic_destroy_state = drm_atomic_helper_plane_destroy_state, > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Daniel, On Wed, Dec 16, 2020 at 03:22:59PM +0100, Daniel Vetter wrote: > On Tue, Dec 15, 2020 at 09:37:55PM +0200, Laurent Pinchart wrote: > > Use the drm_plane_cleanup() function directly as the drm_plane_funcs > > .destroy() handler without creating an unnecessary wrapper around it. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > On the series: > > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > I'm assuming you'll apply this somewhere. Yes, with the rest of my pending patches for v5.12 (I'm currently going through my stale branches, cleaning up the bitrot and resubmitting as appropriate), but if you want to push to drm-misc early, I won't mind :-) > > --- > > drivers/gpu/drm/zte/zx_plane.c | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/zte/zx_plane.c b/drivers/gpu/drm/zte/zx_plane.c > > index c8f7b21fa09e..78d787afe594 100644 > > --- a/drivers/gpu/drm/zte/zx_plane.c > > +++ b/drivers/gpu/drm/zte/zx_plane.c > > @@ -438,15 +438,10 @@ static const struct drm_plane_helper_funcs zx_gl_plane_helper_funcs = { > > .atomic_disable = zx_plane_atomic_disable, > > }; > > > > -static void zx_plane_destroy(struct drm_plane *plane) > > -{ > > - drm_plane_cleanup(plane); > > -} > > - > > static const struct drm_plane_funcs zx_plane_funcs = { > > .update_plane = drm_atomic_helper_update_plane, > > .disable_plane = drm_atomic_helper_disable_plane, > > - .destroy = zx_plane_destroy, > > + .destroy = drm_plane_cleanup, > > .reset = drm_atomic_helper_plane_reset, > > .atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state, > > .atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
diff --git a/drivers/gpu/drm/zte/zx_plane.c b/drivers/gpu/drm/zte/zx_plane.c index c8f7b21fa09e..78d787afe594 100644 --- a/drivers/gpu/drm/zte/zx_plane.c +++ b/drivers/gpu/drm/zte/zx_plane.c @@ -438,15 +438,10 @@ static const struct drm_plane_helper_funcs zx_gl_plane_helper_funcs = { .atomic_disable = zx_plane_atomic_disable, }; -static void zx_plane_destroy(struct drm_plane *plane) -{ - drm_plane_cleanup(plane); -} - static const struct drm_plane_funcs zx_plane_funcs = { .update_plane = drm_atomic_helper_update_plane, .disable_plane = drm_atomic_helper_disable_plane, - .destroy = zx_plane_destroy, + .destroy = drm_plane_cleanup, .reset = drm_atomic_helper_plane_reset, .atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state, .atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
Use the drm_plane_cleanup() function directly as the drm_plane_funcs .destroy() handler without creating an unnecessary wrapper around it. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- drivers/gpu/drm/zte/zx_plane.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)