| Message ID | 20201209120643.14427-1-u.oelmann@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [nfs-utils] nfsd: clean up option parsing | expand |
Gentle ping! (And putting Jeff & Steve on CC). On Wed, Dec 09 2020 at 13:06 +0100, Ulrich Ölmann <u.oelmann@pengutronix.de> wrote: > Presumably by mistake in commit [1] the unknown option 'i' slipped in together > with a duplicated 't', so remove them from the optstring. > > [1] fbd7623dd8d5 ("nfsd: don't enable a UDP socket by default") > > Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de> > --- > utils/nfsd/nfsd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/utils/nfsd/nfsd.c b/utils/nfsd/nfsd.c > index a412a026c6c5..c9f0385b5a00 100644 > --- a/utils/nfsd/nfsd.c > +++ b/utils/nfsd/nfsd.c > @@ -162,7 +162,7 @@ main(int argc, char **argv) > } > } > > - while ((c = getopt_long(argc, argv, "dH:hN:V:p:P:stTituUrG:L:", longopts, NULL)) != EOF) { > + while ((c = getopt_long(argc, argv, "dH:hN:V:p:P:stTuUrG:L:", longopts, NULL)) != EOF) { > switch(c) { > case 'd': > xlog_config(D_ALL, 1);
On 12/16/20 9:28 AM, Ulrich Ölmann wrote: > Gentle ping! > (And putting Jeff & Steve on CC). Sorry for the delay... Trying to burn some PTO before EOY... > > On Wed, Dec 09 2020 at 13:06 +0100, Ulrich Ölmann <u.oelmann@pengutronix.de> wrote: >> Presumably by mistake in commit [1] the unknown option 'i' slipped in together >> with a duplicated 't', so remove them from the optstring. >> >> [1] fbd7623dd8d5 ("nfsd: don't enable a UDP socket by default") >> >> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de> Committed! steved. >> --- >> utils/nfsd/nfsd.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/utils/nfsd/nfsd.c b/utils/nfsd/nfsd.c >> index a412a026c6c5..c9f0385b5a00 100644 >> --- a/utils/nfsd/nfsd.c >> +++ b/utils/nfsd/nfsd.c >> @@ -162,7 +162,7 @@ main(int argc, char **argv) >> } >> } >> >> - while ((c = getopt_long(argc, argv, "dH:hN:V:p:P:stTituUrG:L:", longopts, NULL)) != EOF) { >> + while ((c = getopt_long(argc, argv, "dH:hN:V:p:P:stTuUrG:L:", longopts, NULL)) != EOF) { >> switch(c) { >> case 'd': >> xlog_config(D_ALL, 1);
diff --git a/utils/nfsd/nfsd.c b/utils/nfsd/nfsd.c index a412a026c6c5..c9f0385b5a00 100644 --- a/utils/nfsd/nfsd.c +++ b/utils/nfsd/nfsd.c @@ -162,7 +162,7 @@ main(int argc, char **argv) } } - while ((c = getopt_long(argc, argv, "dH:hN:V:p:P:stTituUrG:L:", longopts, NULL)) != EOF) { + while ((c = getopt_long(argc, argv, "dH:hN:V:p:P:stTuUrG:L:", longopts, NULL)) != EOF) { switch(c) { case 'd': xlog_config(D_ALL, 1);
Presumably by mistake in commit [1] the unknown option 'i' slipped in together with a duplicated 't', so remove them from the optstring. [1] fbd7623dd8d5 ("nfsd: don't enable a UDP socket by default") Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de> --- utils/nfsd/nfsd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)