| Message ID | 20201218083726.16427-1-alice.guo@oss.nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v8,1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID | expand |
On Fri, Dec 18, 2020 at 04:37:23PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo <alice.guo@nxp.com> > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > Signed-off-by: Alice Guo <alice.guo@nxp.com> > --- > > Changes for v8: > - match soc node with regular expression > Changes for v7: > - change to a separate schema file > Changes for v6: > - none > Changes for v5: > - correct the error of using allOf > Changes for v4: > - use allOf to limit new version DTS files for i.MX8M to include > "fsl,imx8m*-soc", nvmem-cells and nvmem-cells-names > Changes for v3: > - put it into Documentation/devicetree/bindings/arm/fsl.yaml > - modify the description of nvmem-cells > - use "make ARCH=arm64 dtbs_check" to make sure it is right > Changes for v2: > - remove the subject prefix "LF-2571-1" > > .../bindings/soc/imx/imx8m-soc.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > > diff --git a/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml b/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > new file mode 100644 > index 000000000000..f0b0fc7b3ac6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/imx/imx8m-soc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX8M Series SoC > + > +maintainers: > + - Alice Guo <alice.guo@nxp.com> > + > +description: | > + NXP i.MX8M series SoCs contain fuse entries from which SoC Unique ID can be > + obtained. > + > +select: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx8mm > + - fsl,imx8mn > + - fsl,imx8mp > + - fsl,imx8mq > + required: > + - compatible > + > +patternProperties: > + "^soc@[0-9a-f]+$": Thanks, now it works. > + type: object > + properties: > + compatible: > + items: > + - enum: > + - fsl,imx8mm-soc > + - fsl,imx8mn-soc > + - fsl,imx8mp-soc > + - fsl,imx8mq-soc > + - const: simple-bus > + > + nvmem-cells: > + maxItems: 1 > + description: Phandle to the SOC Unique ID provided by a nvmem node > + > + nvmem-cells-names: > + const: soc_unique_id > + > + required: > + - compatible > + - nvmem-cells > + - nvmem-cell-names > + > +additionalProperties: true Don't leave comments unresolved (or resolve them against review without discussion). Rob asked for changing it. The same as with all schemas - you need to describe the missing properties. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 2020年12月18日 16:52 > To: Alice Guo (OSS) <alice.guo@oss.nxp.com> > Cc: robh+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de; > kernel@pengutronix.de; festevam@gmail.com; devicetree@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; dl-linux-imx > <linux-imx@nxp.com> > Subject: Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc > unique ID > > On Fri, Dec 18, 2020 at 04:37:23PM +0800, Alice Guo (OSS) wrote: > > From: Alice Guo <alice.guo@nxp.com> > > > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > > > Signed-off-by: Alice Guo <alice.guo@nxp.com> > > --- > > > > Changes for v8: > > - match soc node with regular expression Changes for v7: > > - change to a separate schema file > > Changes for v6: > > - none > > Changes for v5: > > - correct the error of using allOf > > Changes for v4: > > - use allOf to limit new version DTS files for i.MX8M to include > > "fsl,imx8m*-soc", nvmem-cells and nvmem-cells-names Changes for v3: > > - put it into Documentation/devicetree/bindings/arm/fsl.yaml > > - modify the description of nvmem-cells > > - use "make ARCH=arm64 dtbs_check" to make sure it is right Changes > > for v2: > > - remove the subject prefix "LF-2571-1" > > > > .../bindings/soc/imx/imx8m-soc.yaml | 54 > +++++++++++++++++++ > > 1 file changed, 54 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > > > > diff --git a/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > > b/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > > new file mode 100644 > > index 000000000000..f0b0fc7b3ac6 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > > @@ -0,0 +1,54 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/imx/imx8m-soc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: NXP i.MX8M Series SoC > > + > > +maintainers: > > + - Alice Guo <alice.guo@nxp.com> > > + > > +description: | > > + NXP i.MX8M series SoCs contain fuse entries from which SoC Unique > > +ID can be > > + obtained. > > + > > +select: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - fsl,imx8mm > > + - fsl,imx8mn > > + - fsl,imx8mp > > + - fsl,imx8mq > > + required: > > + - compatible > > + > > +patternProperties: > > + "^soc@[0-9a-f]+$": > > Thanks, now it works. > > > + type: object > > + properties: > > + compatible: > > + items: > > + - enum: > > + - fsl,imx8mm-soc > > + - fsl,imx8mn-soc > > + - fsl,imx8mp-soc > > + - fsl,imx8mq-soc > > + - const: simple-bus > > + > > + nvmem-cells: > > + maxItems: 1 > > + description: Phandle to the SOC Unique ID provided by a nvmem > > + node > > + > > + nvmem-cells-names: > > + const: soc_unique_id > > + > > + required: > > + - compatible > > + - nvmem-cells > > + - nvmem-cell-names > > + > > +additionalProperties: true > > Don't leave comments unresolved (or resolve them against review without > discussion). Rob asked for changing it. The same as with all schemas - you need > to describe the missing properties. > > Best regards, > Krzysztof Hi, Thank you for your advice. I replied to him and let him know I remained here unchanged. There will be errors according to his suggestion. Best regards, Alice
On Fri, Dec 18, 2020 at 09:05:00AM +0000, Alice Guo (OSS) wrote: > > + required: > > > + - compatible > > > + - nvmem-cells > > > + - nvmem-cell-names > > > + > > > +additionalProperties: true > > > > Don't leave comments unresolved (or resolve them against review without > > discussion). Rob asked for changing it. The same as with all schemas - you need > > to describe the missing properties. > > > > Best regards, > > Krzysztof > > Hi, > Thank you for your advice. I replied to him and let him know I remained here unchanged. There will be errors according to his suggestion. Then the solution is to correct the errors - describe missing properties - instead of ignoring the suggestion and making a resubmit right away. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 2020年12月18日 17:37 > To: Alice Guo (OSS) <alice.guo@oss.nxp.com> > Cc: robh+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de; > kernel@pengutronix.de; festevam@gmail.com; devicetree@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; dl-linux-imx > <linux-imx@nxp.com> > Subject: Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc > unique ID > > On Fri, Dec 18, 2020 at 09:05:00AM +0000, Alice Guo (OSS) wrote: > > > + required: > > > > + - compatible > > > > + - nvmem-cells > > > > + - nvmem-cell-names > > > > + > > > > +additionalProperties: true > > > > > > Don't leave comments unresolved (or resolve them against review > > > without discussion). Rob asked for changing it. The same as with all > > > schemas - you need to describe the missing properties. > > > > > > Best regards, > > > Krzysztof > > > > Hi, > > Thank you for your advice. I replied to him and let him know I remained here > unchanged. There will be errors according to his suggestion. > > Then the solution is to correct the errors - describe missing properties > - instead of ignoring the suggestion and making a resubmit right away. > > Best regards, > Krzysztof Hi, I am sorry I do not DT Binding doc very well. I checked the usage of patternProperties and additionalProperties in https://json-schema.org/understanding-json-schema/reference/object.html. I noticed a sentence on the website: " If additionalProperties is a boolean and set to false, no additional properties will be allowed.", so I think that if additionalProperties is a boolean and set to true, additional properties will be allowed. Letting here unchanged is my solution to correct the errors. I am not sure, I asked Rob for advice on the v6 by email, but he didn't reply to me, so I made a resubmit. Thank you for your comment again. Best regards, Alice
On Fri, Dec 18, 2020 at 4:14 AM Alice Guo (OSS) <alice.guo@oss.nxp.com> wrote: > > > > > -----Original Message----- > > From: Krzysztof Kozlowski <krzk@kernel.org> > > Sent: 2020年12月18日 17:37 > > To: Alice Guo (OSS) <alice.guo@oss.nxp.com> > > Cc: robh+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de; > > kernel@pengutronix.de; festevam@gmail.com; devicetree@vger.kernel.org; > > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; dl-linux-imx > > <linux-imx@nxp.com> > > Subject: Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc > > unique ID > > > > On Fri, Dec 18, 2020 at 09:05:00AM +0000, Alice Guo (OSS) wrote: > > > > + required: > > > > > + - compatible > > > > > + - nvmem-cells > > > > > + - nvmem-cell-names > > > > > + > > > > > +additionalProperties: true > > > > > > > > Don't leave comments unresolved (or resolve them against review > > > > without discussion). Rob asked for changing it. The same as with all > > > > schemas - you need to describe the missing properties. > > > > > > > > Best regards, > > > > Krzysztof > > > > > > Hi, > > > Thank you for your advice. I replied to him and let him know I remained here > > unchanged. There will be errors according to his suggestion. > > > > Then the solution is to correct the errors - describe missing properties > > - instead of ignoring the suggestion and making a resubmit right away. > > > > Best regards, > > Krzysztof > > Hi, > I am sorry I do not DT Binding doc very well. > > I checked the usage of patternProperties and additionalProperties in https://json-schema.org/understanding-json-schema/reference/object.html. > I noticed a sentence on the website: " If additionalProperties is a boolean and set to false, no additional properties will be allowed.", so I think that > if additionalProperties is a boolean and set to true, additional properties will be allowed. Letting here unchanged is my solution to correct the errors. > I am not sure, I asked Rob for advice on the v6 by email, but he didn't reply to me, so I made a resubmit. You waited an hour and I was sleeping! Waiting means waiting a week. You need to add '#address-cells' and '#size-cells'. Rob
> -----Original Message----- > From: Rob Herring <robh+dt@kernel.org> > Sent: 2020年12月18日 22:00 > To: Alice Guo (OSS) <alice.guo@oss.nxp.com> > Cc: Krzysztof Kozlowski <krzk@kernel.org>; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc > unique ID > > On Fri, Dec 18, 2020 at 4:14 AM Alice Guo (OSS) <alice.guo@oss.nxp.com> > wrote: > > > > > > > > > -----Original Message----- > > > From: Krzysztof Kozlowski <krzk@kernel.org> > > > Sent: 2020年12月18日 17:37 > > > To: Alice Guo (OSS) <alice.guo@oss.nxp.com> > > > Cc: robh+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de; > > > kernel@pengutronix.de; festevam@gmail.com; > > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > > linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > > Subject: Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding > > > doc for soc unique ID > > > > > > On Fri, Dec 18, 2020 at 09:05:00AM +0000, Alice Guo (OSS) wrote: > > > > > + required: > > > > > > + - compatible > > > > > > + - nvmem-cells > > > > > > + - nvmem-cell-names > > > > > > + > > > > > > +additionalProperties: true > > > > > > > > > > Don't leave comments unresolved (or resolve them against review > > > > > without discussion). Rob asked for changing it. The same as with > > > > > all schemas - you need to describe the missing properties. > > > > > > > > > > Best regards, > > > > > Krzysztof > > > > > > > > Hi, > > > > Thank you for your advice. I replied to him and let him know I > > > > remained here > > > unchanged. There will be errors according to his suggestion. > > > > > > Then the solution is to correct the errors - describe missing > > > properties > > > - instead of ignoring the suggestion and making a resubmit right away. > > > > > > Best regards, > > > Krzysztof > > > > Hi, > > I am sorry I do not DT Binding doc very well. > > > > I checked the usage of patternProperties and additionalProperties in > https://json-schema.org/understanding-json-schema/reference/object.html. > > I noticed a sentence on the website: " If additionalProperties is a > > boolean and set to false, no additional properties will be allowed.", so I think > that if additionalProperties is a boolean and set to true, additional properties > will be allowed. Letting here unchanged is my solution to correct the errors. > > I am not sure, I asked Rob for advice on the v6 by email, but he didn't reply to > me, so I made a resubmit. > > You waited an hour and I was sleeping! Waiting means waiting a week. > > You need to add '#address-cells' and '#size-cells'. > > Rob Hi, Rob Can change to the following code? When uses "additionalProperties: type: object", need to add model, compatible, interrupt-parent, #address-cells and #size-cells. There will be error with adding interrupt-parent because "dt-bindings: remove 'interrupt-parent' from bindings". # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 --- $id: http://devicetree.org/schemas/soc/imx/imx8m-soc.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# title: NXP i.MX8M Series SoC maintainers: - Alice Guo <alice.guo@nxp.com> description: | NXP i.MX8M series SoCs contain fuse entries from which SoC Unique ID can be obtained. properties: $nodename: const: '/' compatible: contains: enum: - fsl,imx8mm - fsl,imx8mn - fsl,imx8mp - fsl,imx8mq "#address-cells": const: 2 "#size-cells": const: 2 patternProperties: "^soc@[0-9a-f]+$": type: object properties: compatible: items: - enum: - fsl,imx8mm-soc - fsl,imx8mn-soc - fsl,imx8mp-soc - fsl,imx8mq-soc - const: simple-bus nvmem-cells: maxItems: 1 description: Phandle to the SOC Unique ID provided by a nvmem node nvmem-cells-names: const: soc_unique_id required: - compatible - nvmem-cells - nvmem-cell-names additionalProperties: true ... Best regards, Alice
On Mon, Dec 21, 2020 at 2:20 AM Alice Guo (OSS) <alice.guo@oss.nxp.com> wrote: > > > > > -----Original Message----- > > From: Rob Herring <robh+dt@kernel.org> > > Sent: 2020年12月18日 22:00 > > To: Alice Guo (OSS) <alice.guo@oss.nxp.com> > > Cc: Krzysztof Kozlowski <krzk@kernel.org>; shawnguo@kernel.org; > > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > Subject: Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc > > unique ID > > > > On Fri, Dec 18, 2020 at 4:14 AM Alice Guo (OSS) <alice.guo@oss.nxp.com> > > wrote: > > > > > > > > > > > > > -----Original Message----- > > > > From: Krzysztof Kozlowski <krzk@kernel.org> > > > > Sent: 2020年12月18日 17:37 > > > > To: Alice Guo (OSS) <alice.guo@oss.nxp.com> > > > > Cc: robh+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de; > > > > kernel@pengutronix.de; festevam@gmail.com; > > > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > > > linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > > > Subject: Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding > > > > doc for soc unique ID > > > > > > > > On Fri, Dec 18, 2020 at 09:05:00AM +0000, Alice Guo (OSS) wrote: > > > > > > + required: > > > > > > > + - compatible > > > > > > > + - nvmem-cells > > > > > > > + - nvmem-cell-names > > > > > > > + > > > > > > > +additionalProperties: true > > > > > > > > > > > > Don't leave comments unresolved (or resolve them against review > > > > > > without discussion). Rob asked for changing it. The same as with > > > > > > all schemas - you need to describe the missing properties. > > > > > > > > > > > > Best regards, > > > > > > Krzysztof > > > > > > > > > > Hi, > > > > > Thank you for your advice. I replied to him and let him know I > > > > > remained here > > > > unchanged. There will be errors according to his suggestion. > > > > > > > > Then the solution is to correct the errors - describe missing > > > > properties > > > > - instead of ignoring the suggestion and making a resubmit right away. > > > > > > > > Best regards, > > > > Krzysztof > > > > > > Hi, > > > I am sorry I do not DT Binding doc very well. > > > > > > I checked the usage of patternProperties and additionalProperties in > > https://json-schema.org/understanding-json-schema/reference/object.html. > > > I noticed a sentence on the website: " If additionalProperties is a > > > boolean and set to false, no additional properties will be allowed.", so I think > > that if additionalProperties is a boolean and set to true, additional properties > > will be allowed. Letting here unchanged is my solution to correct the errors. > > > I am not sure, I asked Rob for advice on the v6 by email, but he didn't reply to > > me, so I made a resubmit. > > > > You waited an hour and I was sleeping! Waiting means waiting a week. > > > > You need to add '#address-cells' and '#size-cells'. > > > > Rob > Hi, Rob > > Can change to the following code? > When uses "additionalProperties: type: object", need to add model, compatible, interrupt-parent, #address-cells and #size-cells. > There will be error with adding interrupt-parent because "dt-bindings: remove 'interrupt-parent' from bindings". You are at the wrong level. It's 'additionalProperties' for the soc node, not the root. See below. > > # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/soc/imx/imx8m-soc.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > title: NXP i.MX8M Series SoC > > maintainers: > - Alice Guo <alice.guo@nxp.com> > > description: | > NXP i.MX8M series SoCs contain fuse entries from which SoC Unique ID can be > obtained. > > properties: > $nodename: > const: '/' > > compatible: > contains: > enum: > - fsl,imx8mm > - fsl,imx8mn > - fsl,imx8mp > - fsl,imx8mq > > "#address-cells": > const: 2 > "#size-cells": > const: 2 > > patternProperties: > "^soc@[0-9a-f]+$": > type: object > properties: > compatible: > items: > - enum: > - fsl,imx8mm-soc > - fsl,imx8mn-soc > - fsl,imx8mp-soc > - fsl,imx8mq-soc > - const: simple-bus > > nvmem-cells: > maxItems: 1 > description: Phandle to the SOC Unique ID provided by a nvmem node > > nvmem-cells-names: > const: soc_unique_id > > required: > - compatible > - nvmem-cells > - nvmem-cell-names > additionalProperties: type: object > additionalProperties: true And keep this as-is. > ... > > Best regards, > Alice > >
diff --git a/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml b/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml new file mode 100644 index 000000000000..f0b0fc7b3ac6 --- /dev/null +++ b/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml @@ -0,0 +1,54 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/imx/imx8m-soc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP i.MX8M Series SoC + +maintainers: + - Alice Guo <alice.guo@nxp.com> + +description: | + NXP i.MX8M series SoCs contain fuse entries from which SoC Unique ID can be + obtained. + +select: + properties: + compatible: + contains: + enum: + - fsl,imx8mm + - fsl,imx8mn + - fsl,imx8mp + - fsl,imx8mq + required: + - compatible + +patternProperties: + "^soc@[0-9a-f]+$": + type: object + properties: + compatible: + items: + - enum: + - fsl,imx8mm-soc + - fsl,imx8mn-soc + - fsl,imx8mp-soc + - fsl,imx8mq-soc + - const: simple-bus + + nvmem-cells: + maxItems: 1 + description: Phandle to the SOC Unique ID provided by a nvmem node + + nvmem-cells-names: + const: soc_unique_id + + required: + - compatible + - nvmem-cells + - nvmem-cell-names + +additionalProperties: true +...