[RFC,v1,0/2] permit vendor specific timeouts for PMC

Message

Kiwoong Kim Dec. 18, 2020, 7:30 a.m. UTC

There are some attribute settings before power mode change in ufshcd.c
that should be variant per vendor.

Kiwoong Kim (2):
  ufs: add a quirk for vendor specifics before pmc
  ufs: ufs-exynos: apply vendor specifics for three timeouts

 drivers/scsi/ufs/ufs-exynos.c |  8 +++++++-
 drivers/scsi/ufs/ufshcd.c     | 40 +++++++++++++++++++++-------------------
 drivers/scsi/ufs/ufshcd.h     |  6 ++++++
 3 files changed, 34 insertions(+), 20 deletions(-)

Comments

Avri Altman Dec. 18, 2020, 1:33 p.m. UTC | #1

> 
> 
> There are some attribute settings before power mode change in ufshcd.c
> that should be variant per vendor.
But you've added a quirk, which is not what your commit log say.
If indeed unipro allows to skip/set values other than default - add the appropriate vop.
Otherwise, if it's just a non-standard behavior of exynos - then your patch is appropriate,
But you need to reword your commit log: both here and in your 1/2 patch.

Also, you forgot to remove the gerrit change-id.

Thanks,
Avri

> 
> Kiwoong Kim (2):
>   ufs: add a quirk for vendor specifics before pmc
>   ufs: ufs-exynos: apply vendor specifics for three timeouts
> 
>  drivers/scsi/ufs/ufs-exynos.c |  8 +++++++-
>  drivers/scsi/ufs/ufshcd.c     | 40 +++++++++++++++++++++-------------------
>  drivers/scsi/ufs/ufshcd.h     |  6 ++++++
>  3 files changed, 34 insertions(+), 20 deletions(-)
> 
> --
> 2.7.4

Kiwoong Kim Dec. 19, 2020, 2:55 a.m. UTC | #2

> > There are some attribute settings before power mode change in ufshcd.c
> > that should be variant per vendor.
> But you've added a quirk, which is not what your commit log say.
> If indeed unipro allows to skip/set values other than default - add the
> appropriate vop.
> Otherwise, if it's just a non-standard behavior of exynos - then your
> patch is appropriate, But you need to reword your commit log: both here
> and in your 1/2 patch.
> 
> Also, you forgot to remove the gerrit change-id.
> 
> Thanks,
> Avri

You're right and for change-id, there might be something wrong in my local branch.
Anyway thanks !


Thanks.
Kiwoong Kim

> >
> > Kiwoong Kim (2):
> >   ufs: add a quirk for vendor specifics before pmc
> >   ufs: ufs-exynos: apply vendor specifics for three timeouts
> >
> >  drivers/scsi/ufs/ufs-exynos.c |  8 +++++++-
> >  drivers/scsi/ufs/ufshcd.c     | 40 +++++++++++++++++++++----------------
> ---
> >  drivers/scsi/ufs/ufshcd.h     |  6 ++++++
> >  3 files changed, 34 insertions(+), 20 deletions(-)
> >
> > --
> > 2.7.4