| Message ID | 20201219124718.182664-1-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dmaengine: mediatek: mtk-hsdma: Fix a resource leak in the error handling path of the probe function | expand |
On 19-12-20, 13:47, Christophe JAILLET wrote: > 'mtk_hsdma_hw_deinit()' should be called in the error handling path of the > probe function to undo a previous 'mtk_hsdma_hw_init()' call, as already > done in the remove function. Applied, thanks
diff --git a/drivers/dma/mediatek/mtk-hsdma.c b/drivers/dma/mediatek/mtk-hsdma.c index f133ae8dece1..6ad8afbb95f2 100644 --- a/drivers/dma/mediatek/mtk-hsdma.c +++ b/drivers/dma/mediatek/mtk-hsdma.c @@ -1007,6 +1007,7 @@ static int mtk_hsdma_probe(struct platform_device *pdev) return 0; err_free: + mtk_hsdma_hw_deinit(hsdma); of_dma_controller_free(pdev->dev.of_node); err_unregister: dma_async_device_unregister(dd);
'mtk_hsdma_hw_deinit()' should be called in the error handling path of the probe function to undo a previous 'mtk_hsdma_hw_init()' call, as already done in the remove function. Fixes: 548c4597e984 ("dmaengine: mediatek: Add MediaTek High-Speed DMA controller for MT7622 and MT7623 SoC") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- 'mtk_hsdma_hw_init()' can return an error code, it could be good to check it as well. --- drivers/dma/mediatek/mtk-hsdma.c | 1 + 1 file changed, 1 insertion(+)