| Message ID | 20201222151613.5730-1-elder@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: ipa: fix interconnect enable bug | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 1 maintainers not CCed: elder@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 15 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On 12/22/20 17:16, Alex Elder wrote: > When the core clock rate and interconnect bandwidth specifications > were moved into configuration data, a copy/paste bug was introduced, > causing the memory interconnect bandwidth to be set three times > rather than enabling the three different interconnects. > > Fix this bug. > > Fixes: 91d02f9551501 ("net: ipa: use config data for clocking") > Signed-off-by: Alex Elder <elder@linaro.org> Reviewed-by: Georgi Djakov <georgi.djakov@linaro.org> > --- > drivers/net/ipa/ipa_clock.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c > index 9dcf16f399b7a..135c393437f12 100644 > --- a/drivers/net/ipa/ipa_clock.c > +++ b/drivers/net/ipa/ipa_clock.c > @@ -115,13 +115,13 @@ static int ipa_interconnect_enable(struct ipa *ipa) > return ret; > > data = &clock->interconnect_data[IPA_INTERCONNECT_IMEM]; > - ret = icc_set_bw(clock->memory_path, data->average_rate, > + ret = icc_set_bw(clock->imem_path, data->average_rate, > data->peak_rate); > if (ret) > goto err_memory_path_disable; > > data = &clock->interconnect_data[IPA_INTERCONNECT_CONFIG]; > - ret = icc_set_bw(clock->memory_path, data->average_rate, > + ret = icc_set_bw(clock->config_path, data->average_rate, > data->peak_rate); > if (ret) > goto err_imem_path_disable; >
On Tue, 22 Dec 2020 18:18:31 +0200 Georgi Djakov wrote: > On 12/22/20 17:16, Alex Elder wrote: > > When the core clock rate and interconnect bandwidth specifications > > were moved into configuration data, a copy/paste bug was introduced, > > causing the memory interconnect bandwidth to be set three times > > rather than enabling the three different interconnects. > > > > Fix this bug. > > > > Fixes: 91d02f9551501 ("net: ipa: use config data for clocking") > > Signed-off-by: Alex Elder <elder@linaro.org> > > Reviewed-by: Georgi Djakov <georgi.djakov@linaro.org> Applied, thanks!
diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c index 9dcf16f399b7a..135c393437f12 100644 --- a/drivers/net/ipa/ipa_clock.c +++ b/drivers/net/ipa/ipa_clock.c @@ -115,13 +115,13 @@ static int ipa_interconnect_enable(struct ipa *ipa) return ret; data = &clock->interconnect_data[IPA_INTERCONNECT_IMEM]; - ret = icc_set_bw(clock->memory_path, data->average_rate, + ret = icc_set_bw(clock->imem_path, data->average_rate, data->peak_rate); if (ret) goto err_memory_path_disable; data = &clock->interconnect_data[IPA_INTERCONNECT_CONFIG]; - ret = icc_set_bw(clock->memory_path, data->average_rate, + ret = icc_set_bw(clock->config_path, data->average_rate, data->peak_rate); if (ret) goto err_imem_path_disable;
When the core clock rate and interconnect bandwidth specifications were moved into configuration data, a copy/paste bug was introduced, causing the memory interconnect bandwidth to be set three times rather than enabling the three different interconnects. Fix this bug. Fixes: 91d02f9551501 ("net: ipa: use config data for clocking") Signed-off-by: Alex Elder <elder@linaro.org> --- drivers/net/ipa/ipa_clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)