[v2,0/3] perf arm64: Support SDT

Message

Leo Yan Dec. 25, 2020, 5:27 a.m. UTC

This patch is to enable SDT on Arm64.

Since Arm64 SDT marker in ELF file is different from other archs,
especially for using stack pointer (sp) to retrieve data for local
variables, patch 01 is used to fixup the arguments for this special
case.  Patch 02 is to add argument support for Arm64 SDT.

This patch set has been verified on Arm64/x86_64 platforms with a
testing program usdt_test.  The testing approach is described in the
patch set v1 [1].

Changes from v1:
* Added Arnaldo's patch for fixing memory leak (Arnaldo);
* Refined patch "perf probe: Fixup Arm64 SDT arguments" to use
  asprintf() and check pointer is valid or not (Arnaldo);
* Minor changes in patch "perf arm64: Add argument support for SDT"
  for the regular expression;
* Added Masami's Ack tag for patch 03.

[1] https://lore.kernel.org/patchwork/cover/1356212/


Arnaldo Carvalho de Melo (1):
  perf probe: Fix memory leak in synthesize_sdt_probe_command()

Leo Yan (2):
  perf probe: Fixup Arm64 SDT arguments
  perf arm64: Add argument support for SDT

 tools/perf/arch/arm64/util/perf_regs.c | 94 ++++++++++++++++++++++++++
 tools/perf/util/probe-file.c           | 49 ++++++++++++--
 2 files changed, 139 insertions(+), 4 deletions(-)

Comments

Arnaldo Carvalho de Melo Dec. 28, 2020, 12:54 p.m. UTC | #1

Em Fri, Dec 25, 2020 at 01:27:48PM +0800, Leo Yan escreveu:
> This patch is to enable SDT on Arm64.
> 
> Since Arm64 SDT marker in ELF file is different from other archs,
> especially for using stack pointer (sp) to retrieve data for local
> variables, patch 01 is used to fixup the arguments for this special
> case.  Patch 02 is to add argument support for Arm64 SDT.
> 
> This patch set has been verified on Arm64/x86_64 platforms with a
> testing program usdt_test.  The testing approach is described in the
> patch set v1 [1].
> 
> Changes from v1:
> * Added Arnaldo's patch for fixing memory leak (Arnaldo);
> * Refined patch "perf probe: Fixup Arm64 SDT arguments" to use
>   asprintf() and check pointer is valid or not (Arnaldo);
> * Minor changes in patch "perf arm64: Add argument support for SDT"
>   for the regular expression;
> * Added Masami's Ack tag for patch 03.
> 
> [1] https://lore.kernel.org/patchwork/cover/1356212/
> 

This one made it into 5.11
 
> Arnaldo Carvalho de Melo (1):
>   perf probe: Fix memory leak in synthesize_sdt_probe_command()
 
These were now merged in perf/core.

> Leo Yan (2):
>   perf probe: Fixup Arm64 SDT arguments
>   perf arm64: Add argument support for SDT

Thanks,

- Arnaldo

Leo Yan Dec. 29, 2020, 1:26 a.m. UTC | #2

On Mon, Dec 28, 2020 at 09:54:43AM -0300, Arnaldo Carvalho de Melo wrote:

[...]

> This one made it into 5.11
>  
> > Arnaldo Carvalho de Melo (1):
> >   perf probe: Fix memory leak in synthesize_sdt_probe_command()
>  
> These were now merged in perf/core.
> 
> > Leo Yan (2):
> >   perf probe: Fixup Arm64 SDT arguments
> >   perf arm64: Add argument support for SDT

Thanks, Arnaldo.