| Message ID | 1604313097-2178-1-git-send-email-mansur@codeaurora.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b57cf6a0a8894d5e89848e15e8f5e4cf36124aeb |
| Headers | show |
| Series | [RESEND] venus: fix calculating mbps in calculate_inst_freq() | expand |
Hi Mansur, On 2020-11-02 16:01, Mansur Alisha Shaik wrote: > Currently in calculate_inst_freq(), video driver is calculating > macro blocks per frame in stead of macro blocks per second(mpbs). instead > Which results frequency is always setting to lower frequency (150MB) > as per frequency table for sc7180. Hence the playback is not smooth. 150MHz > > Corrected this by correcting the mbps calculation in > calculate_inst_freq(). > > Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org> > --- > drivers/media/platform/qcom/venus/pm_helpers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c > b/drivers/media/platform/qcom/venus/pm_helpers.c > index 57877ea..001513f 100644 > --- a/drivers/media/platform/qcom/venus/pm_helpers.c > +++ b/drivers/media/platform/qcom/venus/pm_helpers.c > @@ -928,7 +928,7 @@ static unsigned long calculate_inst_freq(struct > venus_inst *inst, > u32 fps = (u32)inst->fps; > u32 mbs_per_sec; > > - mbs_per_sec = load_per_instance(inst) / fps; > + mbs_per_sec = load_per_instance(inst); Good find. Thanks, Vikash
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Mon, 2 Nov 2020 16:01:37 +0530 you wrote: > Currently in calculate_inst_freq(), video driver is calculating > macro blocks per frame in stead of macro blocks per second(mpbs). > Which results frequency is always setting to lower frequency (150MB) > as per frequency table for sc7180. Hence the playback is not smooth. > > Corrected this by correcting the mbps calculation in calculate_inst_freq(). > > [...] Here is the summary with links: - [RESEND] venus: fix calculating mbps in calculate_inst_freq() https://git.kernel.org/qcom/c/b57cf6a0a889 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c index 57877ea..001513f 100644 --- a/drivers/media/platform/qcom/venus/pm_helpers.c +++ b/drivers/media/platform/qcom/venus/pm_helpers.c @@ -928,7 +928,7 @@ static unsigned long calculate_inst_freq(struct venus_inst *inst, u32 fps = (u32)inst->fps; u32 mbs_per_sec; - mbs_per_sec = load_per_instance(inst) / fps; + mbs_per_sec = load_per_instance(inst); vpp_freq = mbs_per_sec * inst->clk_data.codec_freq_data->vpp_freq; /* 21 / 20 is overhead factor */
Currently in calculate_inst_freq(), video driver is calculating macro blocks per frame in stead of macro blocks per second(mpbs). Which results frequency is always setting to lower frequency (150MB) as per frequency table for sc7180. Hence the playback is not smooth. Corrected this by correcting the mbps calculation in calculate_inst_freq(). Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org> --- drivers/media/platform/qcom/venus/pm_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)