[v17,08/10] fs/ntfs3: Add Kconfig, Makefile and doc

Commit Message

Konstantin Komarov Dec. 31, 2020, 3:23 p.m. UTC

This adds Kconfig, Makefile and doc

Signed-off-by: Konstantin Komarov <[e-mail]>
---
 Documentation/filesystems/ntfs3.rst | 107 ++++++++++++++++++++++++++++
 fs/ntfs3/Kconfig                    |  41 +++++++++++
 fs/ntfs3/Makefile                   |  31 ++++++++
 3 files changed, 179 insertions(+)
 create mode 100644 Documentation/filesystems/ntfs3.rst
 create mode 100644 fs/ntfs3/Kconfig
 create mode 100644 fs/ntfs3/Makefile

Comments

Kari Argillander Jan. 3, 2021, 10:07 p.m. UTC | #1

On Thu, Dec 31, 2020 at 06:23:59PM +0300, Konstantin Komarov wrote:
> This adds Kconfig, Makefile and doc
> 
> Signed-off-by: Konstantin Komarov <[e-mail]>
> ---
>  Documentation/filesystems/ntfs3.rst | 107 ++++++++++++++++++++++++++++
>  fs/ntfs3/Kconfig                    |  41 +++++++++++
>  fs/ntfs3/Makefile                   |  31 ++++++++

Also Documentation/filesystems/index.rst should contain ntfs3.

>  3 files changed, 179 insertions(+)
>  create mode 100644 Documentation/filesystems/ntfs3.rst
>  create mode 100644 fs/ntfs3/Kconfig
>  create mode 100644 fs/ntfs3/Makefile
> 

> diff --git a/fs/ntfs3/Kconfig b/fs/ntfs3/Kconfig
> new file mode 100644
> index 000000000000..f9b732f4a5a0
> --- /dev/null
> +++ b/fs/ntfs3/Kconfig
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +config NTFS3_FS
> +	tristate "NTFS Read-Write file system support"
> +	select NLS
> +	help
> +	  Windows OS native file system (NTFS) support up to NTFS version 3.1.
> +
> +	  Y or M enables the NTFS3 driver with full features enabled (read,
> +	  write, journal replaying, sparse/compressed files support).
> +	  File system type to use on mount is "ntfs3". Module name (M option)
> +	  is also "ntfs3".
> +
> +	  Documentation: <file:Documentation/filesystems/ntfs3.rst>
> +
> +config NTFS3_64BIT_CLUSTER
> +	bool "64 bits per NTFS clusters"
> +	depends on NTFS3_FS && 64BIT
> +	help
> +	  Windows implementation of ntfs.sys uses 32 bits per clusters.
> +	  If activated 64 bits per clusters you will be able to use 4k cluster
> +	  for 16T+ volumes. Windows will not be able to mount such volumes.
> +
> +	  It is recommended to say N here.
> +
> +config NTFS3_LZX_XPRESS
> +	bool "activate support of external compressions lzx/xpress"
> +	depends on NTFS3_FS
> +	help
> +	  In Windows 10 one can use command "compact" to compress any files.
> +	  4 possible variants of compression are: xpress4k, xpress8k, xpress16 and lzx.
> +	  To read such "compacted" files say Y here.

It would be nice that we tell what is recommend. I think that this is recommend.
Of course if this use lot's of resource that is different story but I do not
think that is the case.

> +
> +config NTFS3_POSIX_ACL
> +	bool "NTFS POSIX Access Control Lists"
> +	depends on NTFS3_FS
> +	select FS_POSIX_ACL
> +	help
> +	  POSIX Access Control Lists (ACLs) support additional access rights
> +	  for users and groups beyond the standard owner/group/world scheme,
> +	  and this option selects support for ACLs specifically for ntfs
> +	  filesystems.

Same here. Let's suggest what user should do. Is this recommend if we wan't 
to use volume also in Windows?

Konstantin Komarov Jan. 18, 2021, 11:43 a.m. UTC | #2

From: Kari Argillander <[e-mail]>
Sent: Monday, January 4, 2021 1:08 AM
> To: Konstantin Komarov <[e-mail]>
> Cc: [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail];
> [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail];
> [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail];
> [e-mail]
> Subject: Re: [PATCH v17 08/10] fs/ntfs3: Add Kconfig, Makefile and doc
> 
> On Thu, Dec 31, 2020 at 06:23:59PM +0300, Konstantin Komarov wrote:
> > This adds Kconfig, Makefile and doc
> >
> > Signed-off-by: Konstantin Komarov <[e-mail]>
> > ---
> >  Documentation/filesystems/ntfs3.rst | 107 ++++++++++++++++++++++++++++
> >  fs/ntfs3/Kconfig                    |  41 +++++++++++
> >  fs/ntfs3/Makefile                   |  31 ++++++++
> 
> Also Documentation/filesystems/index.rst should contain ntfs3.
> 
> >  3 files changed, 179 insertions(+)
> >  create mode 100644 Documentation/filesystems/ntfs3.rst
> >  create mode 100644 fs/ntfs3/Kconfig
> >  create mode 100644 fs/ntfs3/Makefile
> >
> 
> > diff --git a/fs/ntfs3/Kconfig b/fs/ntfs3/Kconfig
> > new file mode 100644
> > index 000000000000..f9b732f4a5a0
> > --- /dev/null
> > +++ b/fs/ntfs3/Kconfig
> > @@ -0,0 +1,41 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +config NTFS3_FS
> > +	tristate "NTFS Read-Write file system support"
> > +	select NLS
> > +	help
> > +	  Windows OS native file system (NTFS) support up to NTFS version 3.1.
> > +
> > +	  Y or M enables the NTFS3 driver with full features enabled (read,
> > +	  write, journal replaying, sparse/compressed files support).
> > +	  File system type to use on mount is "ntfs3". Module name (M option)
> > +	  is also "ntfs3".
> > +
> > +	  Documentation: <file:Documentation/filesystems/ntfs3.rst>
> > +
> > +config NTFS3_64BIT_CLUSTER
> > +	bool "64 bits per NTFS clusters"
> > +	depends on NTFS3_FS && 64BIT
> > +	help
> > +	  Windows implementation of ntfs.sys uses 32 bits per clusters.
> > +	  If activated 64 bits per clusters you will be able to use 4k cluster
> > +	  for 16T+ volumes. Windows will not be able to mount such volumes.
> > +
> > +	  It is recommended to say N here.
> > +
> > +config NTFS3_LZX_XPRESS
> > +	bool "activate support of external compressions lzx/xpress"
> > +	depends on NTFS3_FS
> > +	help
> > +	  In Windows 10 one can use command "compact" to compress any files.
> > +	  4 possible variants of compression are: xpress4k, xpress8k, xpress16 and lzx.
> > +	  To read such "compacted" files say Y here.
> 
> It would be nice that we tell what is recommend. I think that this is recommend.
> Of course if this use lot's of resource that is different story but I do not
> think that is the case.
> 
> > +
> > +config NTFS3_POSIX_ACL
> > +	bool "NTFS POSIX Access Control Lists"
> > +	depends on NTFS3_FS
> > +	select FS_POSIX_ACL
> > +	help
> > +	  POSIX Access Control Lists (ACLs) support additional access rights
> > +	  for users and groups beyond the standard owner/group/world scheme,
> > +	  and this option selects support for ACLs specifically for ntfs
> > +	  filesystems.
> 
> Same here. Let's suggest what user should do. Is this recommend if we wan't
> to use volume also in Windows?

Hi! All done, thanks for pointing these out.

Mark Harmstone Jan. 18, 2021, 1:42 p.m. UTC | #3

On 18/1/21 11:43 am, Konstantin Komarov wrote:
> From: Kari Argillander <[e-mail]>
> Sent: Monday, January 4, 2021 1:08 AM
>> To: Konstantin Komarov <[e-mail]>
>> Cc: [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail];
>> [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail];
>> [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail];
>> [e-mail]
>> Subject: Re: [PATCH v17 08/10] fs/ntfs3: Add Kconfig, Makefile and doc
>>
>> On Thu, Dec 31, 2020 at 06:23:59PM +0300, Konstantin Komarov wrote:
>>> This adds Kconfig, Makefile and doc
>>>
>>> Signed-off-by: Konstantin Komarov <[e-mail]>
>>> ---
>>>  Documentation/filesystems/ntfs3.rst | 107 ++++++++++++++++++++++++++++
>>>  fs/ntfs3/Kconfig                    |  41 +++++++++++
>>>  fs/ntfs3/Makefile                   |  31 ++++++++
>> Also Documentation/filesystems/index.rst should contain ntfs3.
>>
>>>  3 files changed, 179 insertions(+)
>>>  create mode 100644 Documentation/filesystems/ntfs3.rst
>>>  create mode 100644 fs/ntfs3/Kconfig
>>>  create mode 100644 fs/ntfs3/Makefile
>>>
>>> diff --git a/fs/ntfs3/Kconfig b/fs/ntfs3/Kconfig
>>> new file mode 100644
>>> index 000000000000..f9b732f4a5a0
>>> --- /dev/null
>>> +++ b/fs/ntfs3/Kconfig
>>> @@ -0,0 +1,41 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only
>>> +config NTFS3_FS
>>> +	tristate "NTFS Read-Write file system support"
>>> +	select NLS
>>> +	help
>>> +	  Windows OS native file system (NTFS) support up to NTFS version 3.1.
>>> +
>>> +	  Y or M enables the NTFS3 driver with full features enabled (read,
>>> +	  write, journal replaying, sparse/compressed files support).
>>> +	  File system type to use on mount is "ntfs3". Module name (M option)
>>> +	  is also "ntfs3".
>>> +
>>> +	  Documentation: <file:Documentation/filesystems/ntfs3.rst>
>>> +
>>> +config NTFS3_64BIT_CLUSTER
>>> +	bool "64 bits per NTFS clusters"
>>> +	depends on NTFS3_FS && 64BIT
>>> +	help
>>> +	  Windows implementation of ntfs.sys uses 32 bits per clusters.
>>> +	  If activated 64 bits per clusters you will be able to use 4k cluster
>>> +	  for 16T+ volumes. Windows will not be able to mount such volumes.
>>> +
>>> +	  It is recommended to say N here.
>>> +
>>> +config NTFS3_LZX_XPRESS
>>> +	bool "activate support of external compressions lzx/xpress"
>>> +	depends on NTFS3_FS
>>> +	help
>>> +	  In Windows 10 one can use command "compact" to compress any files.
>>> +	  4 possible variants of compression are: xpress4k, xpress8k, xpress16 and lzx.
>>> +	  To read such "compacted" files say Y here.
>> It would be nice that we tell what is recommend. I think that this is recommend.
>> Of course if this use lot's of resource that is different story but I do not
>> think that is the case.
>>
>>> +
>>> +config NTFS3_POSIX_ACL
>>> +	bool "NTFS POSIX Access Control Lists"
>>> +	depends on NTFS3_FS
>>> +	select FS_POSIX_ACL
>>> +	help
>>> +	  POSIX Access Control Lists (ACLs) support additional access rights
>>> +	  for users and groups beyond the standard owner/group/world scheme,
>>> +	  and this option selects support for ACLs specifically for ntfs
>>> +	  filesystems.
>> Same here. Let's suggest what user should do. Is this recommend if we wan't
>> to use volume also in Windows?
> Hi! All done, thanks for pointing these out.

Is the existence of NTFS3_64BIT_CLUSTER wise? I mean, what on earth is the
point of an NTFS volume that Windows refuses to read?

If NTFS was properly documented by Microsoft, fair enough, but AFAIK it's
defined by what ntfs.sys does. I don't think we should be extending the
specification like this.

Patch

diff --git a/Documentation/filesystems/ntfs3.rst b/Documentation/filesystems/ntfs3.rst
new file mode 100644
index 000000000000..fb29067360cc
--- /dev/null
+++ b/Documentation/filesystems/ntfs3.rst
@@ -0,0 +1,107 @@ 
+.. SPDX-License-Identifier: GPL-2.0
+
+=====
+NTFS3
+=====
+
+
+Summary and Features
+====================
+
+NTFS3 is fully functional NTFS Read-Write driver. The driver works with
+NTFS versions up to 3.1, normal/compressed/sparse files
+and journal replaying. File system type to use on mount is 'ntfs3'.
+
+- This driver implements NTFS read/write support for normal, sparse and
+  compressed files.
+- Supports native journal replaying;
+- Supports extended attributes
+	Predefined extended attributes:
+	- 'system.ntfs_security' gets/sets security
+			descriptor (SECURITY_DESCRIPTOR_RELATIVE)
+	- 'system.ntfs_attrib' gets/sets ntfs file/dir attributes.
+		Note: applied to empty files, this allows to switch type between
+		sparse(0x200), compressed(0x800) and normal;
+- Supports NFS export of mounted NTFS volumes.
+
+Mount Options
+=============
+
+The list below describes mount options supported by NTFS3 driver in addition to
+generic ones.
+
+===============================================================================
+
+nls=name		This option informs the driver how to interpret path
+			strings and translate them to Unicode and back. If
+			this option is not set, the default codepage will be
+			used (CONFIG_NLS_DEFAULT).
+			Examples:
+				'nls=utf8'
+
+uid=
+gid=
+umask=			Controls the default permissions for files/directories created
+			after the NTFS volume is mounted.
+
+fmask=
+dmask=			Instead of specifying umask which applies both to
+			files and directories, fmask applies only to files and
+			dmask only to directories.
+
+nohidden		Files with the Windows-specific HIDDEN (FILE_ATTRIBUTE_HIDDEN)
+			attribute will not be shown under Linux.
+
+sys_immutable		Files with the Windows-specific SYSTEM
+			(FILE_ATTRIBUTE_SYSTEM) attribute will be marked as system
+			immutable files.
+
+discard			Enable support of the TRIM command for improved performance
+			on delete operations, which is recommended for use with the
+			solid-state drives (SSD).
+
+force			Forces the driver to mount partitions even if 'dirty' flag
+			(volume dirty) is set. Not recommended for use.
+
+sparse			Create new files as "sparse".
+
+showmeta		Use this parameter to show all meta-files (System Files) on
+			a mounted NTFS partition.
+			By default, all meta-files are hidden.
+
+prealloc		Preallocate space for files excessively when file size is
+			increasing on writes. Decreases fragmentation in case of
+			parallel write operations to different files.
+
+no_acs_rules		"No access rules" mount option sets access rights for
+			files/folders to 777 and owner/group to root. This mount
+			option absorbs all other permissions:
+			- permissions change for files/folders will be reported
+				as successful, but they will remain 777;
+			- owner/group change will be reported as successful, but
+				they will stay as root
+
+acl			Support POSIX ACLs (Access Control Lists). Effective if
+			supported by Kernel. Not to be confused with NTFS ACLs.
+			The option specified as acl enables support for POSIX ACLs.
+
+noatime			All files and directories will not update their last access
+			time attribute if a partition is mounted with this parameter.
+			This option can speed up file system operation.
+
+===============================================================================
+
+ToDo list
+=========
+
+- Full journaling support (currently journal replaying is supported) over JBD.
+
+
+References
+==========
+https://www.paragon-software.com/home/ntfs-linux-professional/
+	- Commercial version of the NTFS driver for Linux.
+
[e-mail]
+	- Direct e-mail address for feedback and requests on the NTFS3 implementation.
+
diff --git a/fs/ntfs3/Kconfig b/fs/ntfs3/Kconfig
new file mode 100644
index 000000000000..f9b732f4a5a0
--- /dev/null
+++ b/fs/ntfs3/Kconfig
@@ -0,0 +1,41 @@ 
+# SPDX-License-Identifier: GPL-2.0-only
+config NTFS3_FS
+	tristate "NTFS Read-Write file system support"
+	select NLS
+	help
+	  Windows OS native file system (NTFS) support up to NTFS version 3.1.
+
+	  Y or M enables the NTFS3 driver with full features enabled (read,
+	  write, journal replaying, sparse/compressed files support).
+	  File system type to use on mount is "ntfs3". Module name (M option)
+	  is also "ntfs3".
+
+	  Documentation: <file:Documentation/filesystems/ntfs3.rst>
+
+config NTFS3_64BIT_CLUSTER
+	bool "64 bits per NTFS clusters"
+	depends on NTFS3_FS && 64BIT
+	help
+	  Windows implementation of ntfs.sys uses 32 bits per clusters.
+	  If activated 64 bits per clusters you will be able to use 4k cluster
+	  for 16T+ volumes. Windows will not be able to mount such volumes.
+
+	  It is recommended to say N here.
+
+config NTFS3_LZX_XPRESS
+	bool "activate support of external compressions lzx/xpress"
+	depends on NTFS3_FS
+	help
+	  In Windows 10 one can use command "compact" to compress any files.
+	  4 possible variants of compression are: xpress4k, xpress8k, xpress16 and lzx.
+	  To read such "compacted" files say Y here.
+
+config NTFS3_POSIX_ACL
+	bool "NTFS POSIX Access Control Lists"
+	depends on NTFS3_FS
+	select FS_POSIX_ACL
+	help
+	  POSIX Access Control Lists (ACLs) support additional access rights
+	  for users and groups beyond the standard owner/group/world scheme,
+	  and this option selects support for ACLs specifically for ntfs
+	  filesystems.
diff --git a/fs/ntfs3/Makefile b/fs/ntfs3/Makefile
new file mode 100644
index 000000000000..b9aacc061781
--- /dev/null
+++ b/fs/ntfs3/Makefile
@@ -0,0 +1,31 @@ 
+# SPDX-License-Identifier: GPL-2.0
+#
+# Makefile for the ntfs3 filesystem support.
+#
+
+obj-$(CONFIG_NTFS3_FS) += ntfs3.o
+
+ntfs3-y :=	attrib.o \
+		attrlist.o \
+		bitfunc.o \
+		bitmap.o \
+		dir.o \
+		fsntfs.o \
+		frecord.o \
+		file.o \
+		fslog.o \
+		inode.o \
+		index.o \
+		lznt.o \
+		namei.o \
+		record.o \
+		run.o \
+		super.o \
+		upcase.o \
+		xattr.o
+
+ntfs3-$(CONFIG_NTFS3_LZX_XPRESS) += $(addprefix lib/,\
+		decompress_common.o \
+		lzx_decompress.o \
+		xpress_decompress.o \
+		)
\ No newline at end of file