| Message ID | 20201225013546.300116-1-jianpeng.ma@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5b04cb8224ef9bf0d9af8a4c0e6e23806bb2d720 |
| Headers | show |
| Series | libnvdimm/pmem: remove unused header. | expand |
On Fri, Dec 25, 2020 at 09:35:46AM +0800, Jianpeng Ma wrote: > 'commit a8b456d01cd6 ("bdi: remove BDI_CAP_SYNCHRONOUS_IO")' forgot This information should be part of a fixes tag. Other than that looks ok. Reviewed-by: Ira Weiny <ira.weiny@intel.com> > remove the related header file. > > Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com> > --- > drivers/nvdimm/pmem.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c > index 875076b0ea6c..f33bdae626ba 100644 > --- a/drivers/nvdimm/pmem.c > +++ b/drivers/nvdimm/pmem.c > @@ -23,7 +23,6 @@ > #include <linux/uio.h> > #include <linux/dax.h> > #include <linux/nd.h> > -#include <linux/backing-dev.h> > #include <linux/mm.h> > #include <asm/cacheflush.h> > #include "pmem.h" > -- > 2.29.2 > _______________________________________________ > Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org > To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
On Mon, Dec 28, 2020 at 9:18 AM Ira Weiny <ira.weiny@intel.com> wrote: > > On Fri, Dec 25, 2020 at 09:35:46AM +0800, Jianpeng Ma wrote: > > 'commit a8b456d01cd6 ("bdi: remove BDI_CAP_SYNCHRONOUS_IO")' forgot > > This information should be part of a fixes tag. Oh, I was just about to comment "don't provide a Fixes tag for pure cleanups". Fixes is for functional issues that a backporter should consider.
On Mon, Jan 04, 2021 at 01:16:32PM -0800, Dan Williams wrote: > On Mon, Dec 28, 2020 at 9:18 AM Ira Weiny <ira.weiny@intel.com> wrote: > > > > On Fri, Dec 25, 2020 at 09:35:46AM +0800, Jianpeng Ma wrote: > > > 'commit a8b456d01cd6 ("bdi: remove BDI_CAP_SYNCHRONOUS_IO")' forgot > > > > This information should be part of a fixes tag. > > Oh, I was just about to comment "don't provide a Fixes tag for pure > cleanups". Fixes is for functional issues that a backporter should > consider. I thought this was discussed recently and it was concluded that 'fixes' does not indicate something should be backported? ... https://lore.kernel.org/lkml/X8flmVAwl0158872@kroah.com/ At least that is what Greg KH said. But Dave C. was not happy with this... :-/ Sorry... Ira
On Mon, Jan 4, 2021 at 2:19 PM Ira Weiny <ira.weiny@intel.com> wrote: > > On Mon, Jan 04, 2021 at 01:16:32PM -0800, Dan Williams wrote: > > On Mon, Dec 28, 2020 at 9:18 AM Ira Weiny <ira.weiny@intel.com> wrote: > > > > > > On Fri, Dec 25, 2020 at 09:35:46AM +0800, Jianpeng Ma wrote: > > > > 'commit a8b456d01cd6 ("bdi: remove BDI_CAP_SYNCHRONOUS_IO")' forgot > > > > > > This information should be part of a fixes tag. > > > > Oh, I was just about to comment "don't provide a Fixes tag for pure > > cleanups". Fixes is for functional issues that a backporter should > > consider. > > I thought this was discussed recently and it was concluded that 'fixes' does > not indicate something should be backported? > > ... > > https://lore.kernel.org/lkml/X8flmVAwl0158872@kroah.com/ > > At least that is what Greg KH said. But Dave C. was not happy with this... I was thinking of it more from the distro automation tooling that I know fires up it sees a "Fixes" tag. At a minimum this would make those systems / humans fire up just to notice, "oh, just a plain cleanup with no logical side-effects".
On Mon, Jan 04, 2021 at 02:32:06PM -0800, Dan Williams wrote: > On Mon, Jan 4, 2021 at 2:19 PM Ira Weiny <ira.weiny@intel.com> wrote: > > > > On Mon, Jan 04, 2021 at 01:16:32PM -0800, Dan Williams wrote: > > > On Mon, Dec 28, 2020 at 9:18 AM Ira Weiny <ira.weiny@intel.com> wrote: > > > > > > > > On Fri, Dec 25, 2020 at 09:35:46AM +0800, Jianpeng Ma wrote: > > > > > 'commit a8b456d01cd6 ("bdi: remove BDI_CAP_SYNCHRONOUS_IO")' forgot > > > > > > > > This information should be part of a fixes tag. > > > > > > Oh, I was just about to comment "don't provide a Fixes tag for pure > > > cleanups". Fixes is for functional issues that a backporter should > > > consider. > > > > I thought this was discussed recently and it was concluded that 'fixes' does > > not indicate something should be backported? > > > > ... > > > > https://lore.kernel.org/lkml/X8flmVAwl0158872@kroah.com/ > > > > At least that is what Greg KH said. But Dave C. was not happy with this... > > I was thinking of it more from the distro automation tooling that I > know fires up it sees a "Fixes" tag. At a minimum this would make > those systems / humans fire up just to notice, "oh, just a plain > cleanup with no logical side-effects". I'm not really following but I don't think it is a big deal either way. It just seemed like the text used looked like a 'fixes' line and seemed ok to put in there. In this case it is probably fine. Sorry for the noise, Ira
diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index 875076b0ea6c..f33bdae626ba 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -23,7 +23,6 @@ #include <linux/uio.h> #include <linux/dax.h> #include <linux/nd.h> -#include <linux/backing-dev.h> #include <linux/mm.h> #include <asm/cacheflush.h> #include "pmem.h"
'commit a8b456d01cd6 ("bdi: remove BDI_CAP_SYNCHRONOUS_IO")' forgot remove the related header file. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com> --- drivers/nvdimm/pmem.c | 1 - 1 file changed, 1 deletion(-)