mbox series

[v4,0/5] Misc meson fixes along test-vmstate fixes

Message ID 20210107101919.80-1-luoyonggang@gmail.com (mailing list archive)
Headers show
Series Misc meson fixes along test-vmstate fixes | expand

Message

Yonggang Luo Jan. 7, 2021, 10:19 a.m. UTC
V1-V2
Fixes whpx: Fixes include of whp-dispatch.h in whpx.h by
  the suggestion of Philippe Mathieu-Daudé <philmd@redhat.com>
Add new patch whpx: move whpx_lapic_state from header to c file

The test-vmstate can be passed under win32 too
so enable it on win32,
This is based on Bonzini's upstream tag along

Yonggang Luo (5):
  cirrus/msys2: Exit powershell with $LastExitCode
  cirrus/msys2: Cache msys2 mingw in a better way.
  maintainers: Add me as Windows Hosted Continuous Integration
    maintainer
  whpx: Fixes include of whp-dispatch.h in whpx.h
  whpx: move whpx_lapic_state from header to c file

 .cirrus.yml                  | 119 ++++++++++++++++++++---------------
 MAINTAINERS                  |   6 ++
 include/sysemu/whpx.h        |   9 +--
 target/i386/whpx/whpx-apic.c |   7 +++
 4 files changed, 84 insertions(+), 57 deletions(-)

Comments

Paolo Bonzini Jan. 7, 2021, 10:28 a.m. UTC | #1
On 07/01/21 11:19, Yonggang Luo wrote:
> V1-V2
> Fixes whpx: Fixes include of whp-dispatch.h in whpx.h by
>    the suggestion of Philippe Mathieu-Daudé <philmd@redhat.com>
> Add new patch whpx: move whpx_lapic_state from header to c file
> 
> The test-vmstate can be passed under win32 too
> so enable it on win32,
> This is based on Bonzini's upstream tag along
> 
> Yonggang Luo (5):
>    cirrus/msys2: Exit powershell with $LastExitCode
>    cirrus/msys2: Cache msys2 mingw in a better way.
>    maintainers: Add me as Windows Hosted Continuous Integration
>      maintainer
>    whpx: Fixes include of whp-dispatch.h in whpx.h
>    whpx: move whpx_lapic_state from header to c file
> 
>   .cirrus.yml                  | 119 ++++++++++++++++++++---------------
>   MAINTAINERS                  |   6 ++
>   include/sysemu/whpx.h        |   9 +--
>   target/i386/whpx/whpx-apic.c |   7 +++
>   4 files changed, 84 insertions(+), 57 deletions(-)
> 

Instead of your patch 4, can you look at 
https://patchew.org/QEMU/20201219090637.1700900-1-pbonzini@redhat.com/ 
instead?

Paolo
no-reply@patchew.org Jan. 7, 2021, 10:30 a.m. UTC | #2
Patchew URL: https://patchew.org/QEMU/20210107101919.80-1-luoyonggang@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210107101919.80-1-luoyonggang@gmail.com
Subject: [PATCH v4 0/5] Misc meson fixes along test-vmstate fixes

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210107072933.3828450-1-f4bug@amsat.org -> patchew/20210107072933.3828450-1-f4bug@amsat.org
 * [new tag]         patchew/20210107101919.80-1-luoyonggang@gmail.com -> patchew/20210107101919.80-1-luoyonggang@gmail.com
Switched to a new branch 'test'
d93d83c whpx: move whpx_lapic_state from header to c file
538f307 whpx: Fixes include of whp-dispatch.h in whpx.h
067501d maintainers: Add me as Windows Hosted Continuous Integration maintainer
f41409d cirrus/msys2: Cache msys2 mingw in a better way.
99acb3d cirrus/msys2: Exit powershell with $LastExitCode

=== OUTPUT BEGIN ===
1/5 Checking commit 99acb3d7c333 (cirrus/msys2: Exit powershell with $LastExitCode)
2/5 Checking commit f41409d6d5f1 (cirrus/msys2: Cache msys2 mingw in a better way.)
ERROR: trailing whitespace
#142: FILE: .cirrus.yml:141:
+        del -Force -Recurse -ErrorAction SilentlyContinue c:\tools\msys64 $

total: 1 errors, 0 warnings, 140 lines checked

Patch 2/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/5 Checking commit 067501d7586d (maintainers: Add me as Windows Hosted Continuous Integration maintainer)
4/5 Checking commit 538f3072fc14 (whpx: Fixes include of whp-dispatch.h in whpx.h)
5/5 Checking commit d93d83c9f8db (whpx: move whpx_lapic_state from header to c file)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210107101919.80-1-luoyonggang@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Paolo Bonzini Jan. 7, 2021, 11:35 a.m. UTC | #3
On 07/01/21 11:19, Yonggang Luo wrote:
> V1-V2
> Fixes whpx: Fixes include of whp-dispatch.h in whpx.h by
>    the suggestion of Philippe Mathieu-Daudé <philmd@redhat.com>
> Add new patch whpx: move whpx_lapic_state from header to c file
> 
> The test-vmstate can be passed under win32 too
> so enable it on win32,
> This is based on Bonzini's upstream tag along
> 
> Yonggang Luo (5):
>    cirrus/msys2: Exit powershell with $LastExitCode
>    cirrus/msys2: Cache msys2 mingw in a better way.
>    maintainers: Add me as Windows Hosted Continuous Integration
>      maintainer
>    whpx: Fixes include of whp-dispatch.h in whpx.h
>    whpx: move whpx_lapic_state from header to c file
> 
>   .cirrus.yml                  | 119 ++++++++++++++++++++---------------
>   MAINTAINERS                  |   6 ++
>   include/sysemu/whpx.h        |   9 +--
>   target/i386/whpx/whpx-apic.c |   7 +++
>   4 files changed, 84 insertions(+), 57 deletions(-)
> 

Queued, thanks.

Paolo