mbox series

[net-next,0/4] udp_tunnel_nic: post conversion cleanup

Message ID 20210106210637.1839662-1-kuba@kernel.org (mailing list archive)
Headers show
Series udp_tunnel_nic: post conversion cleanup | expand

Message

Jakub Kicinski Jan. 6, 2021, 9:06 p.m. UTC
It has been two releases since we added the common infra for UDP
tunnel port offload, and we have not heard of any major issues.
Remove the old direct driver NDOs completely, and perform minor
simplifications in the tunnel drivers.

Jakub Kicinski (4):
  udp_tunnel: hard-wire NDOs to udp_tunnel_nic_*_port() helpers
  udp_tunnel: remove REGISTER/UNREGISTER handling from tunnel drivers
  net: remove ndo_udp_tunnel_* callbacks
  udp_tunnel: reshuffle NETIF_F_RX_UDP_TUNNEL_PORT checks

 drivers/net/ethernet/amd/xgbe/xgbe-drv.c      |  2 --
 .../net/ethernet/broadcom/bnx2x/bnx2x_main.c  |  2 --
 drivers/net/ethernet/broadcom/bnxt/bnxt.c     |  2 --
 .../net/ethernet/cavium/liquidio/lio_main.c   |  2 --
 .../ethernet/cavium/liquidio/lio_vf_main.c    |  2 --
 .../net/ethernet/chelsio/cxgb4/cxgb4_main.c   |  2 --
 drivers/net/ethernet/cisco/enic/enic_main.c   |  4 ----
 drivers/net/ethernet/emulex/benet/be_main.c   |  2 --
 .../net/ethernet/intel/fm10k/fm10k_netdev.c   |  2 --
 drivers/net/ethernet/intel/i40e/i40e_main.c   |  2 --
 drivers/net/ethernet/intel/ice/ice_main.c     |  2 --
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  2 --
 .../net/ethernet/mellanox/mlx4/en_netdev.c    |  4 ----
 .../net/ethernet/mellanox/mlx5/core/en_main.c |  2 --
 .../net/ethernet/mellanox/mlx5/core/en_rep.c  |  2 --
 .../ethernet/netronome/nfp/nfp_net_common.c   |  2 --
 drivers/net/ethernet/qlogic/qede/qede_main.c  |  6 -----
 .../net/ethernet/qlogic/qlcnic/qlcnic_main.c  |  2 --
 drivers/net/ethernet/sfc/efx.c                |  2 --
 drivers/net/geneve.c                          | 14 ++++-------
 drivers/net/netdevsim/netdev.c                |  2 --
 drivers/net/vxlan.c                           | 15 ++++--------
 include/linux/netdevice.h                     | 17 -------------
 include/net/udp_tunnel.h                      |  8 +++++++
 net/core/dev.c                                |  2 +-
 net/ipv4/udp_tunnel_core.c                    | 24 ++++---------------
 26 files changed, 22 insertions(+), 106 deletions(-)

Comments

Alexander Duyck Jan. 6, 2021, 9:53 p.m. UTC | #1
On Wed, Jan 6, 2021 at 1:07 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> It has been two releases since we added the common infra for UDP
> tunnel port offload, and we have not heard of any major issues.
> Remove the old direct driver NDOs completely, and perform minor
> simplifications in the tunnel drivers.
>
> Jakub Kicinski (4):
>   udp_tunnel: hard-wire NDOs to udp_tunnel_nic_*_port() helpers
>   udp_tunnel: remove REGISTER/UNREGISTER handling from tunnel drivers
>   net: remove ndo_udp_tunnel_* callbacks
>   udp_tunnel: reshuffle NETIF_F_RX_UDP_TUNNEL_PORT checks

The patch set looks good to me.

Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
Jacob Keller Jan. 7, 2021, 6:44 p.m. UTC | #2
On 1/6/2021 1:06 PM, Jakub Kicinski wrote:
> It has been two releases since we added the common infra for UDP
> tunnel port offload, and we have not heard of any major issues.
> Remove the old direct driver NDOs completely, and perform minor
> simplifications in the tunnel drivers.
> 

Nice to see this step! Everything seems straight forward to me.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

> Jakub Kicinski (4):
>   udp_tunnel: hard-wire NDOs to udp_tunnel_nic_*_port() helpers
>   udp_tunnel: remove REGISTER/UNREGISTER handling from tunnel drivers
>   net: remove ndo_udp_tunnel_* callbacks
>   udp_tunnel: reshuffle NETIF_F_RX_UDP_TUNNEL_PORT checks
> 
>  drivers/net/ethernet/amd/xgbe/xgbe-drv.c      |  2 --
>  .../net/ethernet/broadcom/bnx2x/bnx2x_main.c  |  2 --
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c     |  2 --
>  .../net/ethernet/cavium/liquidio/lio_main.c   |  2 --
>  .../ethernet/cavium/liquidio/lio_vf_main.c    |  2 --
>  .../net/ethernet/chelsio/cxgb4/cxgb4_main.c   |  2 --
>  drivers/net/ethernet/cisco/enic/enic_main.c   |  4 ----
>  drivers/net/ethernet/emulex/benet/be_main.c   |  2 --
>  .../net/ethernet/intel/fm10k/fm10k_netdev.c   |  2 --
>  drivers/net/ethernet/intel/i40e/i40e_main.c   |  2 --
>  drivers/net/ethernet/intel/ice/ice_main.c     |  2 --
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  2 --
>  .../net/ethernet/mellanox/mlx4/en_netdev.c    |  4 ----
>  .../net/ethernet/mellanox/mlx5/core/en_main.c |  2 --
>  .../net/ethernet/mellanox/mlx5/core/en_rep.c  |  2 --
>  .../ethernet/netronome/nfp/nfp_net_common.c   |  2 --
>  drivers/net/ethernet/qlogic/qede/qede_main.c  |  6 -----
>  .../net/ethernet/qlogic/qlcnic/qlcnic_main.c  |  2 --
>  drivers/net/ethernet/sfc/efx.c                |  2 --
>  drivers/net/geneve.c                          | 14 ++++-------
>  drivers/net/netdevsim/netdev.c                |  2 --
>  drivers/net/vxlan.c                           | 15 ++++--------
>  include/linux/netdevice.h                     | 17 -------------
>  include/net/udp_tunnel.h                      |  8 +++++++
>  net/core/dev.c                                |  2 +-
>  net/ipv4/udp_tunnel_core.c                    | 24 ++++---------------
>  26 files changed, 22 insertions(+), 106 deletions(-)
>
Jakub Kicinski Jan. 7, 2021, 10:34 p.m. UTC | #3
On Wed,  6 Jan 2021 13:06:33 -0800 Jakub Kicinski wrote:
> It has been two releases since we added the common infra for UDP
> tunnel port offload, and we have not heard of any major issues.
> Remove the old direct driver NDOs completely, and perform minor
> simplifications in the tunnel drivers.

Applied, thanks for the reviews!