[v2,0/2] btrfs: btrfs_dec_test_*_ordered_extent() refactor

Message

Qu Wenruo Dec. 22, 2020, 5:59 a.m. UTC

This small patchset is btrfs_dec_test_*_ordered_extent() refactor during
subpage RW support development.

This is mostly to make btrfs_dev_test_* functions more human readable
and prepare it for calling btrfs_dec_test_first_ordered_extent() in
btrfs_writepage_endio_finish_ordered() where we can have one or more
ordered extents for one bvec.

The first patch is a very safe width reduction, where there is only one
assginment. Thus it should be very safe and won't be involved in other
call sites.

Changelog:
v2:
- Remove the width reduction in the 2nd patch
  The u64->u32 width reduction has too many parts involved, it's really
  hard to do it cleanly just in one patch.
  Remove the width reduction and focus on the existing refactors.

Qu Wenruo (2):
  btrfs: make btrfs_dio_private::bytes to be u32
  btrfs: refactor btrfs_dec_test_* functions for ordered extents

 fs/btrfs/btrfs_inode.h  |  2 +-
 fs/btrfs/inode.c        |  5 +--
 fs/btrfs/ordered-data.c | 99 ++++++++++++++++++++++-------------------
 fs/btrfs/ordered-data.h | 10 ++---
 4 files changed, 60 insertions(+), 56 deletions(-)

Comments

David Sterba Jan. 12, 2021, 2:29 p.m. UTC | #1

On Tue, Dec 22, 2020 at 01:59:22PM +0800, Qu Wenruo wrote:
> This small patchset is btrfs_dec_test_*_ordered_extent() refactor during
> subpage RW support development.
> 
> This is mostly to make btrfs_dev_test_* functions more human readable
> and prepare it for calling btrfs_dec_test_first_ordered_extent() in
> btrfs_writepage_endio_finish_ordered() where we can have one or more
> ordered extents for one bvec.
> 
> The first patch is a very safe width reduction, where there is only one
> assginment. Thus it should be very safe and won't be involved in other
> call sites.

I've added a comment to the 'bytes' and reworded some comments in the
2nd patch, now added to misc-next, thanks.