| Message ID | 20210111125046.36326-1-marex@denx.de (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: ks8851: Select PHYLIB and MICREL_PHY in Kconfig | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 3 maintainers not CCed: kuba@kernel.org masahiroy@kernel.org davem@davemloft.net |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 16 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Mon, Jan 11, 2021 at 01:50:46PM +0100, Marek Vasut wrote: > The PHYLIB must be selected to provide mdiobus_*() functions, and the > MICREL_PHY is necessary too, as that is the only possible PHY attached > to the KS8851 (it is the internal PHY). > > Fixes: ef3631220d2b ("net: ks8851: Register MDIO bus and the internal PHY") > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Heiner Kallweit <hkallweit1@gmail.com> > Cc: Lukas Wunner <lukas@wunner.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Mon, 11 Jan 2021 15:49:33 +0100 Andrew Lunn wrote: > On Mon, Jan 11, 2021 at 01:50:46PM +0100, Marek Vasut wrote: > > The PHYLIB must be selected to provide mdiobus_*() functions, and the > > MICREL_PHY is necessary too, as that is the only possible PHY attached > > to the KS8851 (it is the internal PHY). > > > > Fixes: ef3631220d2b ("net: ks8851: Register MDIO bus and the internal PHY") > > Signed-off-by: Marek Vasut <marex@denx.de> > > Cc: Andrew Lunn <andrew@lunn.ch> > > Cc: Heiner Kallweit <hkallweit1@gmail.com> > > Cc: Lukas Wunner <lukas@wunner.de> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> Applied, thanks!
diff --git a/drivers/net/ethernet/micrel/Kconfig b/drivers/net/ethernet/micrel/Kconfig index 42bc014136fe..93df3049cdc0 100644 --- a/drivers/net/ethernet/micrel/Kconfig +++ b/drivers/net/ethernet/micrel/Kconfig @@ -31,6 +31,8 @@ config KS8851 select MII select CRC32 select EEPROM_93CX6 + select PHYLIB + select MICREL_PHY help SPI driver for Micrel KS8851 SPI attached network chip. @@ -40,6 +42,8 @@ config KS8851_MLL select MII select CRC32 select EEPROM_93CX6 + select PHYLIB + select MICREL_PHY help This platform driver is for Micrel KS8851 Address/data bus multiplexed network chip.
The PHYLIB must be selected to provide mdiobus_*() functions, and the MICREL_PHY is necessary too, as that is the only possible PHY attached to the KS8851 (it is the internal PHY). Fixes: ef3631220d2b ("net: ks8851: Register MDIO bus and the internal PHY") Signed-off-by: Marek Vasut <marex@denx.de> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Heiner Kallweit <hkallweit1@gmail.com> Cc: Lukas Wunner <lukas@wunner.de> --- drivers/net/ethernet/micrel/Kconfig | 4 ++++ 1 file changed, 4 insertions(+)