| Message ID | 20210112170411.187513575@linutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm/highmem: Fix fallout from generic kmap_local conversions | expand |
On Tue, Jan 12, 2021 at 06:01:39PM +0100, Thomas Gleixner wrote: > set_pte_at() on MIPS invokes update_cache() which might recurse into > kmap_local(). Use set_pte() like the original MIPS highmem implementation > did. > > Fixes: a4c33e83bca1 ("mips/mm/highmem: Switch to generic kmap atomic") > Reported-by: Paul Cercueil <paul@crapouillou.net> > Reported-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > --- > arch/mips/include/asm/highmem.h | 1 + > 1 file changed, 1 insertion(+) Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
--- a/arch/mips/include/asm/highmem.h +++ b/arch/mips/include/asm/highmem.h @@ -51,6 +51,7 @@ extern void kmap_flush_tlb(unsigned long #define flush_cache_kmaps() BUG_ON(cpu_has_dc_aliases) +#define arch_kmap_local_set_pte(mm, vaddr, ptep, ptev) set_pte(ptep, ptev) #define arch_kmap_local_post_map(vaddr, pteval) local_flush_tlb_one(vaddr) #define arch_kmap_local_post_unmap(vaddr) local_flush_tlb_one(vaddr)
set_pte_at() on MIPS invokes update_cache() which might recurse into kmap_local(). Use set_pte() like the original MIPS highmem implementation did. Fixes: a4c33e83bca1 ("mips/mm/highmem: Switch to generic kmap atomic") Reported-by: Paul Cercueil <paul@crapouillou.net> Reported-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- arch/mips/include/asm/highmem.h | 1 + 1 file changed, 1 insertion(+)