[v4,0/2] Add base layer priority id control

Message

Dikshita Agarwal Jan. 4, 2021, 5:41 a.m. UTC

This series adds base layer priority id control for encoder
and support for the same in venus driver.

Changes since v3:
- Rebased the changes on latest media tree.
- Addressed the comments.
- Added driver side implementation for new control.

Dikshita Agarwal (2):
  media: v4l2-ctrl: Add base layer priority id control.
  venus: venc : Add support for priority ID control.

 Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 9 +++++++++
 drivers/media/platform/qcom/venus/core.h                  | 2 ++
 drivers/media/platform/qcom/venus/venc_ctrls.c            | 9 ++++++++-
 drivers/media/v4l2-core/v4l2-ctrls.c                      | 1 +
 include/uapi/linux/v4l2-controls.h                        | 1 +
 5 files changed, 21 insertions(+), 1 deletion(-)

Comments

Hans Verkuil Jan. 13, 2021, 4:44 p.m. UTC | #1

Hi Dikshita,

On 04/01/2021 06:41, Dikshita Agarwal wrote:
> This series adds base layer priority id control for encoder
> and support for the same in venus driver.

Posted a pull request for this series and the "Add new controls for QP and
layer bitrate" series.

Note that because the "Add encoder ctrls for long term reference" is not
merged, the control ID for V4L2_CID_MPEG_VIDEO_BASELAYER_PRIORITY_ID changed
and that you need to rebase the "Add encoder ctrls for long term reference"
series accordingly.

Regards,

	Hans

> 
> Changes since v3:
> - Rebased the changes on latest media tree.
> - Addressed the comments.
> - Added driver side implementation for new control.
> 
> Dikshita Agarwal (2):
>   media: v4l2-ctrl: Add base layer priority id control.
>   venus: venc : Add support for priority ID control.
> 
>  Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 9 +++++++++
>  drivers/media/platform/qcom/venus/core.h                  | 2 ++
>  drivers/media/platform/qcom/venus/venc_ctrls.c            | 9 ++++++++-
>  drivers/media/v4l2-core/v4l2-ctrls.c                      | 1 +
>  include/uapi/linux/v4l2-controls.h                        | 1 +
>  5 files changed, 21 insertions(+), 1 deletion(-)
>