| Message ID | 20201229175521.268234-1-marex@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX | expand |
Hi Marek On 12/29/20 6:55 PM, Marek Vasut wrote: > The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0. > Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and > using output-low DT property leads to the GPIO being set high instead. > > Fixes: ac68793f49de ("ARM: dts: stm32: Add DHCOM based PicoITX board") > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Alexandre Torgue <alexandre.torgue@st.com> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Patrice Chotard <patrice.chotard@st.com> > Cc: Patrick Delaunay <patrick.delaunay@st.com> > Cc: linux-stm32@st-md-mailman.stormreply.com > To: linux-arm-kernel@lists.infradead.org > --- > arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi > index 25528a1c096f..757707766fa0 100644 > --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi > +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi > @@ -49,7 +49,7 @@ &gpioa { > */ > usb-port-power-hog { On my tree this node is "usb-port-power". Do you want to update the node name too ? I can do it directly during the merge if you want. (Note, it is the case for DRC02 hog update). regards alex > gpio-hog; > - gpios = <13 GPIO_ACTIVE_LOW>; > + gpios = <13 0>; > output-low; > line-name = "usb-port-power"; > }; >
On 1/14/21 4:11 PM, Alexandre TORGUE wrote: > Hi Marek Hi, [...] >> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi >> b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi >> index 25528a1c096f..757707766fa0 100644 >> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi >> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi >> @@ -49,7 +49,7 @@ &gpioa { >> */ >> usb-port-power-hog { > > On my tree this node is "usb-port-power". Do you want to update the node > name too ? I can do it directly during the merge if you want. > (Note, it is the case for DRC02 hog update). Please pick "[PATCH] ARM: dts: stm32: Fix GPIO hog names on DHCOM" first, then this patch should apply cleanly.
On 1/14/21 6:08 PM, Marek Vasut wrote: > On 1/14/21 4:11 PM, Alexandre TORGUE wrote: >> Hi Marek > > Hi, > > [...] > >>> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi >>> b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi >>> index 25528a1c096f..757707766fa0 100644 >>> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi >>> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi >>> @@ -49,7 +49,7 @@ &gpioa { >>> */ >>> usb-port-power-hog { >> >> On my tree this node is "usb-port-power". Do you want to update the >> node name too ? I can do it directly during the merge if you want. >> (Note, it is the case for DRC02 hog update). > > Please pick "[PATCH] ARM: dts: stm32: Fix GPIO hog names on DHCOM" > first, then this patch should apply cleanly. Yes I just saw this one. It doesn't contain a fixes tag, I can add the same than for other hog patches ?
On 1/14/21 6:11 PM, Alexandre TORGUE wrote: > > > On 1/14/21 6:08 PM, Marek Vasut wrote: >> On 1/14/21 4:11 PM, Alexandre TORGUE wrote: >>> Hi Marek >> >> Hi, >> >> [...] >> >>>> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi >>>> b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi >>>> index 25528a1c096f..757707766fa0 100644 >>>> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi >>>> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi >>>> @@ -49,7 +49,7 @@ &gpioa { >>>> */ >>>> usb-port-power-hog { >>> >>> On my tree this node is "usb-port-power". Do you want to update the >>> node name too ? I can do it directly during the merge if you want. >>> (Note, it is the case for DRC02 hog update). >> >> Please pick "[PATCH] ARM: dts: stm32: Fix GPIO hog names on DHCOM" >> first, then this patch should apply cleanly. > > Yes I just saw this one. It doesn't contain a fixes tag, I can add the > same than for other hog patches ? If that is OK with you, please do. Thanks
On 1/14/21 6:13 PM, Marek Vasut wrote: > On 1/14/21 6:11 PM, Alexandre TORGUE wrote: >> >> >> On 1/14/21 6:08 PM, Marek Vasut wrote: >>> On 1/14/21 4:11 PM, Alexandre TORGUE wrote: >>>> Hi Marek >>> >>> Hi, >>> >>> [...] >>> >>>>> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi >>>>> b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi >>>>> index 25528a1c096f..757707766fa0 100644 >>>>> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi >>>>> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi >>>>> @@ -49,7 +49,7 @@ &gpioa { >>>>> */ >>>>> usb-port-power-hog { >>>> >>>> On my tree this node is "usb-port-power". Do you want to update the >>>> node name too ? I can do it directly during the merge if you want. >>>> (Note, it is the case for DRC02 hog update). >>> >>> Please pick "[PATCH] ARM: dts: stm32: Fix GPIO hog names on DHCOM" >>> first, then this patch should apply cleanly. >> >> Yes I just saw this one. It doesn't contain a fixes tag, I can add the >> same than for other hog patches ? > > If that is OK with you, please do. Thanks Done. Series applied on stm32-fixes. Regards Alex
diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi index 25528a1c096f..757707766fa0 100644 --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi @@ -49,7 +49,7 @@ &gpioa { */ usb-port-power-hog { gpio-hog; - gpios = <13 GPIO_ACTIVE_LOW>; + gpios = <13 0>; output-low; line-name = "usb-port-power"; };
The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0. Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and using output-low DT property leads to the GPIO being set high instead. Fixes: ac68793f49de ("ARM: dts: stm32: Add DHCOM based PicoITX board") Signed-off-by: Marek Vasut <marex@denx.de> Cc: Alexandre Torgue <alexandre.torgue@st.com> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: Patrice Chotard <patrice.chotard@st.com> Cc: Patrick Delaunay <patrick.delaunay@st.com> Cc: linux-stm32@st-md-mailman.stormreply.com To: linux-arm-kernel@lists.infradead.org --- arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)