| Message ID | 1610618858-5093-1-git-send-email-stefanc@marvell.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: mvpp2: extend mib-fragments name to mib-fragments-err | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 5 of 5 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 5 this patch: 5 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | fail | ERROR: Remove Gerrit Change-Id's before submitting upstream |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 5 this patch: 5 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Thu, Jan 14, 2021 at 12:07:38PM +0200, stefanc@marvell.com wrote: > From: Stefan Chulski <stefanc@marvell.com> > > This patch doesn't change any functionality, but just extend > MIB counter register and ethtool-statistic names with "err". > > The counter MVPP2_MIB_FRAGMENTS_RCVD in fact is Error counter. > Extend REG name and appropriated ethtool statistic reg-name > with the ERR/err. > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > @@ -1566,7 +1566,7 @@ static u32 mvpp2_read_index(struct mvpp2 *priv, u32 index, u32 reg) > { MVPP2_MIB_FC_RCVD, "fc_received" }, > { MVPP2_MIB_RX_FIFO_OVERRUN, "rx_fifo_overrun" }, > { MVPP2_MIB_UNDERSIZE_RCVD, "undersize_received" }, > - { MVPP2_MIB_FRAGMENTS_RCVD, "fragments_received" }, > + { MVPP2_MIB_FRAGMENTS_ERR_RCVD, "fragments_err_received" }, Hi Stefan I suspect this is now ABI and you cannot change it. You at least need to argue why it is not ABI. Andrew
> > From: Stefan Chulski <stefanc@marvell.com> > > > > This patch doesn't change any functionality, but just extend MIB > > counter register and ethtool-statistic names with "err". > > > > The counter MVPP2_MIB_FRAGMENTS_RCVD in fact is Error counter. > > Extend REG name and appropriated ethtool statistic reg-name with the > > ERR/err. > > > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > @@ -1566,7 +1566,7 @@ static u32 mvpp2_read_index(struct mvpp2 > *priv, u32 index, u32 reg) > > { MVPP2_MIB_FC_RCVD, "fc_received" }, > > { MVPP2_MIB_RX_FIFO_OVERRUN, "rx_fifo_overrun" }, > > { MVPP2_MIB_UNDERSIZE_RCVD, "undersize_received" }, > > - { MVPP2_MIB_FRAGMENTS_RCVD, "fragments_received" }, > > + { MVPP2_MIB_FRAGMENTS_ERR_RCVD, "fragments_err_received" }, > > Hi Stefan > > I suspect this is now ABI and you cannot change it. You at least need to argue > why it is not ABI. > > Andrew Hi Andrew, I not familiar with ABI concept. Does this mean we cannot change, fix or extend driver ethtool counters? Thanks, Stefan.
On Thu, 14 Jan 2021 12:07:38 +0200 stefanc@marvell.com wrote: > From: Stefan Chulski <stefanc@marvell.com> > > This patch doesn't change any functionality, but just extend > MIB counter register and ethtool-statistic names with "err". > > The counter MVPP2_MIB_FRAGMENTS_RCVD in fact is Error counter. > Extend REG name and appropriated ethtool statistic reg-name > with the ERR/err. > > Change-Id: Ic32b9779b90ba99789e83e85cfaddb5da9e7fda9 > Signed-off-by: Stefan Chulski <stefanc@marvell.com> Please strip the gerrit IDs from the upstream patches. Checkpatch flags this as an error. Please always run checkpatch --strict before submitting.
On Thu, 14 Jan 2021 16:13:23 +0000 Stefan Chulski wrote: > > > From: Stefan Chulski <stefanc@marvell.com> > > > > > > This patch doesn't change any functionality, but just extend MIB > > > counter register and ethtool-statistic names with "err". > > > > > > The counter MVPP2_MIB_FRAGMENTS_RCVD in fact is Error counter. > > > Extend REG name and appropriated ethtool statistic reg-name with the > > > ERR/err. > > > > > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > @@ -1566,7 +1566,7 @@ static u32 mvpp2_read_index(struct mvpp2 > > *priv, u32 index, u32 reg) > > > { MVPP2_MIB_FC_RCVD, "fc_received" }, > > > { MVPP2_MIB_RX_FIFO_OVERRUN, "rx_fifo_overrun" }, > > > { MVPP2_MIB_UNDERSIZE_RCVD, "undersize_received" }, > > > - { MVPP2_MIB_FRAGMENTS_RCVD, "fragments_received" }, > > > + { MVPP2_MIB_FRAGMENTS_ERR_RCVD, "fragments_err_received" }, > > > > Hi Stefan > > > > I suspect this is now ABI and you cannot change it. You at least need to argue > > why it is not ABI. > > > > Andrew > > Hi Andrew, > > I not familiar with ABI concept. Does this mean we cannot change, fix > or extend driver ethtool counters? Extend yes, but some user may have a script tracking "fragments_received", that script would break if you rename it. It'd be good if the hardware errors were reported in standard netdev statistics.
On Thu, Jan 14, 2021 at 04:13:23PM +0000, Stefan Chulski wrote: > > > From: Stefan Chulski <stefanc@marvell.com> > > > > > > This patch doesn't change any functionality, but just extend MIB > > > counter register and ethtool-statistic names with "err". > > > > > > The counter MVPP2_MIB_FRAGMENTS_RCVD in fact is Error counter. > > > Extend REG name and appropriated ethtool statistic reg-name with the > > > ERR/err. > > > > > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > @@ -1566,7 +1566,7 @@ static u32 mvpp2_read_index(struct mvpp2 > > *priv, u32 index, u32 reg) > > > { MVPP2_MIB_FC_RCVD, "fc_received" }, > > > { MVPP2_MIB_RX_FIFO_OVERRUN, "rx_fifo_overrun" }, > > > { MVPP2_MIB_UNDERSIZE_RCVD, "undersize_received" }, > > > - { MVPP2_MIB_FRAGMENTS_RCVD, "fragments_received" }, > > > + { MVPP2_MIB_FRAGMENTS_ERR_RCVD, "fragments_err_received" }, > > > > Hi Stefan > > > > I suspect this is now ABI and you cannot change it. You at least need to argue > > why it is not ABI. > > > > Andrew > > Hi Andrew, > > I not familiar with ABI concept. Does this mean we cannot change, fix or extend driver ethtool counters? As Jakub pointed out, there could be user space looking for this name. What you could do is add fragments_err_received in addition to fragments_received. That should not break anything. Andrew
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h index 6bd7e40..6c9b7c9 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h @@ -899,7 +899,7 @@ enum mvpp22_ptp_packet_format { #define MVPP2_MIB_FC_RCVD 0x58 #define MVPP2_MIB_RX_FIFO_OVERRUN 0x5c #define MVPP2_MIB_UNDERSIZE_RCVD 0x60 -#define MVPP2_MIB_FRAGMENTS_RCVD 0x64 +#define MVPP2_MIB_FRAGMENTS_ERR_RCVD 0x64 #define MVPP2_MIB_OVERSIZE_RCVD 0x68 #define MVPP2_MIB_JABBER_RCVD 0x6c #define MVPP2_MIB_MAC_RCV_ERROR 0x70 diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c index 3982956..85fcdd6 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c @@ -1566,7 +1566,7 @@ static u32 mvpp2_read_index(struct mvpp2 *priv, u32 index, u32 reg) { MVPP2_MIB_FC_RCVD, "fc_received" }, { MVPP2_MIB_RX_FIFO_OVERRUN, "rx_fifo_overrun" }, { MVPP2_MIB_UNDERSIZE_RCVD, "undersize_received" }, - { MVPP2_MIB_FRAGMENTS_RCVD, "fragments_received" }, + { MVPP2_MIB_FRAGMENTS_ERR_RCVD, "fragments_err_received" }, { MVPP2_MIB_OVERSIZE_RCVD, "oversize_received" }, { MVPP2_MIB_JABBER_RCVD, "jabber_received" }, { MVPP2_MIB_MAC_RCV_ERROR, "mac_receive_error" },