| Message ID | 1608894171-54174-1-git-send-email-tiantao6@hisilicon.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix the compatibility of zsmalloc and zswap | expand |
On Fri, Dec 25, 2020 at 12:02 PM Tian Tao <tiantao6@hisilicon.com> wrote: > > patch #1 add a flag to zpool, then zswap used to determine if zpool > drivers such as zbud/z3fold/zsmalloc whether can sleep in atoimc context. > patch #2 set flag sleep_mapped to true indicates that zbud/z3fold can > sleep in atomic context. zsmalloc didin't support sleep in atomic context, > so not set that flag to true. > > Tian Tao (2): > mm/zswap: add the flag can_sleep_mapped > mm: set the sleep_mapped to true for zbud and z3fold > > include/linux/zpool.h | 3 +++ > mm/z3fold.c | 1 + > mm/zbud.c | 1 + > mm/zpool.c | 13 +++++++++++++ > mm/zswap.c | 50 +++++++++++++++++++++++++++++++++++++++++++++----- > 5 files changed, 63 insertions(+), 5 deletions(-) Haven't been able to actually test these yet, but looks good to me so far, so Reviewed-by: Vitaly Wool <vitaly.wool@konsulko.com> Please wait a bit for Mike, Sebastian or me to actually test this. Also, keep them CC'd explicitly if you are to come up with a new version for some reason. Best regards, Vitaly
在 2021/1/15 2:46, Vitaly Wool 写道: > On Fri, Dec 25, 2020 at 12:02 PM Tian Tao <tiantao6@hisilicon.com> wrote: >> patch #1 add a flag to zpool, then zswap used to determine if zpool >> drivers such as zbud/z3fold/zsmalloc whether can sleep in atoimc context. >> patch #2 set flag sleep_mapped to true indicates that zbud/z3fold can >> sleep in atomic context. zsmalloc didin't support sleep in atomic context, >> so not set that flag to true. >> >> Tian Tao (2): >> mm/zswap: add the flag can_sleep_mapped >> mm: set the sleep_mapped to true for zbud and z3fold >> >> include/linux/zpool.h | 3 +++ >> mm/z3fold.c | 1 + >> mm/zbud.c | 1 + >> mm/zpool.c | 13 +++++++++++++ >> mm/zswap.c | 50 +++++++++++++++++++++++++++++++++++++++++++++----- >> 5 files changed, 63 insertions(+), 5 deletions(-) > Haven't been able to actually test these yet, but looks good to me so far, so I have tested that this patch works well，it's better to double check by you or someone else. > > Reviewed-by: Vitaly Wool <vitaly.wool@konsulko.com> > > Please wait a bit for Mike, Sebastian or me to actually test this. > Also, keep them CC'd explicitly if you are to come up with a new > version for some reason. > > Best regards, > Vitaly > . >
On 2021-01-14 19:46:06 [+0100], Vitaly Wool wrote: > Please wait a bit for Mike, Sebastian or me to actually test this. > Also, keep them CC'd explicitly if you are to come up with a new > version for some reason. Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> I can reproduce Mike's backtrace on v5.11-rc3 which does not show with these two patches applied. > Best regards, > Vitaly Sebastian
在 2021/1/15 9:17, tiantao (H) 写道: > > 在 2021/1/15 2:46, Vitaly Wool 写道: >> On Fri, Dec 25, 2020 at 12:02 PM Tian Tao <tiantao6@hisilicon.com> >> wrote: >>> patch #1 add a flag to zpool, then zswap used to determine if zpool >>> drivers such as zbud/z3fold/zsmalloc whether can sleep in atoimc >>> context. >>> patch #2 set flag sleep_mapped to true indicates that zbud/z3fold can >>> sleep in atomic context. zsmalloc didin't support sleep in atomic >>> context, >>> so not set that flag to true. >>> >>> Tian Tao (2): >>> mm/zswap: add the flag can_sleep_mapped >>> mm: set the sleep_mapped to true for zbud and z3fold >>> >>> include/linux/zpool.h | 3 +++ >>> mm/z3fold.c | 1 + >>> mm/zbud.c | 1 + >>> mm/zpool.c | 13 +++++++++++++ >>> mm/zswap.c | 50 >>> +++++++++++++++++++++++++++++++++++++++++++++----- >>> 5 files changed, 63 insertions(+), 5 deletions(-) >> Haven't been able to actually test these yet, but looks good to me so >> far, so > I have tested that this patch works well，it's better to double check > by you or someone else. Is there anyone else testing this patch? Can I send an official patch out? >> >> Reviewed-by: Vitaly Wool <vitaly.wool@konsulko.com> >> >> Please wait a bit for Mike, Sebastian or me to actually test this. >> Also, keep them CC'd explicitly if you are to come up with a new >> version for some reason. >> >> Best regards, >> Vitaly >> . >> > > . >
On Tue, 2021-01-19 at 09:31 +0800, tiantao (H) wrote: > > Is there anyone else testing this patch? Dunno, but I'm not, Sebastian having already done that. > Can I send an official patch out? I don't see why not, it's been tested. -Mike