diff mbox series

[v3,09/10] iotests/129: Clean up pylint and mypy complaints

Message ID 20210114170304.87507-10-mreitz@redhat.com (mailing list archive)
State New, archived
Headers show
Series iotests: Fix 129 and expand 297’s reach | expand

Commit Message

Max Reitz Jan. 14, 2021, 5:03 p.m. UTC 
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 tests/qemu-iotests/129 | 4 ++--
 tests/qemu-iotests/297 | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Willian Rampazzo Jan. 14, 2021, 8:02 p.m. UTC | #1 
On Thu, Jan 14, 2021 at 2:41 PM Max Reitz <mreitz@redhat.com> wrote:
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  tests/qemu-iotests/129 | 4 ++--
>  tests/qemu-iotests/297 | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
> index 6d21470cd7..201d9e0a0b 100755
> --- a/tests/qemu-iotests/129
> +++ b/tests/qemu-iotests/129
> @@ -20,7 +20,6 @@
>
>  import os
>  import iotests
> -import time
>
>  class TestStopWithBlockJob(iotests.QMPTestCase):
>      test_img = os.path.join(iotests.test_dir, 'test.img')
> @@ -32,7 +31,8 @@ class TestStopWithBlockJob(iotests.QMPTestCase):
>          iotests.qemu_img('create', '-f', iotests.imgfmt, self.base_img, "1G")
>          iotests.qemu_img('create', '-f', iotests.imgfmt, self.test_img,
>                           "-b", self.base_img, '-F', iotests.imgfmt)
> -        iotests.qemu_io('-f', iotests.imgfmt, '-c', 'write -P0x5d 1M 128M', self.test_img)
> +        iotests.qemu_io('-f', iotests.imgfmt, '-c', 'write -P0x5d 1M 128M',
> +                        self.test_img)
>          self.vm = iotests.VM()
>          self.vm.add_object('throttle-group,id=tg0,x-bps-total=1024')
>
> diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297
> index bfa26d280b..1dce1d1b1c 100755
> --- a/tests/qemu-iotests/297
> +++ b/tests/qemu-iotests/297
> @@ -27,7 +27,7 @@ import iotests
>  # TODO: Empty this list!
>  SKIP_FILES = (
>      '030', '040', '041', '044', '045', '055', '056', '057', '065', '093',
> -    '096', '118', '124', '129', '132', '136', '139', '147', '148', '149',
> +    '096', '118', '124', '132', '136', '139', '147', '148', '149',

Is this also part of mypy/pylint cleanup? It seems you are doing more
than that here. It would be good to have this listed in the commit
message. Despite that,

Reviewed-by: Willian Rampazzo <willianr@redhat.com>

>      '151', '152', '155', '163', '165', '169', '194', '196', '199', '202',
>      '203', '205', '206', '207', '208', '210', '211', '212', '213', '216',
>      '218', '219', '222', '224', '228', '234', '235', '236', '237', '238',
> --
> 2.29.2
>
>
Max Reitz Jan. 15, 2021, 9:30 a.m. UTC | #2 
On 14.01.21 21:02, Willian Rampazzo wrote:
> On Thu, Jan 14, 2021 at 2:41 PM Max Reitz <mreitz@redhat.com> wrote:
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   tests/qemu-iotests/129 | 4 ++--
>>   tests/qemu-iotests/297 | 2 +-
>>   2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
>> index 6d21470cd7..201d9e0a0b 100755
>> --- a/tests/qemu-iotests/129
>> +++ b/tests/qemu-iotests/129
>> @@ -20,7 +20,6 @@
>>
>>   import os
>>   import iotests
>> -import time
>>
>>   class TestStopWithBlockJob(iotests.QMPTestCase):
>>       test_img = os.path.join(iotests.test_dir, 'test.img')
>> @@ -32,7 +31,8 @@ class TestStopWithBlockJob(iotests.QMPTestCase):
>>           iotests.qemu_img('create', '-f', iotests.imgfmt, self.base_img, "1G")
>>           iotests.qemu_img('create', '-f', iotests.imgfmt, self.test_img,
>>                            "-b", self.base_img, '-F', iotests.imgfmt)
>> -        iotests.qemu_io('-f', iotests.imgfmt, '-c', 'write -P0x5d 1M 128M', self.test_img)
>> +        iotests.qemu_io('-f', iotests.imgfmt, '-c', 'write -P0x5d 1M 128M',
>> +                        self.test_img)
>>           self.vm = iotests.VM()
>>           self.vm.add_object('throttle-group,id=tg0,x-bps-total=1024')
>>
>> diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297
>> index bfa26d280b..1dce1d1b1c 100755
>> --- a/tests/qemu-iotests/297
>> +++ b/tests/qemu-iotests/297
>> @@ -27,7 +27,7 @@ import iotests
>>   # TODO: Empty this list!
>>   SKIP_FILES = (
>>       '030', '040', '041', '044', '045', '055', '056', '057', '065', '093',
>> -    '096', '118', '124', '129', '132', '136', '139', '147', '148', '149',
>> +    '096', '118', '124', '132', '136', '139', '147', '148', '149',
> 
> Is this also part of mypy/pylint cleanup? It seems you are doing more
> than that here. It would be good to have this listed in the commit
> message.

Sure, why not.  Something like “And consequentially drop it from 297's 
skip list.”?

Though I think making a test pass pylint+mypy complaints basically means 
exactly to remove it from 297's skip list and then making 297 pass, so 
I’m not entirely sure it’s necessary.  But it can’t hurt, so.

> Despite that,
> 
> Reviewed-by: Willian Rampazzo <willianr@redhat.com>

Thanks!

Max

>>       '151', '152', '155', '163', '165', '169', '194', '196', '199', '202',
>>       '203', '205', '206', '207', '208', '210', '211', '212', '213', '216',
>>       '218', '219', '222', '224', '228', '234', '235', '236', '237', '238',
>> --
>> 2.29.2
>>
>>
>
Vladimir Sementsov-Ogievskiy Jan. 15, 2021, 11:18 a.m. UTC | #3 
14.01.2021 20:03, Max Reitz wrote:
> Signed-off-by: Max Reitz<mreitz@redhat.com>


Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Willian Rampazzo Jan. 15, 2021, 2:43 p.m. UTC | #4 
On Fri, Jan 15, 2021 at 6:30 AM Max Reitz <mreitz@redhat.com> wrote:
>
> On 14.01.21 21:02, Willian Rampazzo wrote:
> > On Thu, Jan 14, 2021 at 2:41 PM Max Reitz <mreitz@redhat.com> wrote:
> >>
> >> Signed-off-by: Max Reitz <mreitz@redhat.com>
> >> ---
> >>   tests/qemu-iotests/129 | 4 ++--
> >>   tests/qemu-iotests/297 | 2 +-
> >>   2 files changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
> >> index 6d21470cd7..201d9e0a0b 100755
> >> --- a/tests/qemu-iotests/129
> >> +++ b/tests/qemu-iotests/129
> >> @@ -20,7 +20,6 @@
> >>
> >>   import os
> >>   import iotests
> >> -import time
> >>
> >>   class TestStopWithBlockJob(iotests.QMPTestCase):
> >>       test_img = os.path.join(iotests.test_dir, 'test.img')
> >> @@ -32,7 +31,8 @@ class TestStopWithBlockJob(iotests.QMPTestCase):
> >>           iotests.qemu_img('create', '-f', iotests.imgfmt, self.base_img, "1G")
> >>           iotests.qemu_img('create', '-f', iotests.imgfmt, self.test_img,
> >>                            "-b", self.base_img, '-F', iotests.imgfmt)
> >> -        iotests.qemu_io('-f', iotests.imgfmt, '-c', 'write -P0x5d 1M 128M', self.test_img)
> >> +        iotests.qemu_io('-f', iotests.imgfmt, '-c', 'write -P0x5d 1M 128M',
> >> +                        self.test_img)
> >>           self.vm = iotests.VM()
> >>           self.vm.add_object('throttle-group,id=tg0,x-bps-total=1024')
> >>
> >> diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297
> >> index bfa26d280b..1dce1d1b1c 100755
> >> --- a/tests/qemu-iotests/297
> >> +++ b/tests/qemu-iotests/297
> >> @@ -27,7 +27,7 @@ import iotests
> >>   # TODO: Empty this list!
> >>   SKIP_FILES = (
> >>       '030', '040', '041', '044', '045', '055', '056', '057', '065', '093',
> >> -    '096', '118', '124', '129', '132', '136', '139', '147', '148', '149',
> >> +    '096', '118', '124', '132', '136', '139', '147', '148', '149',
> >
> > Is this also part of mypy/pylint cleanup? It seems you are doing more
> > than that here. It would be good to have this listed in the commit
> > message.
>
> Sure, why not.  Something like “And consequentially drop it from 297's
> skip list.”?

+1 Thanks!

>
> Though I think making a test pass pylint+mypy complaints basically means
> exactly to remove it from 297's skip list and then making 297 pass, so
> I’m not entirely sure it’s necessary.  But it can’t hurt, so.
>
> > Despite that,
> >
> > Reviewed-by: Willian Rampazzo <willianr@redhat.com>
>
> Thanks!
>
> Max
>
> >>       '151', '152', '155', '163', '165', '169', '194', '196', '199', '202',
> >>       '203', '205', '206', '207', '208', '210', '211', '212', '213', '216',
> >>       '218', '219', '222', '224', '228', '234', '235', '236', '237', '238',
> >> --
> >> 2.29.2
> >>
> >>
> >
>
diff mbox series

Patch

diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
index 6d21470cd7..201d9e0a0b 100755
--- a/tests/qemu-iotests/129
+++ b/tests/qemu-iotests/129
@@ -20,7 +20,6 @@ 
 
 import os
 import iotests
-import time
 
 class TestStopWithBlockJob(iotests.QMPTestCase):
     test_img = os.path.join(iotests.test_dir, 'test.img')
@@ -32,7 +31,8 @@  class TestStopWithBlockJob(iotests.QMPTestCase):
         iotests.qemu_img('create', '-f', iotests.imgfmt, self.base_img, "1G")
         iotests.qemu_img('create', '-f', iotests.imgfmt, self.test_img,
                          "-b", self.base_img, '-F', iotests.imgfmt)
-        iotests.qemu_io('-f', iotests.imgfmt, '-c', 'write -P0x5d 1M 128M', self.test_img)
+        iotests.qemu_io('-f', iotests.imgfmt, '-c', 'write -P0x5d 1M 128M',
+                        self.test_img)
         self.vm = iotests.VM()
         self.vm.add_object('throttle-group,id=tg0,x-bps-total=1024')
 
diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297
index bfa26d280b..1dce1d1b1c 100755
--- a/tests/qemu-iotests/297
+++ b/tests/qemu-iotests/297
@@ -27,7 +27,7 @@  import iotests
 # TODO: Empty this list!
 SKIP_FILES = (
     '030', '040', '041', '044', '045', '055', '056', '057', '065', '093',
-    '096', '118', '124', '129', '132', '136', '139', '147', '148', '149',
+    '096', '118', '124', '132', '136', '139', '147', '148', '149',
     '151', '152', '155', '163', '165', '169', '194', '196', '199', '202',
     '203', '205', '206', '207', '208', '210', '211', '212', '213', '216',
     '218', '219', '222', '224', '228', '234', '235', '236', '237', '238',