| Message ID | 20210113044302.25522-1-ayush.sawal@chelsio.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e3a7670737ecd7eb55b5c5e1900678e2a2e51ef9 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] ch_ipsec: Remove initialization of rxq related data | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 4 maintainers not CCed: ebiggers@google.com vinay.yadav@chelsio.com herbert@gondor.apana.org.au rohitm@chelsio.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 9 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Wed, 13 Jan 2021 10:13:02 +0530 Ayush Sawal wrote: > Removing initialization of nrxq and rxq_size in uld_info. As > ipsec uses nic queues only, there is no need to create uld > rx queues for ipsec. Why is this a fix? Does it break something or just wastes resources? If it's just about efficient use of resources I'll apply to net-next.
Hi Jakub, On 1/15/2021 12:12 AM, Jakub Kicinski wrote: > On Wed, 13 Jan 2021 10:13:02 +0530 Ayush Sawal wrote: >> Removing initialization of nrxq and rxq_size in uld_info. As >> ipsec uses nic queues only, there is no need to create uld >> rx queues for ipsec. > Why is this a fix? Does it break something or just wastes resources? > If it's just about efficient use of resources I'll apply to net-next. yes this patch is about efficient use of resources, please apply it to net-next. Thanks, Ayush
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 13 Jan 2021 10:13:02 +0530 you wrote: > Removing initialization of nrxq and rxq_size in uld_info. As > ipsec uses nic queues only, there is no need to create uld > rx queues for ipsec. > > Fixes: 1b77be463929e ("crypto/chcr: Moving chelsio's inline ipsec functionality to /drivers/net") > Signed-off-by: Ayush Sawal <ayush.sawal@chelsio.com> > > [...] Here is the summary with links: - [net] ch_ipsec: Remove initialization of rxq related data https://git.kernel.org/netdev/net-next/c/e3a7670737ec You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c b/drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c index 47d9268a7e3c..585590520076 100644 --- a/drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c +++ b/drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c @@ -92,9 +92,6 @@ static const struct xfrmdev_ops ch_ipsec_xfrmdev_ops = { static struct cxgb4_uld_info ch_ipsec_uld_info = { .name = CHIPSEC_DRV_MODULE_NAME, - .nrxq = MAX_ULD_QSETS, - /* Max ntxq will be derived from fw config file*/ - .rxq_size = 1024, .add = ch_ipsec_uld_add, .state_change = ch_ipsec_uld_state_change, .tx_handler = ch_ipsec_xmit,
Removing initialization of nrxq and rxq_size in uld_info. As ipsec uses nic queues only, there is no need to create uld rx queues for ipsec. Fixes: 1b77be463929e ("crypto/chcr: Moving chelsio's inline ipsec functionality to /drivers/net") Signed-off-by: Ayush Sawal <ayush.sawal@chelsio.com> --- .../net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c | 3 --- 1 file changed, 3 deletions(-)