diff mbox series

isci: style: remove the unneeded variable: "status".

Message ID 1609311860-102820-1-git-send-email-abaci-bugfix@linux.alibaba.com (mailing list archive)
State Accepted
Commit dc0bfdb563c866a3c86b553ea54a1eb74f56c22e
Headers show
Series isci: style: remove the unneeded variable: "status". | expand

Commit Message

Abaci Team Dec. 30, 2020, 7:04 a.m. UTC
The variable 'status' is being initialized with SCI_SUCCESS and never 
update later with a new value. The initialization is redundant and can 
be removed.

Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
Reported-by: Abaci <abaci@linux.alibaba.com>
---
 drivers/scsi/isci/request.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Martin K. Petersen Jan. 15, 2021, 4:08 a.m. UTC | #1
On Wed, 30 Dec 2020 15:04:20 +0800, YANG LI wrote:

> The variable 'status' is being initialized with SCI_SUCCESS and never
> update later with a new value. The initialization is redundant and can
> be removed.

Applied to 5.12/scsi-queue, thanks!

[1/1] isci: style: remove the unneeded variable: "status".
      https://git.kernel.org/mkp/scsi/c/dc0bfdb563c8
diff mbox series

Patch

diff --git a/drivers/scsi/isci/request.c b/drivers/scsi/isci/request.c
index 6e08179..bee1685 100644
--- a/drivers/scsi/isci/request.c
+++ b/drivers/scsi/isci/request.c
@@ -2103,8 +2103,6 @@  enum sci_status
 static enum sci_status stp_request_udma_await_tc_event(struct isci_request *ireq,
 						       u32 completion_code)
 {
-	enum sci_status status = SCI_SUCCESS;
-
 	switch (SCU_GET_COMPLETION_TL_STATUS(completion_code)) {
 	case SCU_MAKE_COMPLETION_STATUS(SCU_TASK_DONE_GOOD):
 		ireq->scu_status = SCU_TASK_DONE_GOOD;
@@ -2148,7 +2146,7 @@  static enum sci_status stp_request_udma_await_tc_event(struct isci_request *ireq
 		break;
 	}
 
-	return status;
+	return SCI_SUCCESS;
 }
 
 static enum sci_status atapi_raw_completion(struct isci_request *ireq, u32 completion_code,