mbox series

[00/40,Set,14] Rid W=1 warnings from GPU

Message ID 20210115181313.3431493-1-lee.jones@linaro.org (mailing list archive)
Headers show
Series Rid W=1 warnings from GPU | expand

Message

Lee Jones Jan. 15, 2021, 6:12 p.m. UTC 
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

Penultimate set, promise. :)

Lee Jones (40):
  drm/r128/r128_ioc32: Document headers do not make good kernel-doc
    candidates
  drm/mga/mga_ioc32: Document headers do not make good kernel-doc
    candidates
  drm/vmwgfx/vmwgfx_execbuf: Fix some kernel-doc related issues
  drm/vmwgfx/vmwgfx_kms: Remove unused variable 'ret' from
    'vmw_du_primary_plane_atomic_check()'
  drm/r128/r128_ioc32: Fix formatting issues in 'r128_compat_ioctl()'s
    header
  drm/mga/mga_ioc32: Fix some formatting issues in 'mga_compat_ioctl's
    header
  drm/vmwgfx/vmwgfx_kms: Mark vmw_{cursor,primary}_plane_formats as
    __maybe_unused
  drm/vmwgfx/vmwgfx_drv: Fix some kernel-doc misdemeanours
  drm/vmwgfx/vmwgfx_ioctl: Provide missing '@' sign required by
    kernel-doc
  drm/vmwgfx/vmwgfx_resource: Fix worthy function headers demote some
    others
  drm/vmwgfx/vmwgfx_ttm_buffer: Supply some missing parameter
    descriptions
  drm/vmwgfx/vmwgfx_fifo: Demote non-conformant kernel-doc header
  drm/vmwgfx/vmwgfx_ldu: Supply descriptions for 'state' function
    parameter
  drm/gma500/framebuffer: Fix some possible doc-rot issues
  drm/gma500/gem: Add and rename some function parameter descriptions
  drm/gma500/intel_bios: Demote non-conformant kernel-doc header
  drm/gma500/intel_i2c: Remove superflouous parameter description and
    rename another
  drm/gma500/mmu: Make local function 'psb_mmu_pt_alloc_map_lock()'
    static
  drm/gma500/power: Fix a bunch of *dev documentation issues
  drm/vmwgfx/vmwgfx_kms: Update worthy function headers and demote
    others
  drm/gma500/gma_display: Demote kernel-doc abuses to standard comment
    blocks
  drm/gma500/gma_device: Include our own header containing prototypes
  drm/vmwgfx/vmwgfx_overlay: Demote kernel-doc abuses to standard
    comment blocks
  drm/gma500/psb_intel_display: Demote kernel-doc formatting abuse
  drm/gma500/psb_intel_lvds: Supply description for 'mode_dev'
  drm/vmwgfx/vmwgfx_fence: Add, remove and demote various documentation
    params/headers
  drm/vmwgfx/vmwgfx_bo: Remove superfluous param description and supply
    another
  drm/vmwgfx/vmwgfx_context: Demote kernel-doc abuses
  drm/vmwgfx/vmwgfx_scrn: Demote unworthy kernel-doc headers and update
    others
  drm/gma500/psb_intel_modes: Provide missing descriptions for function
    param 'adapter'
  drm/gma500/gem: Do not rely on consumers to include drm/drm_device.h
    before gem.h
  drm/gma500/gem: Include our own header containing prototypes
  drm/vmwgfx/vmwgfx_surface: Fix some kernel-doc related issues
  drm/gma500/mmu: Remove unused function 'psb_get_default_pd_addr'
  drm/vmwgfx/vmwgfx_cmdbuf_res: Rename param description and remove
    another
  drm/vmwgfx/vmwgfx_shader: Demote kernel-doc abuses and fix-up worthy
    headers
  drm/vmwgfx/vmwgfx_cmdbuf: Fix a bunch of missing or incorrectly
    formatted/named params
  drm/gma500/power: Remove excess param description 'state'
  drm/vmwgfx/vmwgfx_cmdbuf_res: Remove unused variable 'ret'
  drm/vmwgfx/vmwgfx_stdu: Add some missing param/member descriptions

 drivers/gpu/drm/gma500/framebuffer.c       |  6 +++---
 drivers/gpu/drm/gma500/gem.c               |  6 ++++--
 drivers/gpu/drm/gma500/gem.h               |  2 ++
 drivers/gpu/drm/gma500/gma_device.c        |  1 +
 drivers/gpu/drm/gma500/gma_display.c       |  8 ++++----
 drivers/gpu/drm/gma500/intel_bios.c        |  2 +-
 drivers/gpu/drm/gma500/intel_i2c.c         |  3 +--
 drivers/gpu/drm/gma500/mmu.c               | 13 ++-----------
 drivers/gpu/drm/gma500/power.c             |  8 ++++----
 drivers/gpu/drm/gma500/psb_intel_display.c |  2 +-
 drivers/gpu/drm/gma500/psb_intel_lvds.c    |  1 +
 drivers/gpu/drm/gma500/psb_intel_modes.c   |  3 ++-
 drivers/gpu/drm/mga/mga_ioc32.c            | 14 +++++++-------
 drivers/gpu/drm/r128/r128_ioc32.c          | 14 +++++++-------
 drivers/gpu/drm/vmwgfx/vmwgfx_bo.c         |  2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_cmd.c        |  2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c     | 12 ++++++++----
 drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c |  8 ++------
 drivers/gpu/drm/vmwgfx/vmwgfx_context.c    |  6 +++---
 drivers/gpu/drm/vmwgfx/vmwgfx_drv.c        |  8 ++++----
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c    | 20 ++++++++++++--------
 drivers/gpu/drm/vmwgfx/vmwgfx_fence.c      | 18 ++++++++++--------
 drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c      |  2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c        | 16 ++++++++--------
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.h        |  4 ++--
 drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c        |  4 +++-
 drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c    | 16 ++++++++--------
 drivers/gpu/drm/vmwgfx/vmwgfx_resource.c   | 10 ++++------
 drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c       | 10 ++++++----
 drivers/gpu/drm/vmwgfx/vmwgfx_shader.c     | 10 +++++-----
 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c       |  9 +++++++--
 drivers/gpu/drm/vmwgfx/vmwgfx_surface.c    | 17 ++++++++++-------
 drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c |  2 ++
 33 files changed, 137 insertions(+), 122 deletions(-)

Cc: Alan Cox <alan@linux.intel.com>
Cc: Benjamin Defnet <benjamin.r.defnet@intel.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Cc: Eric Anholt <eric@anholt.net>
Cc: Jesse Barnes <jesse.barnes@intel.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-media@vger.kernel.org
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: Rajesh Poornachandran <rajesh.poornachandran@intel.com>
Cc: Roland Scheidegger <sroland@vmware.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
Cc: Zack Rusin <zackr@vmware.com>

Comments

Zack Rusin Jan. 15, 2021, 6:22 p.m. UTC | #1 
> On Jan 15, 2021, at 13:12, Lee Jones <lee.jones@linaro.org> wrote:
> 
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
> 
> Penultimate set, promise. :)


Thank you for all that work. For all the vmwgfx bits:
Reviewed-by: Zack Rusin <zackr@vmware.com>

z
Daniel Vetter Jan. 18, 2021, 2:46 p.m. UTC | #2 
On Fri, Jan 15, 2021 at 06:22:23PM +0000, Zack Rusin wrote:
> 
> > On Jan 15, 2021, at 13:12, Lee Jones <lee.jones@linaro.org> wrote:
> > 
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> > 
> > Penultimate set, promise. :)
> 
> 
> Thank you for all that work. For all the vmwgfx bits:
> Reviewed-by: Zack Rusin <zackr@vmware.com>

I pulled all the non-vmxgfx patches to drm-misc-next, I'll leave the vmw
stuff to Zack.

Thanks for your work here!
-Daniel