diff mbox series

[2/4] tests/qtest: Make fuzz-test generic to all targets

Message ID 20210115150936.3333282-3-philmd@redhat.com (mailing list archive)
State New, archived
Headers show
Series tests/qtest: Fixes fuzz-tests | expand

Commit Message

Philippe Mathieu-Daudé Jan. 15, 2021, 3:09 p.m. UTC
Tests in fuzz-test's main() already check for the supported
architecture before adding tests, therefore this test is not
specific to the X86 target. Move it to the generic set.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 tests/qtest/meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Thomas Huth Jan. 15, 2021, 10:21 p.m. UTC | #1
On 15/01/2021 16.09, Philippe Mathieu-Daudé wrote:
> Tests in fuzz-test's main() already check for the supported
> architecture before adding tests, therefore this test is not
> specific to the X86 target. Move it to the generic set.

As long as it does not run any test on non-x86, it does not make sense to 
move it to the generic set, does it? We'd only waste compile cycles that way?

  Thomas
Philippe Mathieu-Daudé Jan. 26, 2021, 11:07 a.m. UTC | #2
On 1/15/21 11:21 PM, Thomas Huth wrote:
> On 15/01/2021 16.09, Philippe Mathieu-Daudé wrote:
>> Tests in fuzz-test's main() already check for the supported
>> architecture before adding tests, therefore this test is not
>> specific to the X86 target. Move it to the generic set.
> 
> As long as it does not run any test on non-x86, it does not make sense
> to move it to the generic set, does it? We'd only waste compile cycles
> that way?

OK, I'll resend this patch when the ARM reproducers are posted.
diff mbox series

Patch

diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index bcbb04d2bb4..874f5d34674 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -13,7 +13,9 @@ 
   'qom-test',
   'test-hmp',
   'qos-test',
+  'fuzz-test',
 ]
+
 if config_host.has_key('CONFIG_MODULES')
   qtests_generic += [ 'modules-test' ]
 endif
@@ -50,7 +52,6 @@ 
    'bios-tables-test',
    'rtc-test',
    'i440fx-test',
-   'fuzz-test',
    'fw_cfg-test',
    'device-plug-test',
    'drive_del-test',