| Message ID | 20210117181519.527625-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7cfabe4f85a52a06943236a7747f1d868f3cac4b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | arcnet: fix macro name when DEBUG is defined | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 5 of 5 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Sun, 2021-01-17 at 10:15 -0800, trix@redhat.com wrote: > From: Tom Rix <trix@redhat.com> > > When DEBUG is defined this error occurs > > drivers/net/arcnet/com20020_cs.c:70:15: error: ‘com20020_REG_W_ADDR_HI’ > undeclared (first use in this function); > did you mean ‘COM20020_REG_W_ADDR_HI’? > ioaddr, com20020_REG_W_ADDR_HI); > ^~~~~~~~~~~~~~~~~~~~~~ > > From reviewing the context, the suggestion is what is meant. > > Fixes: 0fec65130b9f ("arcnet: com20020: Use arcnet_<I/O> routines") Nice find thanks, especially seeing as how this hasn't been tested or compiled in 5+ years... commit 0fec65130b9f11a73d74f47025491f97f82ba070 Author: Joe Perches <joe@perches.com> Date: Tue May 5 10:06:06 2015 -0700 Acked-by: Joe Perches <joe@perches.com> > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/net/arcnet/com20020_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/arcnet/com20020_cs.c b/drivers/net/arcnet/com20020_cs.c > index cf607ffcf358..81223f6bebcc 100644 > --- a/drivers/net/arcnet/com20020_cs.c > +++ b/drivers/net/arcnet/com20020_cs.c > @@ -67,7 +67,7 @@ static void regdump(struct net_device *dev) > /* set up the address register */ > count = 0; > arcnet_outb((count >> 8) | RDDATAflag | AUTOINCflag, > - ioaddr, com20020_REG_W_ADDR_HI); > + ioaddr, COM20020_REG_W_ADDR_HI); > arcnet_outb(count & 0xff, ioaddr, COM20020_REG_W_ADDR_LO); > > > for (count = 0; count < 256 + 32; count++) {
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 17 Jan 2021 10:15:19 -0800 you wrote: > From: Tom Rix <trix@redhat.com> > > When DEBUG is defined this error occurs > > drivers/net/arcnet/com20020_cs.c:70:15: error: ‘com20020_REG_W_ADDR_HI’ > undeclared (first use in this function); > did you mean ‘COM20020_REG_W_ADDR_HI’? > ioaddr, com20020_REG_W_ADDR_HI); > ^~~~~~~~~~~~~~~~~~~~~~ > > [...] Here is the summary with links: - arcnet: fix macro name when DEBUG is defined https://git.kernel.org/netdev/net-next/c/7cfabe4f85a5 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/arcnet/com20020_cs.c b/drivers/net/arcnet/com20020_cs.c index cf607ffcf358..81223f6bebcc 100644 --- a/drivers/net/arcnet/com20020_cs.c +++ b/drivers/net/arcnet/com20020_cs.c @@ -67,7 +67,7 @@ static void regdump(struct net_device *dev) /* set up the address register */ count = 0; arcnet_outb((count >> 8) | RDDATAflag | AUTOINCflag, - ioaddr, com20020_REG_W_ADDR_HI); + ioaddr, COM20020_REG_W_ADDR_HI); arcnet_outb(count & 0xff, ioaddr, COM20020_REG_W_ADDR_LO); for (count = 0; count < 256 + 32; count++) {