mbox series

[net-next,0/4] i40e: small improvements on XDP path

Message ID 20210114143318.2171-1-cristian.dumitrescu@intel.com (mailing list archive)
Headers show
Series i40e: small improvements on XDP path | expand

Message

Cristian Dumitrescu Jan. 14, 2021, 2:33 p.m. UTC
This patchset introduces some small and straightforward improvements
to the Intel i40e driver XDP path. Each improvement is fully described
in its associated patch.

Cristian Dumitrescu (4):
  i40e: remove unnecessary memory writes of the next to clean pointer
  i40e: remove unnecessary cleaned_count updates
  i40e: remove the redundant buffer info updates
  i40: consolidate handling of XDP program actions

 drivers/net/ethernet/intel/i40e/i40e_xsk.c | 149 +++++++++++----------
 1 file changed, 79 insertions(+), 70 deletions(-)

Comments

Saeed Mahameed Jan. 14, 2021, 10:59 p.m. UTC | #1
On Thu, 2021-01-14 at 14:33 +0000, Cristian Dumitrescu wrote:
> This patchset introduces some small and straightforward improvements
> to the Intel i40e driver XDP path. Each improvement is fully
> described
> in its associated patch.
> 
> Cristian Dumitrescu (4):
>   i40e: remove unnecessary memory writes of the next to clean pointer
>   i40e: remove unnecessary cleaned_count updates
>   i40e: remove the redundant buffer info updates
>   i40: consolidate handling of XDP program actions
> 
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 149 +++++++++++------
> ----
>  1 file changed, 79 insertions(+), 70 deletions(-)
> 
FWIW,
Reviewed-by: Saeed Mahameed <saeedm@nvidia.com>
Magnus Karlsson Jan. 18, 2021, 7:31 a.m. UTC | #2
On Thu, Jan 14, 2021 at 3:34 PM Cristian Dumitrescu
<cristian.dumitrescu@intel.com> wrote:
>
> This patchset introduces some small and straightforward improvements
> to the Intel i40e driver XDP path. Each improvement is fully described
> in its associated patch.
>
> Cristian Dumitrescu (4):
>   i40e: remove unnecessary memory writes of the next to clean pointer
>   i40e: remove unnecessary cleaned_count updates
>   i40e: remove the redundant buffer info updates
>   i40: consolidate handling of XDP program actions
>
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 149 +++++++++++----------
>  1 file changed, 79 insertions(+), 70 deletions(-)
>
> --
> 2.25.1
>

Thank you for these clean ups Cristian!

For the series:

Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>
Jakub Kicinski Jan. 18, 2021, 6:32 p.m. UTC | #3
On Mon, 18 Jan 2021 08:31:23 +0100 Magnus Karlsson wrote:
> On Thu, Jan 14, 2021 at 3:34 PM Cristian Dumitrescu
> <cristian.dumitrescu@intel.com> wrote:
> >
> > This patchset introduces some small and straightforward improvements
> > to the Intel i40e driver XDP path. Each improvement is fully described
> > in its associated patch.
> 
> Thank you for these clean ups Cristian!
> 
> For the series:
> 
> Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>

FWIW since this series is 100% driver code I'm expecting it will 
come downstream via Tony's tree. Please LMK if that's not the case.
Maciej Fijalkowski May 7, 2021, 10:11 p.m. UTC | #4
On Mon, Jan 18, 2021 at 10:32:33AM -0800, Jakub Kicinski wrote:
> On Mon, 18 Jan 2021 08:31:23 +0100 Magnus Karlsson wrote:
> > On Thu, Jan 14, 2021 at 3:34 PM Cristian Dumitrescu
> > <cristian.dumitrescu@intel.com> wrote:
> > >
> > > This patchset introduces some small and straightforward improvements
> > > to the Intel i40e driver XDP path. Each improvement is fully described
> > > in its associated patch.
> > 
> > Thank you for these clean ups Cristian!
> > 
> > For the series:
> > 
> > Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>
> 
> FWIW since this series is 100% driver code I'm expecting it will 
> come downstream via Tony's tree. Please LMK if that's not the case.

I just realized that this set got somewhat abandonded. Tony, can you pick
this? I wouldn't be surprised if it wouldn't apply cleanly anymore since
it has been almost 4 months since the initial submission, but let's see...
Otherwise we probably would have to ask Cristian to re-submit directly to
IWL I guess.
Tony Nguyen May 7, 2021, 10:53 p.m. UTC | #5
On Sat, 2021-05-08 at 00:11 +0200, Maciej Fijalkowski wrote:
> On Mon, Jan 18, 2021 at 10:32:33AM -0800, Jakub Kicinski wrote:
> > On Mon, 18 Jan 2021 08:31:23 +0100 Magnus Karlsson wrote:
> > > On Thu, Jan 14, 2021 at 3:34 PM Cristian Dumitrescu
> > > <cristian.dumitrescu@intel.com> wrote:
> > > > 
> > > > This patchset introduces some small and straightforward
> > > > improvements
> > > > to the Intel i40e driver XDP path. Each improvement is fully
> > > > described
> > > > in its associated patch.
> > > 
> > > Thank you for these clean ups Cristian!
> > > 
> > > For the series:
> > > 
> > > Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>
> > 
> > FWIW since this series is 100% driver code I'm expecting it will 
> > come downstream via Tony's tree. Please LMK if that's not the case.
> 
> I just realized that this set got somewhat abandonded. Tony, can you
> pick
> this? I wouldn't be surprised if it wouldn't apply cleanly anymore
> since
> it has been almost 4 months since the initial submission, but let's
> see...
> Otherwise we probably would have to ask Cristian to re-submit
> directly to
> IWL I guess.

If I'm not mistaken, these were sent and accepted in this request.

https://lore.kernel.org/netdev/20210209022323.2440775-1-anthony.l.nguyen@intel.com/

Thanks,
Tony